Re: [COMMITTERS] pgsql: Refactor libpqwalreceiver

2016-12-02 Thread Alvaro Herrera
Petr Jelinek wrote: > Yes, that seems to be the case. > > Something as simple as attached should do. Pushed. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-c

Re: [COMMITTERS] pgsql: Refactor libpqwalreceiver

2016-12-02 Thread Petr Jelinek
On 02/12/16 05:17, Alvaro Herrera wrote: > Tom Lane wrote: >> Peter Eisentraut writes: >>> Refactor libpqwalreceiver >> >> Buildfarm results indicate this broke the Windows build. > > src/backend/replication/walreceiver.c(296): error C2039: 'pgwin32_connect' : > is not a member of 'WalReceiverFu

Re: [COMMITTERS] pgsql: Refactor libpqwalreceiver

2016-12-01 Thread Alvaro Herrera
Tom Lane wrote: > Peter Eisentraut writes: > > Refactor libpqwalreceiver > > Buildfarm results indicate this broke the Windows build. src/backend/replication/walreceiver.c(296): error C2039: 'pgwin32_connect' : is not a member of 'WalReceiverFunctionsType' [c:\prog\bf\root\HEAD\pgsql.build\pos

Re: [COMMITTERS] pgsql: Refactor libpqwalreceiver

2016-12-01 Thread Tom Lane
Peter Eisentraut writes: > Refactor libpqwalreceiver Buildfarm results indicate this broke the Windows build. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/m

[COMMITTERS] pgsql: Refactor libpqwalreceiver

2016-12-01 Thread Peter Eisentraut
Refactor libpqwalreceiver The whole walreceiver API is now wrapped into a struct, like most of our other loadable module APIs. The libpq connection is no longer a global variable in libpqwalreceiver. Instead, it is encapsulated into a struct that is passed around the functions. This allows mult