[COMMITTERS] pgsql: Retry DSM control segment creation if Windows indicates access d

2016-09-20 Thread Robert Haas 
Retry DSM control segment creation if Windows indicates access denied.

Otherwise, attempts to run multiple postmasters running on the same
machine may fail, because Windows sometimes returns ERROR_ACCESS_DENIED
rather than ERROR_ALREADY_EXISTS when there is an existing segment.

Hitting this bug is much more likely because of another defect not
fixed by this patch, namely that dsm_postmaster_startup() uses
random() which returns the same value every time.  But that's not
a reason not to fix this.

Kyotaro Horiguchi and Amit Kapila, reviewed by Michael Paquier

Discussion: 

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/c23b2523d3fcc09524e6720d7c2558ba1ee6c239

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Retry DSM control segment creation if Windows indicates access d

2016-09-20 Thread Robert Haas 
Retry DSM control segment creation if Windows indicates access denied.

Otherwise, attempts to run multiple postmasters running on the same
machine may fail, because Windows sometimes returns ERROR_ACCESS_DENIED
rather than ERROR_ALREADY_EXISTS when there is an existing segment.

Hitting this bug is much more likely because of another defect not
fixed by this patch, namely that dsm_postmaster_startup() uses
random() which returns the same value every time.  But that's not
a reason not to fix this.

Kyotaro Horiguchi and Amit Kapila, reviewed by Michael Paquier

Discussion: 

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/419113dfdc4c729f6c763cc30a9b02ee68a7da94

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Retry DSM control segment creation if Windows indicates access d

2016-09-20 Thread Robert Haas 
Retry DSM control segment creation if Windows indicates access denied.

Otherwise, attempts to run multiple postmasters running on the same
machine may fail, because Windows sometimes returns ERROR_ACCESS_DENIED
rather than ERROR_ALREADY_EXISTS when there is an existing segment.

Hitting this bug is much more likely because of another defect not
fixed by this patch, namely that dsm_postmaster_startup() uses
random() which returns the same value every time.  But that's not
a reason not to fix this.

Kyotaro Horiguchi and Amit Kapila, reviewed by Michael Paquier

Discussion: 

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/6bcd26c43c4f0ef718e984643338ddd5b207f9f9

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Retry DSM control segment creation if Windows indicates access d

2016-09-20 Thread Robert Haas 
Retry DSM control segment creation if Windows indicates access denied.

Otherwise, attempts to run multiple postmasters running on the same
machine may fail, because Windows sometimes returns ERROR_ACCESS_DENIED
rather than ERROR_ALREADY_EXISTS when there is an existing segment.

Hitting this bug is much more likely because of another defect not
fixed by this patch, namely that dsm_postmaster_startup() uses
random() which returns the same value every time.  But that's not
a reason not to fix this.

Kyotaro Horiguchi and Amit Kapila, reviewed by Michael Paquier

Discussion: 

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/c124e3649b0423cd7abc3f81208d9c7e8a7e8a8a

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers