Re: SPI not defined.

2018-01-29 Thread Bruce Momjian
On Mon, Jan 29, 2018 at 08:58:10PM -0700, David G. Johnston wrote: > On Mon, Jan 29, 2018 at 8:55 PM, Bruce Momjian wrote: > > On Mon, Jan 29, 2018 at 10:51:59PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > How is the attached patch? >

Re: SPI not defined.

2018-01-29 Thread Tom Lane
Bruce Momjian writes: > OK, updated patch with both fixes. AFAICS that's the same patch you posted before. regards, tom lane

Re: SPI not defined.

2018-01-29 Thread David G. Johnston
On Mon, Jan 29, 2018 at 8:55 PM, Bruce Momjian wrote: > On Mon, Jan 29, 2018 at 10:51:59PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > How is the attached patch? > > > > Maybe also make that text into a hyperlink to the SPI manual chapter? > > Yes,

Re: SPI not defined.

2018-01-29 Thread Bruce Momjian
On Mon, Jan 29, 2018 at 08:39:22PM -0700, David G. Johnston wrote: > On Monday, January 29, 2018, Bruce Momjian wrote: > > > How is the attached patch? > > > > Maybe add a link to: > >  https://www.postgresql.org/docs/10/static/spi.html > > Also, on that page, the

Re: SPI not defined.

2018-01-29 Thread Bruce Momjian
On Mon, Jan 29, 2018 at 10:51:59PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > How is the attached patch? > > Maybe also make that text into a hyperlink to the SPI manual chapter? Yes, that's what I just did in the new patch. -- Bruce Momjian

Re: SPI not defined.

2018-01-29 Thread Tom Lane
Bruce Momjian writes: > How is the attached patch? Maybe also make that text into a hyperlink to the SPI manual chapter? regards, tom lane

Re: SPI not defined.

2018-01-29 Thread David G. Johnston
On Monday, January 29, 2018, Bruce Momjian wrote: > > How is the attached patch? > > Maybe add a link to: https://www.postgresql.org/docs/10/static/spi.html Also, on that page, the error handling mechanisms have been "in flux" since 8.0 ... ? " This is not currently

Re: SPI not defined.

2018-01-29 Thread Bruce Momjian
On Mon, Jan 29, 2018 at 03:07:06PM -0700, David G. Johnston wrote: > On Monday, January 29, 2018, PG Doc comments form > No, SPI in that module is indeed "Server Programming Interface". > >   I would recommend that the module page define > > the spi acronym. > >

Re: pg_upgrade docs are confusing if PostgreSQL's versioning system/language isn't known to reader

2018-01-29 Thread Jim Ryan
This looks great. Thanks for working on it. Jim On Sat, Jan 27, 2018 at 10:05 AM, Bruce Momjian wrote: > On Fri, Jan 26, 2018 at 11:35:09AM -0700, David G. Johnston wrote: > > On Friday, January 26, 2018, Jim Ryan wrote: > > > > Hey Bruce, > >

Re: pg_upgrade docs are confusing if PostgreSQL's versioning system/language isn't known to reader

2018-01-29 Thread David G. Johnston
On Sat, Jan 27, 2018 at 8:05 AM, Bruce Momjian wrote: > I decided I needed to be more explicit about the major version numbers > so I have added major and minor examples for the 9.6.x series and 10.x > series releases. Patch attached. > > ​Thanks!​ ​+1 ​David J.

Re: SPI not defined.

2018-01-29 Thread David G. Johnston
On Monday, January 29, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/contrib-spi.html > Description: > > In the appendix for Additional Supplied Modules there is

Re: Trigger behaviour not as stated

2018-01-29 Thread Bruce Momjian
On Mon, Jan 29, 2018 at 11:32:34AM +, Ian R. Campbell wrote: > The second part of the confusion is that INSERT is not considered to be a row > modification and will fire a BEFORE INSERT trigger on the parent table even > when the data goes into a child (whereas UPDATE and DELETE will not fire