Re: Fix contributor name-related inconsistencies in release-12.sgml

2019-09-24 Thread Alexander Law
Hello, ср, 25 сент. 2019 г., 8:10 Michael Paquier : > On Tue, Sep 24, 2019 at 06:52:18PM -0400, Tom Lane wrote: > > I have no strong feelings either way, so feel free to undo whatever > > you think should be undone. > > > > I have noted that many of our Japanese contributors show a different

Re: Fix contributor name-related inconsistencies in release-12.sgml

2019-09-24 Thread Tom Lane
Peter Eisentraut writes: > On 2019-09-23 13:08, Alexander Lakhin wrote: >> While translating Release Notes for version 12 I found some >> inconsistencies with contributor names. > We had discussed this in previous years and resolved that we use the > forms that these individuals use when posting

Re: I'm surprised to see the word master here

2019-09-24 Thread Dave Cramer
Ya, I was under that impression as well. Dave Cramer On Tue, 24 Sep 2019 at 18:18, Renee wrote: > I was under the impression that both terms were being deprecated. Is that > only the case when they appear in tandem? > > > On Sep 24, 2019, at 6:05 PM, Peter Eisentraut < >

Re: I'm surprised to see the word master here

2019-09-24 Thread Renee
I was under the impression that both terms were being deprecated. Is that only the case when they appear in tandem? > On Sep 24, 2019, at 6:05 PM, Peter Eisentraut > wrote: > >> On 2019-09-24 21:58, PG Doc comments form wrote: >> The following documentation comment has been logged on the

Re: Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.

2019-09-24 Thread Tom Lane
Peter Eisentraut writes: > PostgreSQL 12 requires C99, so those guidelines should probably be > rephrased from "because old compilers don't accept it" to "because we > like it that way". Yeah, or more formally "to encourage consistent coding style". regards, tom lane

Re: Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.

2019-09-24 Thread Peter Eisentraut
On 2019-09-23 16:39, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/source-format.html > Description: > > This sentence in the style guide feels outdated. // style comments have been > in the ANSI C

Re: I'm surprised to see the word master here

2019-09-24 Thread Peter Eisentraut
On 2019-09-24 21:58, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/logical-replication-publication.html > Description: > > I was under the impression we were removing the use of that word from our >

Re: Fix contributor name-related inconsistencies in release-12.sgml

2019-09-24 Thread Peter Eisentraut
On 2019-09-23 13:08, Alexander Lakhin wrote: > While translating Release Notes for version 12 I found some > inconsistencies with contributor names. > 1. Constantine Kuznetsov and Konstantin Kuznetsov are the same person. > 2. Sho Kato and Kato Sho too. > 3. Takayuki Tsunakawa is present in the

I'm surprised to see the word master here

2019-09-24 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/logical-replication-publication.html Description: I was under the impression we were removing the use of that word from our docs ?

Re: returning does not act as expected after viewing documentation

2019-09-24 Thread lennart rolland
Facepalm. Please disregard my rookie mistake! On Tue, Sep 24, 2019, 00:18 David G. Johnston wrote: > On Mon, Sep 23, 2019 at 2:45 PM PG Doc comments form < > nore...@postgresql.org> wrote: > >> update batch_log >> set status=('in-progress'), >> updated_at=now() >> [...] >> returning id,