Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-25 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 02:02:20PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > OK, I didn't think there was enough desire to put it its own paragraph, > > but I like the idea of mentioning all of the trigger functions; patch > > attached. > > This one WFM. Patch applied to all supported

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Alvaro Herrera
On 2020-Jun-25, Steven Pousty wrote: > I like the direction as well as long as each of the items in the glossary > has an anchor and you can link to it from the rest of the documents. It has. > The reader, if they are confused by the term, should be able to go get > a quick definition without

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Steven Pousty
On Thu, Jun 25, 2020 at 12:25 PM Bruce Momjian wrote: > On Thu, Jun 25, 2020 at 03:12:44PM -0400, Alvaro Herrera wrote: > > We have a glossary page as of Postgres 13[1]; since it's new, links to it > > have not yet percolated to the rest of the docs, but that should start > > happening in the

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Bruce Momjian
On Thu, Jun 25, 2020 at 03:12:44PM -0400, Alvaro Herrera wrote: > We have a glossary page as of Postgres 13[1]; since it's new, links to it > have not yet percolated to the rest of the docs, but that should start > happening in the pg14 cycle. > > You're welcome to submit a patch that adds the

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Alvaro Herrera
We have a glossary page as of Postgres 13[1]; since it's new, links to it have not yet percolated to the rest of the docs, but that should start happening in the pg14 cycle. You're welcome to submit a patch that adds the term you want to link as well as a patch that turns the text you want into a

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Steven Pousty
On Thu, Jun 25, 2020 at 11:41 AM Bruce Momjian wrote: > On Thu, Jun 25, 2020 at 11:39:46AM -0700, Steven Pousty wrote: > > A journey of a thousand miles can start with one step :D > > Yeah, but we have to have consistency. We would need to get approval to > do it in all relevent places, and get

Re: wrong output column title in example

2020-06-25 Thread Tom Lane
Daniel Gustafsson writes: > On 21 Jun 2020, at 21:07, Erik Rijkers wrote: >> Here is a doc fix/patch. > While clearly in nitpicking territory, this isn't entirelty right either as > the > number of dashes needs to be updated to reflect the attr name. Looking it, > the > output also has

Re: listing roles

2020-06-25 Thread Bruce Momjian
On Wed, Jun 24, 2020 at 05:33:00PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/user-manag.html > Description: > > Thank you for perfect documentation. > I am missing in chapter 21 (Database

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Bruce Momjian
On Thu, Jun 25, 2020 at 10:17:56AM -0400, Dave Cramer wrote: > > > On Thu, 25 Jun 2020 at 10:10, Bruce Momjian wrote: > > On Wed, Jun 24, 2020 at 05:13:05PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page:

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Dave Cramer
On Thu, 25 Jun 2020 at 10:10, Bruce Momjian wrote: > On Wed, Jun 24, 2020 at 05:13:05PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/indexes-types.html > > Description: > > > > Can you

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Bruce Momjian
On Wed, Jun 24, 2020 at 05:13:05PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/indexes-types.html > Description: > > Can you please add a link to an explanation for physical block ranges of

listing roles

2020-06-25 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/user-manag.html Description: Thank you for perfect documentation. I am missing in chapter 21 (Database roles) a section about *listing roles* both as psql commands and selects to

Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/indexes-types.html Description: Can you please add a link to an explanation for physical block ranges of a table under the BRIN index. This is not explained in the index and might be

Re: wrong output column title in example

2020-06-25 Thread Daniel Gustafsson
> On 21 Jun 2020, at 21:07, Erik Rijkers wrote: > > On 2020-06-21 18:21, PG Doc comments form wrote: >> The following documentation comment has been logged on the website: >> Page: https://www.postgresql.org/docs/12/arrays.html >> Description: >> In the last code block in "8.15.5. Searching in