Re: Please provide examples of rows from

2020-09-14 Thread David G. Johnston
On Thu, Sep 3, 2020 at 6:46 PM Bruce Momjian wrote: > On Wed, Apr 8, 2020 at 09:50:44PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/queries-table-expressions.html > > Description: > >

Re: Chapter 7. Queries

2020-09-14 Thread David G. Johnston
On Fri, Sep 11, 2020 at 2:37 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/queries.html > Description: > > I like to browse documentation by index rather than searching. What you describe is brow

Re: Installation instructions vs binaries

2020-09-14 Thread David G. Johnston
On Tue, Sep 8, 2020 at 8:05 AM Magnus Hagander wrote: > On Tue, Sep 8, 2020 at 4:51 PM Tom Lane wrote: > >> Magnus Hagander writes: >> > I think we're talking about a different repetitiveness. If I apply >> Davids >> > suggestion to that patch, then instead of: >> >> > + >> > + If you are u

Re: replication wordsmithing / clarifications

2020-09-14 Thread Michael Paquier
On Sat, Sep 12, 2020 at 12:40:45PM -0400, Robert Treat wrote: > maybe "to one or more replicas." or maybe "to one or more replica > targets." I'd avoid the word cluster because you could set it up to > send to multiple databases in the same postgres cluster. Magnus has given a better suggestion: t

Re: replication wordsmithing / clarifications

2020-09-14 Thread Michael Paquier
On Sat, Sep 12, 2020 at 11:52:11AM +0200, Magnus Hagander wrote: > In particular, why is the primary a "server" and the replica a "node"? That > caught my eye for inconsistency -- but changing node to cluster will be > equally inconsistent, just in a different way. Why not just call them both > ser

Re: Fix the example in the document of file-fdw

2020-09-14 Thread Michael Paquier
On Mon, Sep 14, 2020 at 04:10:03PM +0900, btkatsuragiyu wrote: > However, I think showing complete DDL including SERVER pglog and OPTIONS > would be helpful > to users who are not familiar with this feature. Yeah, this could be mentioned on the doc page for file_fdw with an extra sentence, but I a

Re: Fix the example in the document of file-fdw

2020-09-14 Thread btkatsuragiyu
On 2020-09-14 14:07, Michael Paquier wrote: On Mon, Sep 14, 2020 at 11:33:23AM +0900, Fujii Masao wrote: On 2020/09/14 11:19, btkatsuragiyu wrote: This patch fixes the DDL in the document of file-fdw. Thanks for the patch! LGTM. I will commit it. Hmm. Instead of keeping a copy-paste of the