Re: COMMENT ON lock

2022-01-18 Thread Michael Paquier
On Tue, Jan 18, 2022 at 03:37:35PM +0100, Laurenz Albe wrote: > On Tue, 2022-01-18 at 14:11 +, nikolai.berkoff wrote: >> I wanted to know what lock the COMMENT ON command took and I had to look in >> the >> source code, makes sense to me that it should be documented.  I've also added >> it to

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-18 Thread David G. Johnston
On Tue, Jan 18, 2022 at 4:01 PM Eric Mutta wrote: > > 2. I noticed the typo and on the top right of the page there's an "edit" > link. Click that and it takes you to GitHub where the Markdown text is. > I suspect a large part of your expectation is based upon this and that GitHub can display pro

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-18 Thread Eric Mutta
Hi Magnus, You are correct that doing a Pull Request would involve more overhead in terms of checking out code, doing builds, etc, however GitHub automates much of that and it all runs in the cloud so you can do it in a browser on your phone while on the train if you wanted to. It literally takes

Re: COMMENT ON lock

2022-01-18 Thread Laurenz Albe
On Tue, 2022-01-18 at 14:11 +, nikolai.berkoff wrote: > I wanted to know what lock the COMMENT ON command took and I had to look in > the > source code, makes sense to me that it should be documented.  I've also added > it to the list of commands that take a SHARE UPDATE EXCLUSIVE lock. +1, b

COMMENT ON lock

2022-01-18 Thread nikolai.berkoff
I wanted to know what lock the COMMENT ON command took and I had to look in the source code, makes sense to me that it should be documented. I've also added it to the list of commands that take a SHARE UPDATE EXCLUSIVE lock. Regards, Nikolaidiff --git i/doc/src/sgml/mvcc.sgml w/doc/src/sgml/m

gettext instructions for Windows seems wrong

2022-01-18 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/install-windows-full.html Description: I have to build Postgres on Windows 10. I got everything building from a git checkout without NLS. I followed the instructions the way I understood t