Re: column_name of ALTER MATERIALIZED VIEW should only refer to an existing column

2024-05-22 Thread Michael Paquier
On Wed, May 22, 2024 at 02:12:36PM +0900, Michael Paquier wrote: > Will fix once we are out of release freeze time on HEAD. Thanks! And done as of dd087e1c13bf. -- Michael signature.asc Description: PGP signature

Re: Add small detail to RAISE statement descripton

2024-05-22 Thread Igor Gnatyuk
Hi, thanks for the response and for your corrections to the patch. But I checked my changes by running make html, make postgres-A4.pdf, make postgres-US.pdf and viewing the results: everything is OK. Message 'old mode 100644 new mode 100755' this means, imho, that access rights were changed durin

Re: Add small detail to RAISE statement descripton

2024-05-22 Thread jian he
On Wed, May 22, 2024 at 4:18 PM Igor Gnatyuk wrote: > > Hi. > > Thanks for the comments. I fixed my mistakes by specifying sqlcode > instead of sqlstate and changed the phrase > with an explicit listing of options in USING. In addition, I moved the > paragraph with it below. > Please check out the

Re: Ambiguous description on new columns

2024-05-22 Thread Peter Smith
On Tue, May 21, 2024 at 8:40 PM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column list is

Re: Add small detail to RAISE statement descripton

2024-05-22 Thread Igor Gnatyuk
Hi. Thanks for the comments. I fixed my mistakes by specifying sqlcode instead of sqlstate and changed the phrase with an explicit listing of options in USING. In addition, I moved the paragraph with it below. Please check out the new patch version in the attachment. Regards, Igor Gnatyuk вс, 19

Re: Ambiguous description on new columns

2024-05-22 Thread Laurenz Albe
On Wed, 2024-05-22 at 12:47 +1000, Peter Smith wrote: > I think the following small change will remove any ambiguity: > > BEFORE > If no column list is specified, any columns added later are > automatically replicated. > > SUGGESTION > If no column list is specified, any columns added to the tabl