On Wed, Jul 24, 2024 at 9:02 AM Zhijie Hou (Fujitsu)
wrote:
>
> Thanks for the patch.
>
> Here is one comment:
>
> The second query has a condition 'WHERE slot_name IS NOT NULL', but I
> think it belongs to the first query. Because the slot_name of second query
> is built by CONCAT() which means i
On Wednesday, July 24, 2024 10:56 AM shveta malik
wrote:
>
> On Tue, Jul 23, 2024 at 5:10 PM Amit Kapila wrote:
> >
> > One minor comment:
> > - if the table copy is finished (See > linkend="catalog-pg-subscription-rel"/>).
> > + On the subscriber node, use the following SQL to identif
On Tue, Jul 23, 2024 at 5:10 PM Amit Kapila wrote:
>
> One minor comment:
> - if the table copy is finished (See linkend="catalog-pg-subscription-rel"/>).
> + On the subscriber node, use the following SQL to identify which main
> + slots should be synced to the standby that we plan to
On Tue, Jul 23, 2024 at 9:40 AM shveta malik wrote:
>
> On Tue, Jul 23, 2024 at 8:14 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > I also agree that separating the 2 queries makes sense.
>
> Please find the patch with the suggested change.
>
One minor comment:
- if the table copy is finished (See
On 23 Jul 2024, at 01:39, Michael Paquier wrote:On Mon, Jul 22, 2024 at 01:55:52PM +, PG Doc comments form wrote:Inhttps://www.postgresql.org/docs/16/plpgsql-control-structures.html#PLPGSQL-ERROR-TRAPPINGhandler_statements are documented as optional.However, the following example shows that ha
