Re: Undocumented optionality of handler_statements

2024-09-10 Thread Michael Paquier
On Tue, Jul 23, 2024 at 01:25:39PM +0200, Philipp Salvisberg wrote: > read "optional" as "mandatory". They're optional, like in empty being optional. If not specified, the block goes to its END. > Therefore, I suggest to change this example by adding a NULL > statement as in other examples. This

Re: Table rewrite supporting functions for event triggers

2024-09-10 Thread Michael Paquier
On Tue, Sep 03, 2024 at 09:34:02PM +0200, Laurenz Albe wrote: > On Tue, 2024-09-03 at 11:54 -0400, Greg Sabino Mullane wrote: >> How about something like this? > > This patch looks good to me. -Returns a code explaining the reason(s) for rewriting. The exact -meaning of the codes

Re: Documentation improvement patch

2024-09-10 Thread Daniel Gustafsson
> On 10 Sep 2024, at 13:46, Oleg Sibiryakov wrote: > 1. Since we do not want to use here, I suggest we hyphenate it as > "built-in". What's your take on it? I think that's the right choice given the hyphenation used in the rest of the docs. There are a few more places on that same page which

Re: Documentation improvement patch

2024-09-10 Thread Oleg Sibiryakov
Thank you for your feedback. 1. Since we do not want to use here, I suggest we hyphenate it as "built-in". What's your take on it? 2. Leaving not-null is fine. -- Oleg Sibiryakov On 06.09.2024 16:20, Daniel Gustafsson wrote: On 5 Sep 2024, at 11:33, Oleg Sibiryakov wrote: Dear all, I have