Re: UNION does not append

2025-10-17 Thread David G. Johnston
On Tuesday, October 7, 2025, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/18/queries-union.html > Description: > > I'm very confused about this statement in the documentation of UNION: > "UNION > effect

Can not close psql

2025-10-17 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/18/app-psql.html Description: Hello. I was connected to database via `psql` then I rebooted DB. I was not able to disconnect from terminal after that. Only whole window close helped. ``` use

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Thu, Oct 16, 2025 at 10:11 PM David G. Johnston wrote: > The spaces added to the end of a bpchar manually can and are considered > “padding” - or “present but lack semantic/value significance”. The reason > they are not padding for varchar is that such spaces are considered part of > the st

Little Typo on Presskit 18

2025-10-17 Thread William Sescu (Suva)
Dear PostgreSQL Docs List I think, I found a little typo in the Presskit 18 docs. https://www.postgresql.org/about/press/presskit18/en/ It says: PostgreSQL 18 comes with HTML documentation HTML documentation as well as man pages, and you can also browse the documentation online in both HTML

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Tom Lane
Jeff Davis writes: > Please take a look at the attached patch. If you'd like your name > included in the commit, please send it as you'd like it to appear. I don't understand why any of these variants are better than the original wording "blank-padded". That has the non-negligible advantage of c

Re: DDL Partitionion Inheritance -- improved trigger function

2025-10-17 Thread David Rowley
On Wed, 24 Sept 2025 at 04:25, Kirk Parker wrote: > I'm a big fan of maintenance-free functions. What would you think about > adding the following as an alternative trigger function, or as a replacement > for the current function, to > https://www.postgresql.org/docs/current/ddl-partitioning.ht

Re: Little Typo on Presskit 18

2025-10-17 Thread Daniel Gustafsson
> On 6 Oct 2025, at 11:05, William Sescu (Suva) wrote: > > Dear PostgreSQL Docs List > I think, I found a little typo in the Presskit 18 docs. > https://www.postgresql.org/about/press/presskit18/en/ > It says: > PostgreSQL 18 comes with HTML documentation HTML documentation as well as man > p

Re: Documentation improvement patch

2025-10-17 Thread Daniel Gustafsson
> On 10 Sep 2025, at 09:54, Oleg wrote: > > Dear all, > I have prepared a patch containing some minor inconsistencies in the > documentation. Please, take a look. > I will be looking forward to your feedback. Thanks for the patch, while most of these are obvious improvements I have a few commen

Use uppercase keywords in foreign key tutorial

2025-10-17 Thread Erik Wienhold
While browsing the docs I saw that the foreign key tutorial [1] uses some lowercase keywords which are inconsistent with the rest of the docs. The attached patch fixes that. Should be pushed to all stable branches. [1] https://www.postgresql.org/docs/current/tutorial-fk.html -- Erik Wienhold >

Re: Little Typo on Presskit 18

2025-10-17 Thread Álvaro Herrera
On 2025-Oct-06, Daniel Gustafsson wrote: > Thanks for the report, and a very nice catch it is, turns out this duplication > has existed in every presskit since Postgres v11.. > > I've removed it from the v18 presskit but I opted to leave it in the older > kits > as they exist as historic records

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
> I don't understand why any of these variants are better than the > original wording "blank-padded". That has the non-negligible > advantage of corresponding to the type name, and furthermore > appears in many other places in our docs and source code. The wording for BPCHAR (not to be confused w

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Laurenz Albe
On Fri, 2025-10-17 at 18:18 +0400, Sergei Katkovsky wrote: > On Fri, Oct 17, 2025 at 4:49 PM Laurenz Albe wrote: > > > "bpchar" and "varchar", when used without type modifier, are actually > > identical: > > > > SELECT octet_length(BPCHAR 'x   '), > >     octet_length(VARCHAR 'x   '), > >   

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Jeff Davis
On Thu, 2025-10-16 at 08:36 -0400, David G. Johnston wrote: > A given value has a finite length and there is just no restriction on > what that length is.  All trailing spaces in the input are considered > padding for purposes of comparison i.e., manually padding is added by > the user as opposed t

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread David G. Johnston
On Thursday, October 16, 2025, Sergei Katkovsky wrote: > On Thu, Oct 16, 2025 at 10:11 PM David G. Johnston > wrote: > > > The spaces added to the end of a bpchar manually can and are considered > “padding” - or “present but lack semantic/value significance”. The reason > they are not padding fo

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Jeff Davis
On Wed, 2025-10-15 at 15:29 -0400, Tom Lane wrote: > Jeff Davis writes: > > Please take a look at the attached patch. If you'd like your name > > included in the commit, please send it as you'd like it to appear. > > I don't understand why any of these variants are better than the > original word

UNION does not append

2025-10-17 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/18/queries-union.html Description: I'm very confused about this statement in the documentation of UNION: "UNION effectively appends the result of query2 to the result of query1". Because, if

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread David G. Johnston
On Fri, Oct 17, 2025, 03:38 Sergei Katkovsky wrote: > Perhaps a better term would be > "trailing-blanks-insignificant", with or without hyphens. > "Insignificant trailing blanks." David J.

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Fri, Oct 17, 2025 at 4:49 PM Laurenz Albe wrote: > "bpchar" and "varchar", when used without type modifier, are actually > identical: > > SELECT octet_length(BPCHAR 'x '), >octet_length(VARCHAR 'x '), >octet_length(TEXT 'x '); > > octet_length │ octet_length │ octet_leng

doc: Fix missing closing parentheses in monitoring.sgml

2025-10-17 Thread Shinya Kato
Hi, Attached is a doc-only fix that adds a missing closing parenthesis in monitoring.sgml (pg_stat_progress_analyze: delay_time). -- Best regards, Shinya Kato NTT OSS Center v1-0001-doc-Fix-missing-closing-parentheses-in-monitoring.patch Description: Binary data

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread David G. Johnston
On Thursday, October 16, 2025, Jeff Davis wrote: > On Thu, 2025-10-16 at 08:36 -0400, David G. Johnston wrote: > > A given value has a finite length and there is just no restriction on > > what that length is. All trailing spaces in the input are considered > > padding for purposes of comparison

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Fri, Oct 17, 2025 at 5:46 PM David G. Johnston wrote: > "Insignificant trailing blanks." OK, looks good to me too. With best regards, Sergei Katkovskii

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread David G. Johnston
On Friday, October 17, 2025, Laurenz Albe wrote: > > I suggest the following simplification: > > +text, varchar, > bpchar > > Calling bpchar an alias of text/varchar does not improve matters. Sure, the type itself doesn’t actually care about trailing spaces, but in practice operations on

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Laurenz Albe
On Wed, 2025-10-15 at 15:29 -0400, Tom Lane wrote: > Jeff Davis writes: > > Please take a look at the attached patch. If you'd like your name > > included in the commit, please send it as you'd like it to appear. > > I don't understand why any of these variants are better than the > original word

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
Hello, > I think "blank-insignificant" is slightly better than "blank-ignoring". Yes, I agree. And there is also "blank-agnostic" if you prefer fancy expressions :) > Please take a look at the attached patch. If you'd like your name > included in the commit, please send it as you'd like it to

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Fri, Oct 17, 2025 at 1:08 AM David G. Johnston wrote: > > > I’m just trying to phrase the documentation for bpchar so that the “bp”, > which stands for “blank-padded”, is justified. That's what I thought. Yes, unfortunately, bp stands for “blank-padded”, but this name is wrong and misleading.