Re: Ambiguous description on new columns

2024-05-31 Thread Peter Smith
On Wed, May 29, 2024 at 8:04 PM vignesh C wrote: > > On Wed, 22 May 2024 at 14:26, Peter Smith wrote: > > > > On Tue, May 21, 2024 at 8:40 PM PG Doc comments form > > wrote: > > > > > > The following documentation comment has been logged on t

Re: Ambiguous description on new columns

2024-05-22 Thread Peter Smith
3:19.098 AEST [16226] ERROR: logical replication target relation "public.t" is missing replicated column: "d" I think the following small change will remove any ambiguity: BEFORE If no column list is specified, any columns added later are automatically replicated. SUGGES

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
On Wed, May 22, 2024 at 1:22 PM David G. Johnston wrote: > > On Tue, May 21, 2024 at 7:48 PM Peter Smith wrote: >> >> >> I think the following small change will remove any ambiguity: >> >> BEFORE >> If no column list is specified, any columns a

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
3:19.098 AEST [16226] ERROR: logical replication target relation "public.t" is missing replicated column: "d" I think the following small change will remove any ambiguity: BEFORE If no column list is specified, any columns added later are automatically replicated. SUGGES

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-07-27 Thread Peter Smith
It seems this was pushed already [1]. Sorry for the false alarm. -- [1] https://github.com/postgres/postgres/commit/f5c446e3367527f9db1506d7c38d2f56e20950b6 Kind Regards, Peter Smith. Fujitsu Australia.

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-07-26 Thread Peter Smith
I created patches for this over a month ago, but then the thread went quiet. Is there something more needed, or was it just accidentally overlooked? Should this be added to the commitfest? -- Kind Regards, Peter Smith. Fujitsu Australia.

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-06-20 Thread Peter Smith
com [2] https://www.postgresql.org/message-id/288747bd-911b-4370-8db2-6ecbb096037e%40app.fastmail.com [3] https://www.postgresql.org/docs/devel/runtime-config-client.html Kind Regards, Peter Smith. Fujitsu Australia v2-0001-doc-Clarify-behavior-of-triggers-rules-in-a-logical-subscriber-REL_13.patch Des

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-08 Thread Peter Smith
On Thu, Aug 4, 2022 at 1:04 PM Amit Kapila wrote: > > On Wed, Aug 3, 2022 at 10:56 AM Peter Smith wrote: > > > > PSA a patch to modify the descriptions as suggested by Amit. > > > > * > > - The end LSN of the commit prepared transaction. > +

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-03 Thread Peter Smith
The end LSN of the prepare transaction. > > > Is it a typo of "prepared transaction"? > > I think in this case it should be a "prepared transaction". > > > Thanks for the report and Thanks Michael for including me. I am just > redirecting it to -hackers s