On Wed, Jul 24, 2024 at 9:02 AM Zhijie Hou (Fujitsu)
wrote:
>
> Thanks for the patch.
>
> Here is one comment:
>
> The second query has a condition 'WHERE slot_name IS NOT NULL', but I
> think it belongs to the first query. Because the slot_name of second query
> is built by CONCAT() which means i
On Tue, Jul 23, 2024 at 5:10 PM Amit Kapila wrote:
>
> One minor comment:
> - if the table copy is finished (See linkend="catalog-pg-subscription-rel"/>).
> + On the subscriber node, use the following SQL to identify which main
> + slots should be synced to the standby that we plan to
On Tue, Jul 23, 2024 at 8:14 AM Zhijie Hou (Fujitsu)
wrote:
>
> I also agree that separating the 2 queries makes sense.
Please find the patch with the suggested change.
thanks
Shveta
v2-0001-Correction-in-doc-of-failover-ready-steps.patch
Description: Binary data
On Mon, Jul 22, 2024 at 10:46 AM shveta malik wrote:
>
> Hi,
>
> We have a query in failover-ready doc referring to
> pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives
> results only when connected to the database having the
> subscription(s). If we run t
Hi,
We have a query in failover-ready doc referring to
pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives
results only when connected to the database having the
subscription(s). If we run the concerned query on any other database,
it will give incomplete results i.e. it will gi
On Fri, Jul 19, 2024 at 10:43 AM Zhijie Hou (Fujitsu)
wrote:
>
> Hi,
>
> The documentation incorrectly stated that users cannot alter subscription's
> failover option when two-phase commit is enabled.
>
> When writing this doc, I only wanted to mention we cannot execute ALTER SUB
> SET
> (failove
