Re: CREATE ROLE inheritance details

2024-04-13 Thread Noah Misch
On Wed, Apr 03, 2024 at 06:11:47PM -0700, David G. Johnston wrote: > On Sat, Mar 30, 2024 at 11:16 PM Noah Misch wrote: > > On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote: > > > + The membership grants created by the > > > + IN ROLE, ROLE, and > > ADMIN > > > + clauses hav

Re: CREATE ROLE inheritance details

2024-04-03 Thread David G. Johnston
On Sat, Mar 30, 2024 at 11:16 PM Noah Misch wrote: > On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote: > > + The membership grants created by the > > + IN ROLE, ROLE, and > ADMIN > > + clauses have the role executing this command as the grantee. > > This should be s/grantee

Re: CREATE ROLE inheritance details

2024-03-30 Thread Noah Misch
On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote: > + The membership grants created by the > + IN ROLE, ROLE, and > ADMIN > + clauses have the role executing this command as the grantee. This should be s/grantee/grantor/, right? > + If unspecified when create a new role

Re: CREATE ROLE inheritance details

2024-02-01 Thread Bruce Momjian
On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote: > Almost there I think.  The comment regarding seeing GRANT really applies to IN > ROLE, ROLE, and ADMIN.  Repeating it seemed a poor choice and upon thinking > further it really makes sense to consider how this command and GRANT wo

Re: CREATE ROLE inheritance details

2024-01-30 Thread David G. Johnston
Almost there I think. The comment regarding seeing GRANT really applies to IN ROLE, ROLE, and ADMIN. Repeating it seemed a poor choice and upon thinking further it really makes sense to consider how this command and GRANT work together part of the description of create role. So I moved that comm

Re: CREATE ROLE inheritance details

2024-01-29 Thread Bruce Momjian
On Sun, Jan 28, 2024 at 10:11:18AM -0700, David G. Johnston wrote: > On Fri, Jan 26, 2024 at 5:18 PM Bruce Momjian wrote: >   > +        Role membership with the inherit attribute can automatically use > +        whatever database privileges have been granted to all roles it > +        is directly

Re: CREATE ROLE inheritance details

2024-01-28 Thread David G. Johnston
On Fri, Jan 26, 2024 at 5:18 PM Bruce Momjian wrote: > > Just a reminder, this is for PG 16 and master. > > +Role membership with the inherit attribute can automatically use +whatever database privileges have been granted to all roles it +is directly or indirectly a memb

Re: CREATE ROLE inheritance details

2024-01-26 Thread Bruce Momjian
On Wed, Jan 17, 2024 at 02:32:47PM -0700, David G. Johnston wrote: > I had a go at this. > > I went with a more "bullet item" approach with my wording for INHERIT/ > NOINHERIT. I tried to address that. > The entire paragraph regarding how the INHERIT "option" works, as opposed to > the attribute

Re: CREATE ROLE inheritance details

2024-01-17 Thread David G. Johnston
On Wed, Jan 17, 2024 at 9:38 AM Bruce Momjian wrote: > On Wed, Jan 17, 2024 at 09:28:38AM +0100, Laurenz Albe wrote: > > On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > > > I am unhappy with the documentation adjustments made to CREATE ROLE in > > > Postgres 16 by this commit: > > > > >

Re: CREATE ROLE inheritance details

2024-01-17 Thread Bruce Momjian
On Wed, Jan 17, 2024 at 09:28:38AM +0100, Laurenz Albe wrote: > On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > > I am unhappy with the documentation adjustments made to CREATE ROLE in > > Postgres 16 by this commit: > > > > commit e3ce2de09d > > > > I have attached a patch to re-ad

Re: CREATE ROLE inheritance details

2024-01-17 Thread Laurenz Albe
On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > I am unhappy with the documentation adjustments made to CREATE ROLE in > Postgres 16 by this commit: > > commit e3ce2de09d > > I have attached a patch to re-add this information, and clarify it. I > would like to apply this to PG 16

CREATE ROLE inheritance details

2024-01-16 Thread Bruce Momjian
I am unhappy with the documentation adjustments made to CREATE ROLE in Postgres 16 by this commit: commit e3ce2de09d Author: Robert Haas Date: Thu Aug 25 10:06:02 2022 -0400 Allow grant-level control of role inheritance behavior.