Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Peter Geoghegan
On Fri, Feb 14, 2020 at 6:09 PM Tom Lane wrote: > > Language updates attached...mostly kept Tom's suggestions. > > Typo (optoin), otherwise LGTM. Great. Pushed with that tweak. -- Peter Geoghegan

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Tom Lane
"Jonathan S. Katz" writes: > On 2/14/20 8:56 PM, Peter Geoghegan wrote: >> But everything else looks good, right? >> I would like to commit this patch shortly. > Language updates attached...mostly kept Tom's suggestions. Typo (optoin), otherwise LGTM. regards, tom lane

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Jonathan S. Katz
On 2/14/20 8:56 PM, Peter Geoghegan wrote: > On Fri, Feb 14, 2020 at 5:51 PM Tom Lane wrote: >> Hm, I wouldn't go into that much detail; it'd likely soon be out of >> date anyway. I had in mind something more like "If the STYLE=website >> option is used, the generated HTML files will include refe

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Peter Geoghegan
On Fri, Feb 14, 2020 at 5:51 PM Tom Lane wrote: > Hm, I wouldn't go into that much detail; it'd likely soon be out of > date anyway. I had in mind something more like "If the STYLE=website > option is used, the generated HTML files will include references to > stylesheets hosted at www.postgresql

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Tom Lane
"Jonathan S. Katz" writes: > A potential solution is that we drop the use of "monospace" in relying > on the OS default and just pick a font. I would say that this is outside > the scope of the patch that's being proposed, but certainly something to > look into on the pgweb side given we're creati

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Jonathan S. Katz
On 2/14/20 6:06 PM, Tom Lane wrote: > "Jonathan S. Katz" writes: >> To load the webfont, the "main.css" file uses a CSS "@import" >> instruction, which has a limitation that it can only be used as the top >> of the file. As main.css is not the first file in the "docs.csS" >> sandwich, it does not

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Jonathan S. Katz
On 2/12/20 8:15 AM, Jonathan S. Katz wrote: > On 2/11/20 10:56 PM, Jonathan S. Katz wrote: >> On 2/11/20 3:49 PM, Jonathan S. Katz wrote: >>> On 2/11/20 3:41 PM, Peter Geoghegan wrote: On Tue, Feb 11, 2020 at 11:40 AM Jonathan S. Katz wrote: > Anyway, attached is a first attempt at

Re: Duplicating website's formatting in local doc builds

2020-02-12 Thread Jonathan S. Katz
On 2/11/20 10:56 PM, Jonathan S. Katz wrote: > On 2/11/20 3:49 PM, Jonathan S. Katz wrote: >> On 2/11/20 3:41 PM, Peter Geoghegan wrote: >>> On Tue, Feb 11, 2020 at 11:40 AM Jonathan S. Katz >>> wrote: Anyway, attached is a first attempt at a patch. I tried a few different variations bu

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Jonathan S. Katz
On 2/11/20 3:49 PM, Jonathan S. Katz wrote: > On 2/11/20 3:41 PM, Peter Geoghegan wrote: >> On Tue, Feb 11, 2020 at 11:40 AM Jonathan S. Katz >> wrote: >>> Anyway, attached is a first attempt at a patch. I tried a few different >>> variations but in my quick review of it, I could not figure out h

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Jonathan S. Katz
On 2/11/20 3:41 PM, Peter Geoghegan wrote: > On Tue, Feb 11, 2020 at 11:40 AM Jonathan S. Katz > wrote: >> Anyway, attached is a first attempt at a patch. I tried a few different >> variations but in my quick review of it, I could not figure out how to >> make a XSLT respect having multiple style

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Peter Geoghegan
On Tue, Feb 11, 2020 at 11:40 AM Jonathan S. Katz wrote: > Anyway, attached is a first attempt at a patch. I tried a few different > variations but in my quick review of it, I could not figure out how to > make a XSLT respect having multiple stylesheets (likely due to my lack > of familiarity with

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Jonathan S. Katz
On 2/11/20 2:32 PM, Tom Lane wrote: > "Jonathan S. Katz" writes: >> On 2/11/20 1:37 PM, Tom Lane wrote: >>> I also wonder why duplicating the website's style isn't the default. >>> Doesn't seem like having authors optimize for some other style is >>> what we really want. > >> Oh, and specifically

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Peter Geoghegan
On Tue, Feb 11, 2020 at 10:37 AM Tom Lane wrote: > I also wonder why duplicating the website's style isn't the default. > Doesn't seem like having authors optimize for some other style is > what we really want. FWIW, I've often wondered about it myself. -- Peter Geoghegan

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Tom Lane
"Jonathan S. Katz" writes: > On 2/11/20 1:37 PM, Tom Lane wrote: >> I also wonder why duplicating the website's style isn't the default. >> Doesn't seem like having authors optimize for some other style is >> what we really want. > Oh, and specifically for this, my guess is because it requires on

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Jonathan S. Katz
On 2/11/20 1:37 PM, Tom Lane wrote: > I also wonder why duplicating the website's style isn't the default. > Doesn't seem like having authors optimize for some other style is > what we really want. Oh, and specifically for this, my guess is because it requires one to make a call over a network to

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Jonathan S. Katz
On 2/11/20 1:37 PM, Tom Lane wrote: > I'm wondering how to do $SUBJECT. The fine manual suggests > > make STYLE=website html > > but what I'm getting here with that is not a very close approximation > of what I see at postgresql.org. It's closer than the default, > but it's not the same f

Duplicating website's formatting in local doc builds

2020-02-11 Thread Tom Lane
I'm wondering how to do $SUBJECT. The fine manual suggests make STYLE=website html but what I'm getting here with that is not a very close approximation of what I see at postgresql.org. It's closer than the default, but it's not the same font, margins, etc. I also wonder why duplicatin