Re: Missing File weather.txt

2025-07-12 Thread Daniel Gustafsson
> On 12 Jul 2025, at 18:41, Tom Lane wrote: > > Daniel Gustafsson writes: >> Or perhaps ”values are separated by a tab character”? > > WFM Thanks, I'll get this pushed once the freeze is over on REL_18_STABLE. -- Daniel Gustafsson

Re: Missing File weather.txt

2025-07-12 Thread Tom Lane
Daniel Gustafsson writes: > Or perhaps ”values are separated by a tab character”? WFM regards, tom lane

Re: Missing File weather.txt

2025-07-12 Thread Daniel Gustafsson
> On 12 Jul 2025, at 18:23, Tom Lane wrote: > > Fujii Masao writes: >>> On 2025/07/12 7:18, Daniel Gustafsson wrote: >>> It should, fixed in v3. > >> LGTM. Thanks! > > I'm okay with this too. I find myself niggling a bit at the > parenthetical remark "the white space on each line is actually

Re: Missing File weather.txt

2025-07-12 Thread Tom Lane
Fujii Masao writes: > On 2025/07/12 7:18, Daniel Gustafsson wrote: >> It should, fixed in v3. > LGTM. Thanks! I'm okay with this too. I find myself niggling a bit at the parenthetical remark "the white space on each line is actually a tab character". There's several tabs on each line, so use o

Re: Missing File weather.txt

2025-07-11 Thread Fujii Masao
On 2025/07/12 7:18, Daniel Gustafsson wrote: On 11 Jul 2025, at 01:36, Fujii Masao wrote: Since the prcp column isn't specified, its value is NULL. So shouldn't the fourth field in the data line above be \N instead of 0.0? It should, fixed in v3. LGTM. Thanks! Regards, -- Fujii Masao

Re: Missing File weather.txt

2025-07-11 Thread Daniel Gustafsson
> On 11 Jul 2025, at 01:36, Fujii Masao wrote: > Since the prcp column isn't specified, its value is NULL. So shouldn't > the fourth field in the data line above be \N instead of 0.0? It should, fixed in v3. -- Daniel Gustafsson v3-0001-doc-Add-example-file-for-COPY.patch Description: Binary

Re: Missing File weather.txt

2025-07-10 Thread Fujii Masao
ects to be in the table. I'd include text along the lines of "The data inserted above could also be inserted from a file containing:". The attached v2 adds the missing line, and tweaks the text added to document the file. Thanks for updating the patch! LGTM. Just one small comme

Re: Missing File weather.txt

2025-07-10 Thread Daniel Gustafsson
27;t >> the sample input for COPY include all three, like this? > > Agreed, the example file should match what the tutorial expects to be > in the table. I'd include text along the lines of "The data inserted > above could also be inserted from a file containing:".

Re: Missing File weather.txt

2025-07-05 Thread Tom Lane
Fujii Masao writes: > On 2020/01/28 19:18, Daniel Gustafsson wrote: >> This is only mentioned as an example of another input method, with a link to >> the COPY page for more information. That being said, it's a good thing for a >> tutorial to be self-contained, and going from a basic tutorial to

Re: Missing File weather.txt

2025-07-05 Thread Fujii Masao
On 2020/01/28 19:18, Daniel Gustafsson wrote: On 28 Jan 2020, at 03:22, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/tutorial-populate.html Description: On this page https://www.postgresql.org/docs/

Re: Add missing references to database object statistics manipulation functions in documentation

2025-06-11 Thread Robert Treat
On Tue, Jun 10, 2025 at 11:50 PM Fujii Masao wrote: > On 2025/06/07 3:11, Robert Treat wrote: > > On Thu, May 22, 2025 at 7:17 AM Fujii Masao > > wrote: > >> I noticed that the documentation is missing references to the database > >> object statisti

Re: Add missing references to database object statistics manipulation functions in documentation

2025-06-10 Thread Fujii Masao
On 2025/06/07 3:11, Robert Treat wrote: On Thu, May 22, 2025 at 7:17 AM Fujii Masao wrote: I noticed that the documentation is missing references to the database object statistics manipulation functions such as pg_restore_relation_stats in a few relevant places. For instance, the MAINTAIN

Re: Add missing references to database object statistics manipulation functions in documentation

2025-06-06 Thread Robert Treat
On Thu, May 22, 2025 at 7:17 AM Fujii Masao wrote: > I noticed that the documentation is missing references to the database > object statistics manipulation functions such as pg_restore_relation_stats > in a few relevant places. For instance, the MAINTAIN privilege section > l

Add missing references to database object statistics manipulation functions in documentation

2025-05-22 Thread Fujii Masao
Hi, I noticed that the documentation is missing references to the database object statistics manipulation functions such as pg_restore_relation_stats in a few relevant places. For instance, the MAINTAIN privilege section lists allowed operations but doesn't mention these functions, even t

Re: Missing word

2025-05-15 Thread Paweł Szymczyk
What about sth like that: Normally the set of partitions established when initially defining the > table is not intended to remain static. It is common to want to remove > partitions holding old data and periodically add new partitions for new > data. One of the most important advantages of partit

Re: Missing word

2025-05-15 Thread Tom Lane
=?utf-8?Q?=C3=81lvaro?= Herrera writes: > On 2025-May-13, Tom Lane wrote: >>> "Another option that is often preferable is to remove the partition >>> from the partitioned table but retain access to it as a table in its own >>> right." >> AFAICS, it's correct as written. > Yeah, but maybe it woul

Re: Missing word

2025-05-15 Thread Álvaro Herrera
the partition > > from the partitioned table but retain access to it as a table in its own > > right." there is missing "not" word. Correct form of this sentence should > > be: Another option that is often preferable is to not remove the partition > > from the partitio

Re: Missing word

2025-05-13 Thread Paweł Szymczyk
IONING-DECLARATIVE-MAINTENANCE > , > > sentence "Another option that is often preferable is to remove the > partition > > from the partitioned table but retain access to it as a table in its own > > right." there is missing "not" word. Correct form of this sentenc

Missing word

2025-05-13 Thread PG Doc comments form
that is often preferable is to remove the partition from the partitioned table but retain access to it as a table in its own right." there is missing "not" word. Correct form of this sentence should be: Another option that is often preferable is to not remove the partition from the p

Re: Missing word

2025-05-13 Thread Tom Lane
to it as a table in its own > right." there is missing "not" word. Correct form of this sentence should > be: Another option that is often preferable is to not remove the partition > from the partitioned table but retain access to it as a table in its own

Re: Missing word

2025-05-13 Thread David G. Johnston
-partitioning. > html#DDL-PARTITIONING-DECLARATIVE-MAINTENANCE, > sentence "Another option that is often preferable is to remove the > partition > from the partitioned table but retain access to it as a table in its own > right." there is missing "not" word. Correc

Missing "each" in `NegotiateProtocolVersion` protocol message format description

2025-04-10 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/protocol-message-formats.html Description: Dear Postgres Team, There seems to be a missing "each" in documentation for the `NegotiateProtocolVersion` message format: *Then,

Re: [Appendix C. SQL Key Words] Missing keywords

2025-01-19 Thread Laurenz Albe
at least (but not limited to) > WHILE, LOOP, REPEAT, EXIT, FOREACH > Please review whether there is still any missing keywords in the list These are not SQL keywords, so they don't go in that list. They are PL/pgSQL commands or keywords. Perhaps we should have a list of such keywords in th

[Appendix C. SQL Key Words] Missing keywords

2025-01-19 Thread PG Doc comments form
) WHILE, LOOP, REPEAT, EXIT, FOREACH Please review whether there is still any missing keywords in the list

Re: missing command?

2024-10-16 Thread Daniel Gustafsson
> On 15 Oct 2024, at 00:57, PG Doc comments form wrote: > In this list of commands: > https://www.postgresql.org/docs/current/reference-client.html > Should this one be included? --> pg_ctl pg_ctl is a server application, it is included here: https://www.postgresql.org/docs/devel/reference-se

missing command?

2024-10-16 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/reference-client.html Description: Hi, In this list of commands: https://www.postgresql.org/docs/current/reference-client.html Should this one be included? --> pg_ctl Saludos. Jose

Re: Examples Missing

2024-08-27 Thread Daniel Gustafsson
> On 26 Aug 2024, at 22:16, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/app-pgdump.html > Description: > > Examples should be added for every option available for pg_dump. I was > looking for ex

Examples Missing

2024-08-27 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/app-pgdump.html Description: Examples should be added for every option available for pg_dump. I was looking for example for on-conflict-do-nothing, and rows-per-insert and what does nrows

Re: Missing information on '-X' in section 26.3.6.1.

2024-06-28 Thread David G. Johnston
On Fri, Feb 2, 2024 at 12:41 PM David G. Johnston < david.g.johns...@gmail.com> wrote: > > The attached patch moves this paragraph there. I distilled the paragraph > down to its essence, but am open to being a bit more wordy, and consider > more how this fits into the existing content of that pag

Re: Missing examples for hash partitioning

2024-05-05 Thread David Rowley
On Sun, 5 May 2024 at 19:27, David Rowley wrote: > There are examples of hash partitioning in [1]. Maybe we should add a > link so those can be more easily found. I see the link is already there, per: "See CREATE TABLE for more details on creating partitioned tables and partitions." David > [

Re: Missing examples for hash partitioning

2024-05-05 Thread David Rowley
On Sun, 5 May 2024 at 08:13, PG Doc comments form wrote: > Page: https://www.postgresql.org/docs/16/ddl-partitioning.html > Description: > > There is no example showing the syntax of Hash Partitioning in this section > of the documentation, it's missing. There are examples

Missing examples for hash partitioning

2024-05-04 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/ddl-partitioning.html Description: There is no example showing the syntax of Hash Partitioning in this section of the documentation, it's missing.

Re: Missing | ?

2024-02-19 Thread Tom Lane
Laurenz Albe writes: > On Mon, 2024-02-19 at 09:37 +, PG Doc comments form wrote: >> Page: https://www.postgresql.org/docs/16/sql-security-label.html >> FOREIGN TABLE object_name >> >> ...probably should have a following "|", I think? > Absolutely! Indeed. Will fix, thanks for report!

Re: Missing | ?

2024-02-19 Thread Laurenz Albe
On Mon, 2024-02-19 at 09:37 +, PG Doc comments form wrote: > Page: https://www.postgresql.org/docs/16/sql-security-label.html > > FOREIGN TABLE object_name > > ...probably should have a following "|", I think? Absolutely! Yours, Laurenz Albe

Missing | ?

2024-02-19 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/sql-security-label.html Description: Hi, FOREIGN TABLE object_name ...probably should have a following "|", I think? Cheers Tim

Re: Missing information on '-X' in section 26.3.6.1.

2024-02-02 Thread David G. Johnston
On Wed, Jan 24, 2024 at 2:19 AM Daniel Gustafsson wrote: > > On 23 Jan 2024, at 21:43, David G. Johnston > wrote: > > > > On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form < > nore...@postgresql.org > wrote: > > The following documentation comment has been logge

Re: Missing information on '-X' in section 26.3.6.1.

2024-01-24 Thread Daniel Gustafsson
> On 23 Jan 2024, at 21:43, David G. Johnston > wrote: > > On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form > wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/continuous-archiving.html

Re: Missing information on '-X' in section 26.3.6.1.

2024-01-23 Thread David G. Johnston
On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/continuous-archiving.html > Description: > > I noticed, that in section 26.3.6.1. it's not specified, what the -X > parame

Missing information on '-X' in section 26.3.6.1.

2024-01-23 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/continuous-archiving.html Description: Hi! I'm reading through the documentation and so far I have to say this is the best documentation I have ever encountered, thank you! I noticed, tha

Missing "CONSTRAINT" keyword in ADD CONSTRAINT form?

2023-12-04 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/sql-alterdomain.html Description: (apologies, I managed to send this too soon, just now, somehow) The example for ALTER DOMAIN shows: ALTER DOMAIN zipcode ADD CONSTRAINT zipchk CHECK (ch

Re: Missing "CONSTRAINT" keyword in ADD CONSTRAINT form?

2023-12-04 Thread David G. Johnston
On Monday, December 4, 2023, Tim Needham wrote: > Bah, scratch that, sorry again. It's because "CONSTRAINT" is implied by > the reference to CREATE DOMAIN, isn't it? > Yes, we require the reader to go to the create domain page to read the “domain_constraint” portion of the syntax. David J.

Re: Missing "CONSTRAINT" keyword in ADD CONSTRAINT form?

2023-12-04 Thread Tim Needham
Bah, scratch that, sorry again. It's because "CONSTRAINT" is implied by the reference to CREATE DOMAIN, isn't it? Sorry. On Mon, Dec 4, 2023 at 8:29 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/s

Re: Documentation of FOR ROLE clause of ALTER DEFAULT PRIVILEGES missing

2023-11-21 Thread Bruce Momjian
On Thu, Feb 22, 2018 at 07:50:19PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/10/static/sql-alterdefaultprivileges.html > Description: > > The documentation of ALTER DEFAULT PRIVILEGES state

Re: Missing documentation for FETCH FIRST in chapter 7.6

2023-11-17 Thread Bruce Momjian
On Wed, Jun 13, 2018 at 04:17:55PM -0300, Euler Taveira wrote: > 2018-05-16 10:22 GMT-03:00 PG Doc comments form : > > The documentation of the SELECT statement lists FETCH FIRST/OFFSET as an > > alternative to the proprietary LIMIT clause. > > > > https://www.postgresql.org/docs/current/static/sql

Re: Missing ;

2023-11-13 Thread Daniel Gustafsson
> On 10 Nov 2023, at 22:00, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/sql-select.html > Description: > > Hi, > > To be consistent, the "with" example should end in a ";". > > WITH t AS ( >

Missing ;

2023-11-13 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/sql-select.html Description: Hi, To be consistent, the "with" example should end in a ";". WITH t AS ( SELECT random() as x FROM generate_series(1, 3) ) SELECT * FROM t UNION ALL S

Re: Missing word? https://www.postgresql.org/docs/current/continuous-archiving.html#BACKUP-ARCHIVING-WAL

2023-10-30 Thread Daniel Westermann (DWE)
>>> "Another way to archive is to use a custom archive module as the >>> archive_library" >> >> shouldn't this read: >> "Another way to archive this is to use a custom archive module as the >> archive_library" >That would be worse than the original. What is "this"? >I'd suggest "Another way to

Re: Missing word? https://www.postgresql.org/docs/current/continuous-archiving.html#BACKUP-ARCHIVING-WAL

2023-10-30 Thread Laurenz Albe
On Mon, 2023-10-30 at 13:15 +, Daniel Westermann (DWE) wrote: > "Another way to archive is to use a custom archive module as the > archive_library" > > shouldn't this read: > "Another way to archive this is to use a custom archive module as the > archive_library" That would be worse than th

Missing word? https://www.postgresql.org/docs/current/continuous-archiving.html#BACKUP-ARCHIVING-WAL

2023-10-30 Thread Daniel Westermann (DWE)
Hi, "Another way to archive is to use a custom archive module as the archive_library" shouldn't this read: "Another way to archive this is to use a custom archive module as the archive_library" Regards Daniel

Re: Missing closing ]

2023-10-04 Thread Tom Lane
PG Doc comments form writes: > In the example session at > https://www.postgresql.org/docs/current/rangetypes.html#RANGETYPES-EXAMPLES > there are missing closing square bracket ] > Take a look below > CREATE TABLE reservation (room int, during tsrange); > INSERT INTO

Missing closing ]

2023-10-04 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/rangetypes.html Description: In the example session at https://www.postgresql.org/docs/current/rangetypes.html#RANGETYPES-EXAMPLES there are missing closing square bracket ] Take a look

Re: missing GRANTED BY explanations

2023-09-30 Thread David G. Johnston
On Saturday, September 30, 2023, PG Doc comments form < nore...@postgresql.org> wrote: > > > In the documentation for revoke command, there is no description for > GRANTED > BY clause. > > As the doc says read the grant page for more detailed information. Repeating everything here was deemed redund

Re: missing GRANTED BY explanations

2023-09-30 Thread David G. Johnston
On Sat, Sep 30, 2023 at 1:56 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/sql-revoke.html > Description: > > Hi, > In the documentation for revoke command, there is no description for > GRANTED >

missing GRANTED BY explanations

2023-09-30 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/sql-revoke.html Description: Hi, In the documentation for revoke command, there is no description for GRANTED BY clause. please explain that what will happen when using this clause in revo

Re: Add missing meson arguments in docs

2023-02-28 Thread Michael Paquier
On Wed, Feb 22, 2023 at 09:24:37AM +0100, Peter Eisentraut wrote: > Yeah, this is just in the long tail of things to work through. I am going through that, and found out what can be done to do coverage reports. I will post a patch separately on -hackers. -- Michael signature.asc Description: PG

Re: Add missing meson arguments in docs

2023-02-22 Thread Peter Eisentraut
On 22.02.23 02:57, Michael Paquier wrote: -Db_coverage is part of the core options of meson because it is not listed in meson_options.txt, no? Documenting the switch is fine, but it seems like we lack contents here. The paragraph describing -Db_coverage links to regress-coverage, still this onl

Re: Add missing meson arguments in docs

2023-02-21 Thread Michael Paquier
On Tue, Feb 21, 2023 at 10:40:12AM +0100, Jelte Fennema wrote: > The -Dcassert and -Db_coverage of the meson build didn't show in the > docs that they needed to be passed true or false. All other options > specified the arguments they expected. This patch fixes that. Indeed, values have to be spec

Re: February 9th, 2023 Release links to a missing page

2023-02-21 Thread Jonathan S. Katz
On 2/20/23 8:57 PM, Kirk Wolak wrote: On Sun, Feb 19, 2023 at 4:55 PM Jonathan S. Katz Well, that gives me an idea. In the release announcement, we could put a line that says "You can send any corrections or suggestions to the public pgsql-...@lists.postgresql.org

Add missing meson arguments in docs

2023-02-21 Thread Jelte Fennema
The -Dcassert and -Db_coverage of the meson build didn't show in the docs that they needed to be passed true or false. All other options specified the arguments they expected. This patch fixes that. 0001-Add-missing-meson-arguments-in-docs.patch Description: Binary data

Re: February 9th, 2023 Release links to a missing page

2023-02-20 Thread Kirk Wolak
On Sun, Feb 19, 2023 at 4:55 PM Jonathan S. Katz wrote: > On 2/19/23 3:55 PM, Kirk Wolak wrote: > > On Wed, Feb 15, 2023 at 2:05 PM Jonathan S. Katz > > wrote: > > > > The release announcements go through the news system, which does not > > have a feedback co

Re: February 9th, 2023 Release links to a missing page

2023-02-19 Thread Jonathan S. Katz
On 2/19/23 3:55 PM, Kirk Wolak wrote: On Wed, Feb 15, 2023 at 2:05 PM Jonathan S. Katz > wrote: The release announcements go through the news system, which does not have a feedback collection mechanism as anyone can post news. Emailing pgsql-docs, or even

Re: February 9th, 2023 Release links to a missing page

2023-02-19 Thread Kirk Wolak
On Wed, Feb 15, 2023 at 2:05 PM Jonathan S. Katz wrote: > On 2/15/23 1:59 PM, Kirk Wolak wrote: > > It looks like a simple bad reference name: > > > > On this line: > > > > * Fix the |psql| > > commands > > |\sf| and |\ef| to handl

Re: February 9th, 2023 Release links to a missing page

2023-02-15 Thread Jonathan S. Katz
On 2/15/23 1:59 PM, Kirk Wolak wrote: It looks like a simple bad reference name: On this line: * Fix the |psql|  commands |\sf| and |\ef| to handle SQL-language functions that have SQL-standard function bodies

February 9th, 2023 Release links to a missing page

2023-02-15 Thread Kirk Wolak
It looks like a simple bad reference name: On this line: - Fix the psql commands \sf and \ef to handle SQL-language functions that have SQL-standard function bodies

Fwd: Views "missing" from information_schema.view_table_usage

2022-12-05 Thread Jonathan Lemig
ubject: Re: Views "missing" from information_schema.view_table_usage To: Erik Wienhold Cc: Hi Erik - sorry I missed your reply when I replied to David's. That is indeed the issue. The object that the view is querying is a materialized view. Thanks for the link. Jon On Fri, De

Logical replication missing information

2022-11-17 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/15/logical-replication-row-filter.html Description: There are several things missing here and some of them I found to be highly important: 1. How can I find why a logical replication failed

Re: Missing documentation

2022-11-03 Thread Stefan Badenhorst
Thanks! This helps. On Thu, Nov 3, 2022, 18:40 Alvaro Herrera wrote: > On 2022-Nov-03, Tom Lane wrote: > > > Stefan Badenhorst writes: > > > I am using a prometheus exporter: > > > https://github.com/prometheus-community/postgres_exporter/ > > > > Hmm, well, maybe prometheus is doing something

Re: Missing documentation

2022-11-03 Thread Alvaro Herrera
On 2022-Nov-03, Tom Lane wrote: > Stefan Badenhorst writes: > > I am using a prometheus exporter: > > https://github.com/prometheus-community/postgres_exporter/ > > Hmm, well, maybe prometheus is doing something with that part of the URL. > There's no such behavior in Postgres itself, though. Y

Re: Missing documentation

2022-11-03 Thread Stefan Badenhorst
I am using a prometheus exporter: https://github.com/prometheus-community/postgres_exporter/ Turning JIT off definitely made a big difference to all our environments. When using JIT it causes OOM on postgres server after a few days. Adding jit=off resolved the issue. I have tested this now for seve

Re: Missing documentation

2022-11-03 Thread Tom Lane
Stefan Badenhorst writes: > I am using a prometheus exporter: > https://github.com/prometheus-community/postgres_exporter/ Hmm, well, maybe prometheus is doing something with that part of the URL. There's no such behavior in Postgres itself, though. regards, tom lane

Re: Missing documentation

2022-11-03 Thread Tom Lane
Stefan Badenhorst writes: > This is working: > postgresql://USERNAME:PASSWORD@server > :5432/the_database?sslmode=disable&jit=off Again, not for me: $ psql 'postgresql://postgres@localhost:5432/mydb?sslmode=disable&jit=off' psql: error: invalid URI query parameter: "jit" I suspect something in

Re: Missing documentation

2022-11-03 Thread Stefan Badenhorst
This is working: postgresql://USERNAME:PASSWORD@server :5432/the_database?sslmode=disable&jit=off Maybe I was looking at the wrong documentation page? On Thu, 3 Nov 2022 at 14:58, Tom Lane wrote: > PG Doc comments form writes: > > On this page: > > > https://www.postgresql.org/docs/current/libp

Re: Missing documentation

2022-11-03 Thread Tom Lane
PG Doc comments form writes: > On this page: > https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS > There is a list of keywords that can be specified as part of the connection > string. > Specifying `jit=off` or `jit=on` is functional in practice, but `jit` is > not i

Missing documentation

2022-11-03 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/15/libpq-connect.html Description: On this page: https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS There is a list of keywords that can be specified as part of t

Re: [PATCH] doc/queries.sgml: add missing comma

2022-09-02 Thread Bruce Momjian
On Tue, Aug 30, 2022 at 02:18:42PM -0400, Bruce Momjian wrote: > On Wed, Aug 24, 2022 at 07:58:04PM +0200, Peter Eisentraut wrote: > > On 18.08.22 20:10, Bruce Momjian wrote: > > > > Thus: > > > > Strictly speaking, this process is iteration, but > > > > RECURSIVE > > > > is the terminology chosen

Re: [PATCH] doc/queries.sgml: add missing comma

2022-08-30 Thread Bruce Momjian
On Wed, Aug 24, 2022 at 07:58:04PM +0200, Peter Eisentraut wrote: > On 18.08.22 20:10, Bruce Momjian wrote: > > > Thus: > > > Strictly speaking, this process is iteration, but > > > RECURSIVE > > > is the terminology chosen by the SQL standards committee." > > > > > > Because the above sounds jus

Re: Section 40.1 Overview of Event Trigger Behavior, and Table 40.1 missing needed details

2022-08-28 Thread Alvaro Herrera
On 2022-Aug-27, PG Doc comments form wrote: > Section 40.1. Overview of Event Trigger Behavior says: > "The table_rewrite event occurs just before a table is rewritten by some > actions of the commands ALTER TABLE and ALTER TYPE." > Issue: Neither the section nor the table describe which actions o

Section 40.1 Overview of Event Trigger Behavior, and Table 40.1 missing needed details

2022-08-28 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/event-trigger-matrix.html Description: RE: https://www.postgresql.org/docs/current/event-trigger-matrix.html Section 40.1. Overview of Event Trigger Behavior says: "The table_rewrite even

Re: [PATCH] doc/queries.sgml: add missing comma

2022-08-24 Thread Peter Eisentraut
On 18.08.22 20:10, Bruce Momjian wrote: Thus: Strictly speaking, this process is iteration, but RECURSIVE is the terminology chosen by the SQL standards committee." Because the above sounds just fine, I'd argue that if one does leave "not recursion" it should be set off by a comma. I went with

Re: [PATCH] doc/queries.sgml: add missing comma

2022-08-18 Thread Bruce Momjian
On Tue, Oct 19, 2021 at 06:41:54PM -0700, David G. Johnston wrote: > On Tue, Oct 19, 2021 at 2:33 PM Tom Lane wrote: > > Drew DeVault writes: > > Minor grammatical fix. > > Hmm, I'm not sure that reads any better than before. > > >      > > -    Strictly speaking, this proc

Re: 52.88. pg_shmem_allocations, missing units

2022-08-15 Thread Daniel Gustafsson
> On 15 Aug 2022, at 04:23, Masahiko Sawada wrote: > > On Mon, Aug 15, 2022 at 3:56 AM Euler Taveira wrote: >> >> On Fri, Aug 12, 2022, at 5:43 PM, PG Doc comments form wrote: >> >> Could someone add the units of size & allocated_size on the documentation >> for pg_shmem_allocations? Currently

Re: 52.88. pg_shmem_allocations, missing units

2022-08-14 Thread Masahiko Sawada
On Mon, Aug 15, 2022 at 3:56 AM Euler Taveira wrote: > > On Fri, Aug 12, 2022, at 5:43 PM, PG Doc comments form wrote: > > Could someone add the units of size & allocated_size on the documentation > for pg_shmem_allocations? Currently there aren't any listed. > > According to ShmemIndexEnt struct

Re: 52.88. pg_shmem_allocations, missing units

2022-08-14 Thread Euler Taveira
On Fri, Aug 12, 2022, at 5:43 PM, PG Doc comments form wrote: > Could someone add the units of size & allocated_size on the documentation > for pg_shmem_allocations? Currently there aren't any listed. According to ShmemIndexEnt struct: /* this is a hash bucket in the shmem index table */ typedef

52.88. pg_shmem_allocations, missing units

2022-08-12 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/view-pg-shmem-allocations.html Description: Could someone add the units of size & allocated_size on the documentation for pg_shmem_allocations? Currently there aren't any listed. https:/

Re: "Getting Started" guide is missing a critical step?

2022-07-12 Thread David G. Johnston
On Tuesday, July 12, 2022, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/tutorial-createdb.html > Description: > > Hello, > > I'm new to postgres so following through the steps in "Chapter 1. Getting

"Getting Started" guide is missing a critical step?

2022-07-12 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/tutorial-createdb.html Description: Hello, I'm new to postgres so following through the steps in "Chapter 1. Getting Started". I was surprised to see that the chapter goes directly from

Re: Docs for string_to_array missing for Postgres 14

2022-07-12 Thread Tom Lane
PG Doc comments form writes: > At the bottom of the docs on "Array Functions and Operators" for Postgres 14 > (see https://www.postgresql.org/docs/14/functions-array.html) there is a > NOTE with the text "There are two differences in the behavior of > string_to_array from pre-9.1...". However I ca

Docs for string_to_array missing for Postgres 14

2022-07-12 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/functions-array.html Description: At the bottom of the docs on "Array Functions and Operators" for Postgres 14 (see https://www.postgresql.org/docs/14/functions-array.html) there is a NOTE

Re: Incorrect and missing docs for range_intersect_agg

2022-05-29 Thread Tom Lane
Shay Rojansky writes: > range_intersect_agg is documented to return anymultirange (on this > page[1]), but it actually returns a range. The form with anyrange input, yeah. > In addition, range_intersect_agg also accepts a multirange as its > parameter, but that's not documented on the same page.

Incorrect and missing docs for range_intersect_agg

2022-05-27 Thread Shay Rojansky
Hi all, range_intersect_agg is documented to return anymultirange (on this page[1]), but it actually returns a range. In addition, range_intersect_agg also accepts a multirange as its parameter, but that's not documented on the same page. Note that range_agg does *not* accept a multirange (possib

Re: role attributes are missing from this page

2022-04-13 Thread Keith Wanta
> SELECT "old" FROM pg_roles; > > Look closer. That column is "oid" not "old". > > > Issue #2: > > You do not have ALL role attributes documented on this page. Please add > and > > document the missing role attributes. > > https://www

Re: role attributes are missing from this page

2022-04-12 Thread Tom Lane
have ALL role attributes documented on this page. Please add and > document the missing role attributes. > https://www.postgresql.org/docs/current/role-attributes.html AFAICS this page is merely trying to document the role properties that can reasonably be considered to be kinds of privile

role attributes are missing from this page

2022-04-12 Thread PG Doc comments form
Issue #2: You do not have ALL role attributes documented on this page. Please add and document the missing role attributes. https://www.postgresql.org/docs/current/role-attributes.html This is a list of all role attributes: SELECT rolname,rolsuper,rolinherit,rolcreaterole,rolcreatedb,rolcan

Re: Missing example for SAVEPOINT using the same savepoint name

2022-04-12 Thread Sebastien Flaesch
Hello! The new sample code looks clearer I agree! Seb From: David G. Johnston Sent: Tuesday, April 12, 2022 4:41 PM To: Sebastien Flaesch ; Pg Docs Subject: Re: Missing example for SAVEPOINT using the same savepoint name EXTERNAL: Do not click links or open

Re: Missing example for SAVEPOINT using the same savepoint name

2022-04-12 Thread David G. Johnston
On Mon, Apr 11, 2022 at 9:43 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/sql-savepoint.html > Description: > > The "Compatibility" section deserves some code example to illustrate the > behavior

Missing example for SAVEPOINT using the same savepoint name

2022-04-11 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/sql-savepoint.html Description: The "Compatibility" section deserves some code example to illustrate the behavior when reusing the same savepoint name. Maybe this could help: CREATE TABL

Re: Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix

2022-03-08 Thread Michael Paquier
respectively "DROP PROCEDURE" and "DROP FUNCTION" tags). Thanks for the report. Indeed, the table is missing that ALTER ROUTINE would fire the events ddl_command_start and ddl_command_end. DROP ROUTINE fires on sql_drop, ddl_command_start and ddl_command_end. I have applied a pat

Re: Missing information about CREATE TRIGGER on temporary tables

2022-03-08 Thread Tom Lane
PG Doc comments form writes: > The reference page about CREATE TRIGGER should indicate if it's allowed to > create triggers on temp tables. > This seems to be the supported, but I was wondering what happens with the > trigger name when created on a temp table. The page already says The name

Re: Missing information about CREATE TRIGGER on temporary tables

2022-03-08 Thread David G. Johnston
On Tue, Mar 8, 2022 at 9:25 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/sql-createtrigger.html > Description: > > To be confirmed by the developer community... > The reference page about CREATE T

Missing information about CREATE TRIGGER on temporary tables

2022-03-08 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/sql-createtrigger.html Description: To be confirmed by the developer community... The reference page about CREATE TRIGGER should indicate if it's allowed to create triggers on temp tables.

  1   2   3   >