Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-25 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 02:02:20PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > OK, I didn't think there was enough desire to put it its own paragraph, > > but I like the idea of mentioning all of the trigger functions; patch > > attached. > > This one WFM. Patch applied to all supported

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Tom Lane
Bruce Momjian writes: > OK, I didn't think there was enough desire to put it its own paragraph, > but I like the idea of mentioning all of the trigger functions; patch > attached. This one WFM. regards, tom lane

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 01:39:45PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have developed the attached patch which is in a better direction. > > I still wish you wouldn't jam this topic into an only-marginally-related > sentence. In the case at hand, the point that the existing text

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Tom Lane
Bruce Momjian writes: > I have developed the attached patch which is in a better direction. I still wish you wouldn't jam this topic into an only-marginally-related sentence. In the case at hand, the point that the existing text is making is that a no-op update will fire triggers. Which is not

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 10:08:14AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have created the attached patch to mention > > suppress_redundant_updates_trigger() in this case. I don't think having > > an actual example is warranted. > > I don't like this patch, because in fact > suppre

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Tom Lane
Bruce Momjian writes: > I have created the attached patch to mention > suppress_redundant_updates_trigger() in this case. I don't think having > an actual example is warranted. I don't like this patch, because in fact suppress_redundant_updates_trigger is entirely unrelated to the stated purpose

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Fri, Jun 12, 2020 at 09:09:09AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/bug-reporting.html > Description: > > Hi > I was stumbling across the trigger function > ‘suppress_redundant_up

Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-12 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/bug-reporting.html Description: Hi I was stumbling across the trigger function ‘suppress_redundant_updates_trigger’ in https://www.postgresql.org/docs/devel/functions-trigger.html and I w