Re: Please provide examples of rows from

2020-10-05 Thread Bruce Momjian
On Thu, Sep 24, 2020 at 03:37:14PM -0400, Bruce Momjian wrote: > On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Yes, this is very helpful. I was afraid the JSON would overwhelm the > > > example, but this looks good. I wrote the attached doc patch which

Re: Please provide examples of rows from

2020-09-30 Thread Bruce Momjian
On Tue, Sep 29, 2020 at 08:53:51PM -0700, David G. Johnston wrote: > On Thu, Sep 24, 2020 at 12:37 PM Bruce Momjian wrote: > > On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Yes, this is very helpful.  I was afraid the JSON would overwhelm t

Re: Please provide examples of rows from

2020-09-29 Thread David G. Johnston
On Thu, Sep 24, 2020 at 12:37 PM Bruce Momjian wrote: > On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Yes, this is very helpful. I was afraid the JSON would overwhelm the > > > example, but this looks good. I wrote the attached doc patch which I > >

Re: Please provide examples of rows from

2020-09-24 Thread Bruce Momjian
On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Yes, this is very helpful. I was afraid the JSON would overwhelm the > > example, but this looks good. I wrote the attached doc patch which I > > think improves this. I plan to apply it to all supported versio

Re: Please provide examples of rows from

2020-09-24 Thread Tom Lane
Bruce Momjian writes: > Yes, this is very helpful. I was afraid the JSON would overwhelm the > example, but this looks good. I wrote the attached doc patch which I > think improves this. I plan to apply it to all supported versions. Couple thoughts: * Taking the initial ... out of the syntax

Re: Please provide examples of rows from

2020-09-24 Thread Bruce Momjian
On Sun, Sep 20, 2020 at 02:14:00PM -0400, Tom Lane wrote: > I wrote: > > You're right that the only suitable core function is going to be > > json[b]_to_recordset, but I don't see why you can't extend the > > existing example for that. Something like > > Meh, I was too hasty and pushed "send" wit

Re: Please provide examples of rows from

2020-09-24 Thread Bruce Momjian
On Mon, Sep 14, 2020 at 06:49:22PM -0700, David G. Johnston wrote: > On Thu, Sep 3, 2020 at 6:46 PM Bruce Momjian wrote: > The issue with adding an example is that it is hard to do something > simple and have it illustrate anything.  Does this help? > > That documents one of the two varia

Re: Please provide examples of rows from

2020-09-20 Thread Tom Lane
I wrote: > You're right that the only suitable core function is going to be > json[b]_to_recordset, but I don't see why you can't extend the > existing example for that. Something like Meh, I was too hasty and pushed "send" with a broken example. Better =# select * from rows from (json_to_reco

Re: Please provide examples of rows from

2020-09-20 Thread Tom Lane
I wrote: > Yeah, this error message needs some help. With a function having > multiple OUT parameters, the prorettype is indeed "record", but > the specific record type is implied by the OUT parameters so you > do not need to (and can't) specify it in the query. > The point of the AS feature is to

Re: Please provide examples of rows from

2020-09-20 Thread Tom Lane
Bruce Momjian writes: > but doing this to illustrate ROWS FROM is going to be complex. You're right that the only suitable core function is going to be json[b]_to_recordset, but I don't see why you can't extend the existing example for that. Something like # select * from rows from (json_to_re

Re: Please provide examples of rows from

2020-09-19 Thread Bruce Momjian
On Sat, Sep 19, 2020 at 08:49:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > test=> \df pg_get_keywords > >List > > of functions > >Schema | Name | Result data type | >

Re: Please provide examples of rows from

2020-09-19 Thread Tom Lane
Bruce Momjian writes: > test=> \df pg_get_keywords > List > of functions > Schema | Name | Result data type | > Argument data types

Re: Please provide examples of rows from

2020-09-19 Thread Bruce Momjian
On Mon, Sep 14, 2020 at 06:49:22PM -0700, David G. Johnston wrote: > That documents one of the two variants - and incorporating the column alias > feature seems worthwhile for the chosen example.  I do think this is worth > adding. > > The more complicated one is the second: > > ROWS FROM( ... fu

Re: Please provide examples of rows from

2020-09-14 Thread David G. Johnston
On Thu, Sep 3, 2020 at 6:46 PM Bruce Momjian wrote: > On Wed, Apr 8, 2020 at 09:50:44PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/queries-table-expressions.html > > Description: > >

Re: Please provide examples of rows from

2020-09-03 Thread Bruce Momjian
On Wed, Apr 8, 2020 at 09:50:44PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/queries-table-expressions.html > Description: > > The explanation of ROWS FROM is fairly terse and no examples a

Please provide examples of rows from

2020-04-09 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/queries-table-expressions.html Description: The explanation of ROWS FROM is fairly terse and no examples are given. As it is essentially impossible to usefully search for this phrase, it