Re: Correction in doc of failover ready steps

2024-07-23 Thread shveta malik
On Wed, Jul 24, 2024 at 9:02 AM Zhijie Hou (Fujitsu) wrote: > > Thanks for the patch. > > Here is one comment: > > The second query has a condition 'WHERE slot_name IS NOT NULL', but I > think it belongs to the first query. Because the slot_name of second query > is built by CONCAT() which means i

RE: Correction in doc of failover ready steps

2024-07-23 Thread Zhijie Hou (Fujitsu)
On Wednesday, July 24, 2024 10:56 AM shveta malik wrote: > > On Tue, Jul 23, 2024 at 5:10 PM Amit Kapila wrote: > > > > One minor comment: > > - if the table copy is finished (See > linkend="catalog-pg-subscription-rel"/>). > > + On the subscriber node, use the following SQL to identif

Re: Correction in doc of failover ready steps

2024-07-23 Thread shveta malik
On Tue, Jul 23, 2024 at 5:10 PM Amit Kapila wrote: > > One minor comment: > - if the table copy is finished (See linkend="catalog-pg-subscription-rel"/>). > + On the subscriber node, use the following SQL to identify which main > + slots should be synced to the standby that we plan to

Re: Correction in doc of failover ready steps

2024-07-23 Thread Amit Kapila
On Tue, Jul 23, 2024 at 9:40 AM shveta malik wrote: > > On Tue, Jul 23, 2024 at 8:14 AM Zhijie Hou (Fujitsu) > wrote: > > > > I also agree that separating the 2 queries makes sense. > > Please find the patch with the suggested change. > One minor comment: - if the table copy is finished (See

Re: Correction in doc of failover ready steps

2024-07-22 Thread shveta malik
On Tue, Jul 23, 2024 at 8:14 AM Zhijie Hou (Fujitsu) wrote: > > I also agree that separating the 2 queries makes sense. Please find the patch with the suggested change. thanks Shveta v2-0001-Correction-in-doc-of-failover-ready-steps.patch Description: Binary data

RE: Correction in doc of failover ready steps

2024-07-22 Thread Zhijie Hou (Fujitsu)
On Monday, July 22, 2024 7:13 PM Amit Kapila wrote: > > On Mon, Jul 22, 2024 at 10:59 AM shveta malik > wrote: > > > > On Mon, Jul 22, 2024 at 10:46 AM shveta malik > wrote: > > > > > > Hi, > > > > > > We have a query in failover-ready doc referring to > > > pg_subscription_rel. Unlike pg_subsc

Re: Correction in doc of failover ready steps

2024-07-22 Thread Amit Kapila
On Mon, Jul 22, 2024 at 10:59 AM shveta malik wrote: > > On Mon, Jul 22, 2024 at 10:46 AM shveta malik wrote: > > > > Hi, > > > > We have a query in failover-ready doc referring to > > pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives > > results only when connected to the da

Re: Correction in doc of failover ready steps

2024-07-21 Thread shveta malik
On Mon, Jul 22, 2024 at 10:46 AM shveta malik wrote: > > Hi, > > We have a query in failover-ready doc referring to > pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives > results only when connected to the database having the > subscription(s). If we run the concerned query on