Re: INDEX with optional storage parameter value

2020-06-30 Thread Bruce Momjian
On Mon, Jun 29, 2020 at 09:53:17AM -0400, Bruce Momjian wrote: > On Mon, Jun 29, 2020 at 04:18:58PM +0900, Michael Paquier wrote: > > On Sat, Jun 27, 2020 at 05:14:23PM -0400, Bruce Momjian wrote: > > > I found a few more places that also didn't properly document this; > > > patch attached. > > >

Re: INDEX with optional storage parameter value

2020-06-30 Thread Bruce Momjian
On Mon, Jun 29, 2020 at 09:26:57AM +0200, Laurenz Albe wrote: > On Sat, 2020-06-27 at 17:14 -0400, Bruce Momjian wrote: > > > I noticed an slight inaccuracy in the documentation for CREATE INDEX and > > > ALTER INDEX: > > > > > > CREATE INDEX ... [ WITH ( storage_parameter = value [, ... ] ) ] > >

Re: INDEX with optional storage parameter value

2020-06-29 Thread Bruce Momjian
On Mon, Jun 29, 2020 at 04:18:58PM +0900, Michael Paquier wrote: > On Sat, Jun 27, 2020 at 05:14:23PM -0400, Bruce Momjian wrote: > > I found a few more places that also didn't properly document this; > > patch attached. > > Good catch! I am not seeing any missing spots, so this looks good to >

Re: INDEX with optional storage parameter value

2020-06-29 Thread Laurenz Albe
On Sat, 2020-06-27 at 17:14 -0400, Bruce Momjian wrote: > > I noticed an slight inaccuracy in the documentation for CREATE INDEX and > > ALTER INDEX: > > > > CREATE INDEX ... [ WITH ( storage_parameter = value [, ... ] ) ] > > ALTER INDEX [ IF EXISTS ] name SET ( storage_parameter = value [, ... ]

Re: INDEX with optional storage parameter value

2020-06-29 Thread Michael Paquier
On Sat, Jun 27, 2020 at 05:14:23PM -0400, Bruce Momjian wrote: > I found a few more places that also didn't properly document this; > patch attached. Good catch! I am not seeing any missing spots, so this looks good to me. You are planning a backpatch, right? -- Michael signature.asc Descript

Re: INDEX with optional storage parameter value

2020-06-27 Thread Bruce Momjian
On Mon, Jun 22, 2020 at 01:13:52PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/sql-createindex.html > Description: > > Hello! > I noticed an slight inaccuracy in the documentation for CREATE