Re: Most-common value docs in PG 12

2019-09-30 Thread Bruce Momjian
On Fri, Sep 27, 2019 at 01:30:49PM +0200, Tomas Vondra wrote: > > > Now, maybe the table should be defined somewhere in perform.sgml - I > > > don't recall why exactly I chose not to do that, maybe because there is > > > no universal definition (one country uses text, another number, ...) > > > >

Re: Most-common value docs in PG 12

2019-09-27 Thread Tomas Vondra
On Thu, Sep 26, 2019 at 05:31:07PM -0400, Bruce Momjian wrote: On Thu, Sep 26, 2019 at 11:03:54PM +0200, Tomas Vondra wrote: On Thu, Sep 26, 2019 at 04:20:59PM -0400, Bruce Momjian wrote: > Uh, people normally list things in defined order, so you would usually > not list them in non-defined orde

Re: Most-common value docs in PG 12

2019-09-26 Thread Bruce Momjian
On Thu, Sep 26, 2019 at 11:03:54PM +0200, Tomas Vondra wrote: > On Thu, Sep 26, 2019 at 04:20:59PM -0400, Bruce Momjian wrote: > > Uh, people normally list things in defined order, so you would usually > > not list them in non-defined order unless there is a purpose. Doing > > that just to illustr

Re: Most-common value docs in PG 12

2019-09-26 Thread Tomas Vondra
On Thu, Sep 26, 2019 at 04:20:59PM -0400, Bruce Momjian wrote: On Thu, Sep 26, 2019 at 05:17:55PM -0300, Alvaro Herrera wrote: On 2019-Sep-26, Bruce Momjian wrote: > On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > > On 2019-Aug-30, Bruce Momjian wrote: > > > > > OK, how is thi

Re: Most-common value docs in PG 12

2019-09-26 Thread Bruce Momjian
On Thu, Sep 26, 2019 at 05:17:55PM -0300, Alvaro Herrera wrote: > On 2019-Sep-26, Bruce Momjian wrote: > > > On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > > > On 2019-Aug-30, Bruce Momjian wrote: > > > > > > > OK, how is this patch? I didn't mention psql since I think everyon

Re: Most-common value docs in PG 12

2019-09-26 Thread Alvaro Herrera
On 2019-Sep-26, Bruce Momjian wrote: > On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > > On 2019-Aug-30, Bruce Momjian wrote: > > > > > OK, how is this patch? I didn't mention psql since I think everyone > > > expects psql to show all information about tables and indexes. > >

Re: Most-common value docs in PG 12

2019-09-26 Thread Bruce Momjian
On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > On 2019-Aug-30, Bruce Momjian wrote: > > > OK, how is this patch? I didn't mention psql since I think everyone > > expects psql to show all information about tables and indexes. > > Why would you change perform.sgml? It seems unn

Re: Most-common value docs in PG 12

2019-09-11 Thread Alvaro Herrera
On 2019-Aug-30, Bruce Momjian wrote: > OK, how is this patch? I didn't mention psql since I think everyone > expects psql to show all information about tables and indexes. Why would you change perform.sgml? It seems unnecessary; the commands shown work fine. This part seems okay: > diff --git

Re: Most-common value docs in PG 12

2019-08-30 Thread Bruce Momjian
On Wed, Aug 28, 2019 at 08:25:41PM +0200, Tomas Vondra wrote: > On Wed, Aug 28, 2019 at 12:22:38PM -0400, Bruce Momjian wrote: > > If this is so, why don't we show the CREATE STATISTICS example as > > city/state, and not state/city? > > Yes, we deduplicate the attributes and store them sorted by a

Re: Most-common value docs in PG 12

2019-08-28 Thread Tomas Vondra
On Wed, Aug 28, 2019 at 12:22:38PM -0400, Bruce Momjian wrote: Our docs for most-common values in PG 12 has: --> CREATE STATISTICS stts3 (mcv) ON state, city FROM zipcodes; ANALYZE zipcodes; SELECT m.* FROM pg_statistic_ext join pg_statistic_ext_data on (oid =