Re: effective_cache_size

2019-11-03 Thread Nikolay Samokhvalov
A follow-up on this: Should documentation also mention that it does not make sense to set effective_cache_size < shared_buffers? And maybe it is worth prohibiting this or at least having a WARNING in logs? Why: I see setups where with growing RAM and shared_buffers set to 25%, effective_cache_siz

Re: effective_cache_size

2018-11-06 Thread Bruce Momjian
On Mon, Nov 5, 2018 at 02:01:12PM -0300, Alvaro Herrera wrote: > On 2018-Nov-05, Bruce Momjian wrote: > > > Well, here are the lines in guc.c: > > > > gettext_noop("Sets the planner's assumption about the size of > > the data cache."), > > gettext_noop("That is, the size

Re: effective_cache_size

2018-11-05 Thread Alvaro Herrera
On 2018-Nov-05, Bruce Momjian wrote: > Well, here are the lines in guc.c: > > gettext_noop("Sets the planner's assumption about the size of the > data cache."), > gettext_noop("That is, the size of the cache used for PostgreSQL > data files. " >

Re: effective_cache_size

2018-11-05 Thread Bruce Momjian
On Mon, Nov 5, 2018 at 03:23:03PM +0300, Nikolay Samokhvalov wrote: > > > On Mon, Nov 5, 2018 at 3:01 PM Bruce Momjian wrote: > > > >             {"effective_cache_size", PGC_USERSET, QUERY_TUNING_COST, > > > -                   gettext_noop("Sets the planner's assumption about > t

Re: effective_cache_size

2018-11-05 Thread Nikolay Samokhvalov
On Mon, Nov 5, 2018 at 3:01 PM Bruce Momjian wrote: > > > {"effective_cache_size", PGC_USERSET, QUERY_TUNING_COST, > > > - gettext_noop("Sets the planner's assumption about > the size of the disk cache."), > > > - gettext_noop("That is, the portion

Re: effective_cache_size

2018-11-05 Thread Bruce Momjian
On Mon, Nov 5, 2018 at 12:50:01PM +0100, Peter Eisentraut wrote: > On 16/10/2018 17:38, Bruce Momjian wrote: > > diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c > > index 2317e8b..e471d7f 100644 > > --- a/src/backend/utils/misc/guc.c > > +++ b/src/backend/utils/misc/guc.c

Re: effective_cache_size

2018-11-05 Thread Peter Eisentraut
On 16/10/2018 17:38, Bruce Momjian wrote: > diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c > index 2317e8b..e471d7f 100644 > --- a/src/backend/utils/misc/guc.c > +++ b/src/backend/utils/misc/guc.c > @@ -2987,10 +2987,9 @@ static struct config_int ConfigureNamesInt[] = >

Re: effective_cache_size

2018-11-02 Thread Bruce Momjian
On Tue, Oct 16, 2018 at 11:38:20AM -0400, Bruce Momjian wrote: > On Thu, Oct 11, 2018 at 01:48:49PM -0400, Bruce Momjian wrote: > > So, I think there are two action items here. First, rename "disk" to > > "drive" or "storage" in the docs and server variable descriptions. > > Second, unify the des

Re: effective_cache_size

2018-10-16 Thread Bruce Momjian
On Thu, Oct 11, 2018 at 01:48:49PM -0400, Bruce Momjian wrote: > So, I think there are two action items here. First, rename "disk" to > "drive" or "storage" in the docs and server variable descriptions. > Second, unify the description of effective_cache_size to talk about > storage cache size, no

Re: effective_cache_size

2018-10-11 Thread Bruce Momjian
On Thu, Sep 13, 2018 at 03:14:08PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/runtime-config-query.html > Description: > > Hi, > > The effective_cache_size documentation (section 19