Re: Signed-ness of ints is unclear in FE-BE protocol docs

2020-06-14 Thread Euler Taveira
On Thu, 11 Jun 2020 at 15:07, Shay Rojansky wrote: > > > Second, across the protocol docs, rather than using Int32 and Int64, >> which >> > generally look like they're signed (depending on which language you're >> > coming from), I'd consider using UInt32/UInt64, which are unambiguous >> with >>

Re: Signed-ness of ints is unclear in FE-BE protocol docs

2020-06-11 Thread Shay Rojansky
> > Second, across the protocol docs, rather than using Int32 and Int64, > which > > generally look like they're signed (depending on which language you're > > coming from), I'd consider using UInt32/UInt64, which are unambiguous > with > > regards to signed-ness. > > Well, they are actually signed

Re: Signed-ness of ints is unclear in FE-BE protocol docs

2020-06-11 Thread Peter Eisentraut
On 2020-06-09 23:35, PG Doc comments form wrote: The protocol docs generally do not mention whether ints are signed or unsigned - this has actually bitten me once in the past, where a signed int was accidentally used to interpret an unsigned int coming from PostgreSQL, leading to issues. The ambi

Signed-ness of ints is unclear in FE-BE protocol docs

2020-06-09 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/protocol-message-types.html Description: Hi, I'm the maintainer of Npgsql, the .NET open source driver for PostgreSQL. The protocol docs generally do not mention whether ints are signed o