Re: substring synopsis section, third argument is optional doc didn't show that

2025-02-22 Thread jian he
On Tue, Feb 18, 2025 at 7:06 AM David G. Johnston wrote: > > On Tue, Jan 21, 2025 at 11:29 PM jian he wrote: >> >> in 9.7.2 do you think it's worthwhile changing it to >> >> "" >> As with SIMILAR TO, substring(string, pattern, escape-character) >> the specified pattern must match the entire data

Threading issue / maybe just doc issue.

2025-02-18 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/libpq-threading.html Description: commit https://github.com/postgres/postgres/commit/515112f9d4874aaedd0c093f41c0ba3e0bf7f660 added global variables for backward compatibility support: sta

Re: substring synopsis section, third argument is optional doc didn't show that

2025-02-17 Thread David G. Johnston
On Tue, Jan 21, 2025 at 11:29 PM jian he wrote: > in 9.7.2 do you think it's worthwhile changing it to "" > As with SIMILAR TO, substring(string, pattern, escape-character) > the specified pattern must match the entire data string, or else the > function fails and returns null. > "" > ? > > Maki

Re: substring synopsis section, third argument is optional doc didn't show that

2025-01-21 Thread jian he
On Wed, Jan 22, 2025 at 12:53 AM Tom Lane wrote: > > jian he writes: > > https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-SIMILARTO-REGEXP > > > """ > > or as a plain three-argument function: > > substring(string, pattern, escape-character) > > """ > > > but here "escape-

Re: substring synopsis section, third argument is optional doc didn't show that

2025-01-21 Thread Tom Lane
jian he writes: > https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-SIMILARTO-REGEXP > """ > or as a plain three-argument function: > substring(string, pattern, escape-character) > """ > but here "escape-character" is optional. > substring(string, pattern [,escape-charac

substring synopsis section, third argument is optional doc didn't show that

2025-01-21 Thread jian he
hi. https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-SIMILARTO-REGEXP """ or as a plain three-argument function: substring(string, pattern, escape-character) """ but here "escape-character" is optional. substring(string, pattern [,escape-character]) would be more accura

Re: Typo in doc page?

2025-01-07 Thread Daniel Gustafsson
> On 26 Dec 2024, at 16:43, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/17/sql-keywords-appendix.html > Description: > > I could be mistaken but, in the following doc

Typo in doc page?

2025-01-04 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/sql-keywords-appendix.html Description: I could be mistaken but, in the following documentation page: https://www.postgresql.org/docs/current/sql-keywords-appendix.html there seems to be a

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-20 Thread Daniel Gustafsson
> On 18 Nov 2024, at 20:51, Bruce Momjian wrote: > > On Wed, Nov 6, 2024 at 03:58:18PM +0100, Daniel Gustafsson wrote: >>> On 6 Nov 2024, at 15:51, Alvaro Herrera wrote: >>> >>> On 2024-Nov-06, Daniel Gustafsson wrote: >>> Committed, and with some help from Magnus, the docs site has been

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-18 Thread Bruce Momjian
On Wed, Nov 6, 2024 at 03:58:18PM +0100, Daniel Gustafsson wrote: > > On 6 Nov 2024, at 15:51, Alvaro Herrera wrote: > > > > On 2024-Nov-06, Daniel Gustafsson wrote: > > > >> Committed, and with some help from Magnus, the docs site has been reloaded > >> with > >> the new CSS. Everything seem

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-12 Thread Daniel Gustafsson
> On 12 Nov 2024, at 12:51, Alvaro Herrera wrote: > > By the way, is there something funny going on with the transparency of > these tooltips? I was looking at this page today > https://www.postgresql.org/docs/current/creating-cluster.html > and see it like the attached screenshot. The tooltip

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-12 Thread Alvaro Herrera
By the way, is there something funny going on with the transparency of these tooltips? I was looking at this page today https://www.postgresql.org/docs/current/creating-cluster.html and see it like the attached screenshot. The tooltip appears to have no background color, so the text underneath sh

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-06 Thread Daniel Gustafsson
> On 6 Nov 2024, at 20:34, David Rowley wrote: > > On Thu, 7 Nov 2024 at 03:58, Daniel Gustafsson wrote: >> >>> On 6 Nov 2024, at 15:51, Alvaro Herrera wrote: >>> Ah, but we kept the #? I thought it was going to be changed to ¶ ... >>> was there any voice against that? >> >> You're right, I

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-06 Thread David Rowley
On Thu, 7 Nov 2024 at 03:58, Daniel Gustafsson wrote: > > > On 6 Nov 2024, at 15:51, Alvaro Herrera wrote: > > Ah, but we kept the #? I thought it was going to be changed to ¶ ... > > was there any voice against that? > > You're right, I mistakenly remembered there being no concensus and didn't

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-06 Thread David Rowley
On Thu, 7 Nov 2024 at 02:33, Daniel Gustafsson wrote: > Committed, and with some help from Magnus, the docs site has been reloaded > with > the new CSS. Everything seems to behave as expected when testing in Firefox, > Safari, Chrome and Edge. Great. Thank you to you both. David

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-06 Thread Daniel Gustafsson
> On 6 Nov 2024, at 15:51, Alvaro Herrera wrote: > > On 2024-Nov-06, Daniel Gustafsson wrote: > >> Committed, and with some help from Magnus, the docs site has been reloaded >> with >> the new CSS. Everything seems to behave as expected when testing in Firefox, >> Safari, Chrome and Edge. > >

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-06 Thread Alvaro Herrera
On 2024-Nov-06, Daniel Gustafsson wrote: > Committed, and with some help from Magnus, the docs site has been reloaded > with > the new CSS. Everything seems to behave as expected when testing in Firefox, > Safari, Chrome and Edge. Ah, but we kept the #? I thought it was going to be changed to

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-06 Thread Daniel Gustafsson
> On 6 Nov 2024, at 07:10, David Rowley wrote: > > On Wed, 30 Oct 2024 at 11:39, Daniel Gustafsson wrote: >> >>> On 29 Oct 2024, at 23:36, David Rowley wrote: >>> Do you have access to make this change? I think it needs to go into >>> https://www.postgresql.org/media/css/main.css >> >> I hav

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-05 Thread David Rowley
On Wed, 30 Oct 2024 at 11:39, Daniel Gustafsson wrote: > > > On 29 Oct 2024, at 23:36, David Rowley wrote: > > Do you have access to make this change? I think it needs to go into > > https://www.postgresql.org/media/css/main.css > > I have a pgweb commitbit so if you roll a patch for it I can ta

Re: pgsql: doc: improve build for non-Latin1 characters

2024-11-04 Thread Bruce Momjian
for my patch so I assumed it was acceptable. > this is the right direction. Moreover, this touched a couple of files that > it shouldn't have: > > doc/src/sgml/images/genetic-algorithm.svg is a generated file that shouldn't > be changed directly. In fact, adding the *.s

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-29 Thread Daniel Gustafsson
> On 29 Oct 2024, at 23:36, David Rowley wrote: > My thoughts are that it doesn't seem excessively critical that this is > perfect on the first attempt. I'd be happy to see us try to improve > this. Maybe if there's some better way, someone will appear and tell > us how to do it properly. I am ho

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-29 Thread David Rowley
On Wed, 30 Oct 2024 at 03:46, Daniel Gustafsson wrote: > On the whole I wonder if we shouldn't just go with the proposal since it > improves the status quo, optimizing for users who hover to get link anchors on > mobile probably isn't worth the investment in time. My primary motivation for hackin

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-29 Thread Daniel Gustafsson
> On 29 Oct 2024, at 12:31, David Rowley wrote: > > On Thu, 17 Oct 2024 at 20:20, Daniel Gustafsson wrote: >> My main concern is that the relative positioning will push it off screen >> with a >> break on smaller viewports (like phones). > > I can recreate what you sent in the screenshot, but

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-29 Thread David Rowley
al additional rows. When there are many outer duplicates, the reported actual row count for the inner child plan node can be significantly larger than the number of rows that are actually in the inner relation. BitmapAnd and BitmapOr nodes always report their actual row counts as ze

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-17 Thread Daniel Gustafsson
> On 17 Oct 2024, at 01:24, David Rowley wrote: > > On Thu, 17 Oct 2024 at 11:19, Bruce Momjian wrote: >> Where are we on this? I still see "#". > > I was hoping for some voting for or against my patch or the general idea of > it. Sorry for the delay, this fell off the inbox-radar. I am in f

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-16 Thread David Rowley
On Thu, 17 Oct 2024 at 11:19, Bruce Momjian wrote: > Where are we on this? I still see "#". I was hoping for some voting for or against my patch or the general idea of it. Also, my web skills in this area amount to trial and error, so it would also be good to have someone who knows what they're

A minor bug in doc. Hovering over heading shows # besides it.

2024-10-16 Thread David G. Johnston
On Wednesday, October 16, 2024, Bruce Momjian wrote: > > Where are we on this? I still see "#". > > We should document what we are doing in Conventions. The hover stuff is a nice usability add, if a bit limited on mobile. My +1 as well to matching Python with the pilcrow symbol. David J.

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-16 Thread Bruce Momjian
hat it might > inspire someone who actually knows what they're doing with CSS to make > it better. > > David > > [1] > https://stackoverflow.blog/2024/07/24/developers-want-more-more-more-the-2024-results-from-stack-overflow-s-annual-developer-survey/ > dif

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-08-11 Thread David Rowley
On Fri, 19 Jul 2024 at 06:03, Jonathan S. Katz wrote: > > On 7/18/24 1:59 PM, Daniel Gustafsson wrote: > > Looking a bit closer, the Python documentation does just this, a pilcrow > > with a > > tool-tip ("Link to this heading") when hovering over it > > I forgot why we went with the "#" and not

Re: Correction in doc of failover ready steps

2024-07-23 Thread shveta malik
; is built by CONCAT() which means it should be valid, while the first query's > subslotname could be NULL if user executed ALTER SUB SET (slot_name = NONE). > Thanks for pointing it out. Please find a new patch with this change. Also corrected the commit message in this patch. thanks S

RE: Correction in doc of failover ready steps

2024-07-23 Thread Zhijie Hou (Fujitsu)
On Wednesday, July 24, 2024 10:56 AM shveta malik wrote: > > On Tue, Jul 23, 2024 at 5:10 PM Amit Kapila wrote: > > > > One minor comment: > > - if the table copy is finished (See > linkend="catalog-pg-subscription-rel"/>). > > + On the subscriber node, use the following SQL to identif

Re: Correction in doc of failover ready steps

2024-07-23 Thread shveta malik
hat it was introduced in the original commit but it seems better to > change if we agree. Yes, it makes sense. Please find the patch with this change. thanks SHveta v3-0001-Correction-in-doc-of-failover-ready-steps.patch Description: Binary data

Re: Correction in doc of failover ready steps

2024-07-23 Thread Amit Kapila
On Tue, Jul 23, 2024 at 9:40 AM shveta malik wrote: > > On Tue, Jul 23, 2024 at 8:14 AM Zhijie Hou (Fujitsu) > wrote: > > > > I also agree that separating the 2 queries makes sense. > > Please find the patch with the suggested change. > One minor comment: - if the table copy is finished (See

Re: Correction in doc of failover ready steps

2024-07-22 Thread shveta malik
On Tue, Jul 23, 2024 at 8:14 AM Zhijie Hou (Fujitsu) wrote: > > I also agree that separating the 2 queries makes sense. Please find the patch with the suggested change. thanks Shveta v2-0001-Correction-in-doc-of-failover-ready-steps.patch Description: Binary data

RE: Correction in doc of failover ready steps

2024-07-22 Thread Zhijie Hou (Fujitsu)
On Monday, July 22, 2024 7:13 PM Amit Kapila wrote: > > On Mon, Jul 22, 2024 at 10:59 AM shveta malik > wrote: > > > > On Mon, Jul 22, 2024 at 10:46 AM shveta malik > wrote: > > > > > > Hi, > > > > > > We have a query in failo

Re: Correction in doc of failover ready steps

2024-07-22 Thread Amit Kapila
On Mon, Jul 22, 2024 at 10:59 AM shveta malik wrote: > > On Mon, Jul 22, 2024 at 10:46 AM shveta malik wrote: > > > > Hi, > > > > We have a query in failover-ready doc referring to > > pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives &g

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-21 Thread 日向充
On Thu, Jul 18, 2024 at 9:05 PM Tom Lane wrote: > "David G. Johnston" writes: > > On Thu, Jul 18, 2024 at 7:10 PM Michael Paquier > wrote: > >> Not sure that this is worth changing. The examples work OK when taken > >> in isolation or are able to demonstrate the point they want to show. > >> I

Re: Correction in doc of failover ready steps

2024-07-21 Thread shveta malik
On Mon, Jul 22, 2024 at 10:46 AM shveta malik wrote: > > Hi, > > We have a query in failover-ready doc referring to > pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives > results only when connected to the database having the > subscription(s). If we run t

Correction in doc of failover ready steps

2024-07-21 Thread shveta malik
Hi, We have a query in failover-ready doc referring to pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives results only when connected to the database having the subscription(s). If we run the concerned query on any other database, it will give incomplete results i.e. it will

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread David G. Johnston
On Thu, Jul 18, 2024 at 9:05 PM Tom Lane wrote: > "David G. Johnston" writes: > > On Thu, Jul 18, 2024 at 7:10 PM Michael Paquier > wrote: > >> Not sure that this is worth changing. The examples work OK when taken > >> in isolation or are able to demonstrate the point they want to show. > >> I

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread Tom Lane
"David G. Johnston" writes: > On Thu, Jul 18, 2024 at 7:10 PM Michael Paquier wrote: >> Not sure that this is worth changing. The examples work OK when taken >> in isolation or are able to demonstrate the point they want to show. >> In short, not all these queries are here to be compatible with

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread David G. Johnston
On Thu, Jul 18, 2024 at 7:10 PM Michael Paquier wrote: > On Fri, Jul 19, 2024 at 10:46:04AM +0900, 日向充 wrote: > > I have found executable examples that do not work correctly > > in the doc of "SQL Functions Returning Sets" in xfunc.sgml. > > So I fixed the exampl

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread Michael Paquier
On Fri, Jul 19, 2024 at 10:46:04AM +0900, 日向充 wrote: > I have found executable examples that do not work correctly > in the doc of "SQL Functions Returning Sets" in xfunc.sgml. > So I fixed the examples as follows. > - Changed CREATE TABLE tab > '(y int, z

A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread 日向充
Hi! I have found executable examples that do not work correctly in the doc of "SQL Functions Returning Sets" in xfunc.sgml. So I fixed the examples as follows. - Changed CREATE TABLE tab '(y int, z int)' to '(x int, y int, z int)' - Changed INSERT INTO tab

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Jonathan S. Katz
On 7/18/24 1:59 PM, Daniel Gustafsson wrote: On 18 Jul 2024, at 15:49, Tom Lane wrote: Daniel Gustafsson writes: While not a standard the pilcrow [0] is, AFAICT from a bit of looking at other docs, commonly used for this. There is a lot of variability though so whichever we choose it will be

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Tom Lane
Daniel Gustafsson writes: > Looking a bit closer, the Python documentation does just this, a pilcrow with > a > tool-tip ("Link to this heading") when hovering over it Oh nice --- a precedent! And one that a fair number of people will have seen before. +1 for copying Python.

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Daniel Gustafsson
> On 18 Jul 2024, at 15:49, Tom Lane wrote: > > Daniel Gustafsson writes: >> While not a standard the pilcrow [0] is, AFAICT from a bit of looking at >> other >> docs, commonly used for this. There is a lot of variability though so >> whichever we choose it will be wrong one for someone. > >

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Tom Lane
Daniel Gustafsson writes: > While not a standard the pilcrow [0] is, AFAICT from a bit of looking at other > docs, commonly used for this. There is a lot of variability though so > whichever we choose it will be wrong one for someone. I like this suggestion better because that's U+00B6, ie part

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread David Rowley
On Thu, 18 Jul 2024 at 19:46, Daniel Gustafsson wrote: > There is a lot of variability though so > whichever we choose it will be wrong one for someone. I think the tooltip would help reduce the chances of someone being confused. For an example, see [1]. David [1] https://devblogs.microsoft.c

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Daniel Gustafsson
> On 18 Jul 2024, at 07:18, Tom Lane wrote: > Yeah. I've found this new feature useful multiple times already, > but the '#' icon is as non-mnemonic and unobvious as could possibly > be. OTOH, I don't know of a standard icon for this feature. While not a standard the pilcrow [0] is, AFAICT fro

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Dean Rasheed
On Thu, 18 Jul 2024 at 07:40, David Rowley wrote: > > On Thu, 18 Jul 2024 at 17:18, Tom Lane wrote: > > Yeah. I've found this new feature useful multiple times already, > > but the '#' icon is as non-mnemonic and unobvious as could possibly > > be. OTOH, I don't know of a standard icon for this

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread David Rowley
On Thu, 18 Jul 2024 at 17:18, Tom Lane wrote: > Yeah. I've found this new feature useful multiple times already, > but the '#' icon is as non-mnemonic and unobvious as could possibly > be. OTOH, I don't know of a standard icon for this feature. I also find it useful and certainly don't want it

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread David G. Johnston
On Wednesday, July 17, 2024, Tom Lane wrote: > David Rowley writes: > > On Thu, 18 Jul 2024 at 16:55, Muhammad Ikram wrote: > >> when we hover over Table Basics, it shows # sign postfixed. I think it > needs to be removed > > > In [1], there was some talk about using another more suitable > > c

Re: Column data type in doc example may be changed to VARCHAR from TEXT

2024-07-17 Thread Tom Lane
"David G. Johnston" writes: > On Wednesday, July 17, 2024, Muhammad Ikram wrote: >> IMHO, a minor issue in the doc. As a good practice we use TEXT data type >> when we expect longer text e.g. comments, doc kind of columns. > Who is we in this conversation? If i

Re: Column data type in doc example may be changed to VARCHAR from TEXT

2024-07-17 Thread Muhammad Ikram
Thanks David for clarifying. I am coming from an Oracle background, so there we(developers) mostly use CHAR or VARCHAR2 data types for such identifiers instead of CLOB. Sorry for my naiveness about PostgreSQL doc practices. Regards, Muhammad Ikram Bitnine global. On Thu, Jul 18, 2024 at 10

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread Tom Lane
David Rowley writes: > On Thu, 18 Jul 2024 at 16:55, Muhammad Ikram wrote: >> when we hover over Table Basics, it shows # sign postfixed. I think it needs >> to be removed > In [1], there was some talk about using another more suitable > character. If the purpose of the '#' isn't obvious, then

Re: Column data type in doc example may be changed to VARCHAR from TEXT

2024-07-17 Thread David G. Johnston
On Wednesday, July 17, 2024, Muhammad Ikram wrote: > > > IMHO, a minor issue in the doc. As a good practice we use TEXT data type > when we expect longer text e.g. comments, doc kind of columns. > Who is we in this conversation? If it’s the documentation please reference exist

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread Kashif Zeeshan
hink it > needs to be removed > > Those are meant to be there. They allow you to copy a URL directly to > that doc section. > > In [1], there was some talk about using another more suitable > character. If the purpose of the '#' isn't obvious, then ma

Column data type in doc example may be changed to VARCHAR from TEXT

2024-07-17 Thread Muhammad Ikram
Hi, IMHO, a minor issue in the doc. As a good practice we use TEXT data type when we expect longer text e.g. comments, doc kind of columns. For columns where we know what can be a maximum Text size though variable, we use VARCHAR to limit accidental long text or for other worthy reasons

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread David Rowley
On Thu, 18 Jul 2024 at 16:55, Muhammad Ikram wrote: > 5.1. Table Basics # > > when we hover over Table Basics, it shows # sign postfixed. I think it needs > to be removed Those are meant to be there. They allow you to copy a URL directly to that doc section. In [1], there was som

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread David G. Johnston
On Wednesday, July 17, 2024, Kashif Zeeshan wrote: > > > I have checked other pages too and the issue is only with this page. > There are like thousands of them… https://www.postgresql.org/docs/current/ddl-generated-columns.html#DDL-GENERATED-COLUMNS David J.

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread David G. Johnston
On Wednesday, July 17, 2024, Muhammad Ikram wrote: > > Hi, > > On page > > https://www.postgresql.org/docs/devel/ddl-basics.html > > 5.1. Table Basics # > > > when we hover over Table Basics, it shows # sign postfixed. I think it

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread Kashif Zeeshan
Hi I have checked other pages too and the issue is only with this page. Regards Kashif Zeeshan On Thu, Jul 18, 2024 at 9:55 AM Muhammad Ikram wrote: > > Hi, > > On page > > https://www.postgresql.org/docs/devel/ddl-basics.html > > 5.1. Table Basics # >

A minor bug in doc. Hovering over heading shows # besides it.

2024-07-17 Thread Muhammad Ikram
Hi, On page https://www.postgresql.org/docs/devel/ddl-basics.html 5.1. Table Basics # when we hover over Table Basics, it shows # sign postfixed. I think it needs to be removed -- Regards, Muhammad Ikram Bitnine Global

Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options

2024-04-11 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/postgres-fdw.html Description: Hi, The https://www.postgresql.org/docs/current/postgres-fdw.html#POSTGRES-FDW-OPTIONS-REMOTE-EXECUTION section mentions for `extensions` configuration optio

Re: Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options

2024-04-11 Thread Rajan Pandey
eeds to be pushed down explicitly. On Tue, Apr 9, 2024 at 8:06 PM Rajan Pandey wrote: > Hi team 😃. > > In the > https://www.postgresql.org/docs/current/postgres-fdw.html#POSTGRES-FDW-OPTIONS-REMOTE-EXECUTION > doc, it > mentions that Immutable Functions and Hi can be pus

Re: Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options

2024-04-09 Thread Rajan Pandey
Hi team 😃. In the https://www.postgresql.org/docs/current/postgres-fdw.html#POSTGRES-FDW-OPTIONS-REMOTE-EXECUTION doc, it mentions that Immutable Functions and Hi can be pushed down using `extensions` option for foreign server. But it does not mention TYPE. In the shippable.c <ht

Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options

2024-04-03 Thread Rajan Pandey
Hi, I was reading https://www.postgresql.org/docs/current/postgres-fdw.html#POSTGRES-FDW-OPTIONS-REMOTE-EXECUTION and found that it mentions that Immutable Functions and Operators can be pushed down using `extensions` option for foreign server. But it does not mention about TYPE. In the shippable.

Re: Question on doc for RETURNING clause

2024-01-11 Thread Russell, John
> On Jan 11, 2024, at 12:43 PM, Tom Lane wrote: > > "Russell, John" writes: >> Hi, I was thinking of suggesting some doc clarifications and additional >> examples related to the RETURNING clause. Just a couple of questions first >> to see if my underst

Re: Question on doc for RETURNING clause

2024-01-11 Thread Tom Lane
"Russell, John" writes: > Hi, I was thinking of suggesting some doc clarifications and additional > examples related to the RETURNING clause. Just a couple of questions first to > see if my understanding is correct. > I was trying to figure out what the precise “thing” i

Re: Question on doc for RETURNING clause

2024-01-11 Thread David G. Johnston
On Thu, Jan 11, 2024 at 11:55 AM Russell, John wrote: > ``` > postgres=> insert into generatedfields (x) values (0), (10), (100) order > by 2 desc returning id, x; > ERROR: ORDER BY position 2 is not in select list > LINE 1: ...eratedfields (x) values (0), (10), (100) order by 2 desc ret... >

Question on doc for RETURNING clause

2024-01-11 Thread Russell, John
Hi, I was thinking of suggesting some doc clarifications and additional examples related to the RETURNING clause. Just a couple of questions first to see if my understanding is correct. There’s the basic usage of the RETURNING clause, like is shown on the https://www.postgresql.org/docs

Re: initdb username doc bug

2024-01-10 Thread Bruce Momjian
On Wed, Jan 10, 2024 at 06:05:17PM +0100, Álvaro Herrera wrote: > On 2024-Jan-10, Bruce Momjian wrote: > > > On Mon, Jan 8, 2024 at 04:50:19PM -0500, Tom Lane wrote: > > > Bruce Momjian writes: > > > > Agreed, updated patch attached. > > > > > > WFM. > > > > Patch applied back to PG 16, which

Re: initdb username doc bug

2024-01-10 Thread Álvaro Herrera
On 2024-Jan-10, Bruce Momjian wrote: > On Mon, Jan 8, 2024 at 04:50:19PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > Agreed, updated patch attached. > > > > WFM. > > Patch applied back to PG 16, which is where the erroneous text was > added. Thank you! It looks good to me too. So

Re: initdb username doc bug

2024-01-10 Thread Bruce Momjian
On Mon, Jan 8, 2024 at 04:50:19PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > Agreed, updated patch attached. > > WFM. Patch applied back to PG 16, which is where the erroneous text was added. -- Bruce Momjian https://momjian.us EDB htt

Re: initdb username doc bug

2024-01-08 Thread Tom Lane
Bruce Momjian writes: > Agreed, updated patch attached. WFM. regards, tom lane

Re: initdb username doc bug

2024-01-08 Thread David G. Johnston
On Mon, Jan 8, 2024 at 2:26 PM Bruce Momjian wrote: > On Sat, Jan 6, 2024 at 11:27:14PM -0500, Tom Lane wrote: > > "David G. Johnston" writes: > > > Or just the bit more verbose “user running the initdb command” and > don’t > > > bother giving it a label, which is basically the approach used in

Re: initdb username doc bug

2024-01-08 Thread Bruce Momjian
an.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/ref/initdb.sgml b/doc/src/sgml/ref/initdb.sgml index d43c91575c..cd75cae10e 100644 --- a/doc/src/sgml/ref/initdb.sgml +++ b/doc/src/sgml/ref/initdb.sgml

Re: initdb username doc bug

2024-01-06 Thread Tom Lane
"David G. Johnston" writes: > Or just the bit more verbose “user running the initdb command” and don’t > bother giving it a label, which is basically the approach used in the > description for initdb anyway. Or if you want a few more words, "name of the operating-system user running initdb". I d

Re: initdb username doc bug

2024-01-06 Thread David G. Johnston
On Saturday, January 6, 2024, David G. Johnston wrote: > On Saturday, January 6, 2024, Bruce Momjian wrote: > >> >> geteuid() returns the effective user ID of the calling process. >> >> so it is not the owner of the data dirctory, but the installation user. >> >> I am open to saying that

Re: initdb username doc bug

2024-01-06 Thread David G. Johnston
On Saturday, January 6, 2024, Bruce Momjian wrote: > On Sat, Jan 6, 2024 at 08:11:14PM -0700, David G. Johnston wrote: > > On Saturday, January 6, 2024, Bruce Momjian wrote: > > > > This commit: > > > > commit 910cab820d > > Author: Alvaro Herrera > > Da

Re: initdb username doc bug

2024-01-06 Thread Bruce Momjian
On Sat, Jan 6, 2024 at 08:11:14PM -0700, David G. Johnston wrote: > On Saturday, January 6, 2024, Bruce Momjian wrote: > > This commit: > >         commit 910cab820d >         Author: Alvaro Herrera >         Date:   Fri Nov 18 11:59:26 2022 +0100 > >             Add gloss

Re: initdb username doc bug

2024-01-06 Thread David G. Johnston
On Saturday, January 6, 2024, Bruce Momjian wrote: > This commit: > > commit 910cab820d > Author: Alvaro Herrera > Date: Fri Nov 18 11:59:26 2022 +0100 > > Add glossary entries related to superusers > > Extracted from a more ambitious patch. > >

initdb username doc bug

2024-01-06 Thread Bruce Momjian
y you can decide what is important to you. diff --git a/doc/src/sgml/ref/initdb.sgml b/doc/src/sgml/ref/initdb.sgml index d43c91575c..17363c63b7 100644 --- a/doc/src/sgml/ref/initdb.sgml +++ b/doc/src/sgml/ref/initdb.sgml @@ -417,10 +417,9 @@ PostgreSQL documentation --username=use

Re: doc-fix-for-POSIX-Time-Zone-Specifications

2023-10-31 Thread Bruce Momjian
On Mon, May 17, 2021 at 11:36:34AM +, tanghy.f...@fujitsu.com wrote: > Hi > > Attached a patch to delete "CURRENT(as of 2020) " description in POSIX Time > Zone Specifications. > I'm not a native English speaker, if my fix is not appropriate or > insufficient, please be kind to share your th

doc pg_describe_object description add a url link to pg_depend catalog.

2023-10-22 Thread jian he
: Sun, 22 Oct 2023 12:39:59 +0800 Subject: [PATCH v1 1/1] add pg_depend url link in pg_describe_object's description. --- doc/src/sgml/func.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 24ad87f9..64990af7 100644

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 09:42:49AM +0200, Daniel Gustafsson wrote: > > On 26 Sep 2023, at 22:26, Bruce Momjian wrote: > > On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote: > > >> I would get rid of any mentions of our old pre-v10 versioning scheme in the > >> current documentatio

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-27 Thread Daniel Gustafsson
> On 26 Sep 2023, at 22:26, Bruce Momjian wrote: > On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote: >> I would get rid of any mentions of our old pre-v10 versioning scheme in the >> current documentation. For content such as this, a very big +1. > Good point, how is this attac

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread Bruce Momjian
On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote: > On Tue, Sep 26, 2023 at 10:35 AM Bruce Momjian wrote: > > On Mon, Sep 18, 2023 at 08:14:04PM +0000, PG Doc comments form wrote: > > The following documentation comment has been logged

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread David G. Johnston
On Tue, Sep 26, 2023 at 10:35 AM Bruce Momjian wrote: > On Mon, Sep 18, 2023 at 08:14:04PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/pgupgrade.html > >

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread Bruce Momjian
On Mon, Sep 18, 2023 at 08:14:04PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/pgupgrade.html > Description: > > I feel like for readability the pg_upgrade doc s

pg_upgrade doc uses inconsistent versions within the doc.

2023-09-18 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/pgupgrade.html Description: I feel like for readability the pg_upgrade doc should use the same old_version and new_version examples when showing examples throughout the doc page. as an

Re: doc build error on Fedora 38

2023-04-06 Thread Tom Lane
is the problem. Apparently my script failed to install > docbook-dtds adn docbook-style-xsl while building Fedora 38 box.  See also this recent change: https://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=969509c3f Those doc changes haven't shipped yet, but the it-do

Re: doc build error on Fedora 38

2023-04-06 Thread Devrim Gündüz
Hi Julien, On Thu, 2023-04-06 at 20:18 +0800, Julien Rouhaud wrote: > maybe you have a local copy of the docbook dtd on the older version? > have > you installed the required packages for that now that those files are > available only via https, which isn't supported by any tool? > https://www.pos

Re: doc build error on Fedora 38

2023-04-06 Thread Julien Rouhaud
On Thu, 6 Apr 2023, 19:11 Devrim Gündüz, wrote: > Hi, > > On Thu, 2023-04-06 at 13:10 +0200, Laurenz Albe wrote: > > Not sure if that helps, but could it simply be a problem accessing > > the network? > > Not sure. I can download and install all other tarballs, packages, etc. > maybe you have a

Re: doc build error on Fedora 38

2023-04-06 Thread Devrim Gündüz
Hi, On Thu, 2023-04-06 at 13:10 +0200, Laurenz Albe wrote: > Not sure if that helps, but could it simply be a problem accessing > the network? Not sure. I can download and install all other tarballs, packages, etc. Regards, -- Devrim Gündüz Open Source Solution Architect, PostgreSQL Major Contr

Re: doc build error on Fedora 38

2023-04-06 Thread Laurenz Albe
On Thu, 2023-04-06 at 11:41 +0100, Devrim Gündüz wrote: > I'm getting the following errors while building PDF docs on Fedora 38 > (and works fine on Fedora 37). This is how I build them: > > ./configure > cd doc/src/sgml/ > make postgres-A4.pdf > > and getting the

doc build error on Fedora 38

2023-04-06 Thread Devrim Gündüz
Hi, I'm getting the following errors while building PDF docs on Fedora 38 (and works fine on Fedora 37). This is how I build them: ./configure cd doc/src/sgml/ make postgres-A4.pdf and getting the following errors. Google did not help me that much. This is libxml2-2.10.3 and libxslt 1

Re: meson doc: Is "-Dtap-tests" a typo?

2023-02-14 Thread Katsuragi Yuta
On 2023-02-15 13:44, Michael Paquier wrote: On Tue, Feb 14, 2023 at 09:06:13AM +, Katsuragi Yuta wrote: The parameter name "-Dtap-tests" in the meson's doc seems to be a typo. I think "-Dtap_tests" is the correct name. Attached patch fixes that. I got an unkno

Re: meson doc: Is "-Dtap-tests" a typo?

2023-02-14 Thread Michael Paquier
On Tue, Feb 14, 2023 at 09:06:13AM +, Katsuragi Yuta wrote: > The parameter name "-Dtap-tests" in the meson's doc seems to be a typo. > I think "-Dtap_tests" is the correct name. Attached patch fixes that. > > I got an unknown options error by

  1   2   3   >