Re: documentation typo

2022-01-31 Thread Daniel Gustafsson
> On 31 Jan 2022, at 23:05, Tom Lane wrote: > It's hard to explain why lo_creat is there at all without mentioning > 8.1, so I ended up with the below, which basically says that lo_creat > is only useful for talking to pre-8.1 servers. Agreed, makes sense. > Comments? LGTM. -- Daniel Gustaf

Re: documentation typo

2022-01-31 Thread Tom Lane
Daniel Gustafsson writes: >> On 30 Jan 2022, at 16:52, Tom Lane wrote: >> I could get behind documenting the more modern >> one first, though. > +1 Proposed patch attached. >> I wonder if it's time to remove the references to PG 8.1? > I think it's time to remove references to 8.0 and 8.1 to

Re: documentation typo

2022-01-31 Thread Daniel Gustafsson
> On 30 Jan 2022, at 16:52, Tom Lane wrote: > I could get behind documenting the more modern > one first, though. +1 > I wonder if it's time to remove the references to PG 8.1? I think it's time to remove references to 8.0 and 8.1 to de-clutter the page, 8.3 or 8.4 seems like a better lower li

Re: documentation typo

2022-01-30 Thread Tom Lane
Magnus Hagander writes: > It might be worth splitting that part into one section with the > current function (lo_create) and then a separate section with the > backwards-compatible lo_creat function though -- I can see how it's > easy to come to the conclusion you did from reading it, and that cou

Re: documentation typo

2022-01-30 Thread Magnus Hagander
On Sun, Jan 30, 2022 at 1:39 PM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/lo-interfaces.html > Description: > > I assume "inv_oid = lo_creat(conn, INV_READ|INV_WRITE);" should be "inv_oid > = lo_

documentation typo

2022-01-30 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/10/lo-interfaces.html Description: I assume "inv_oid = lo_creat(conn, INV_READ|INV_WRITE);" should be "inv_oid = lo_create(conn, INV_READ|INV_WRITE);", right? https://www.postgresql.org/docs/