Re: pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-23 Thread Amit Kapila
On Sat, Feb 22, 2025 at 11:26 AM Shlok Kyal wrote: > > Adding Amit to the thread. > Thanks. Looking at the original complaint: > It says > * To avoid potential issues with the slot synchronization > where the > * restart_lsn of a replication slot can go backwa

Re: pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-21 Thread Shlok Kyal
Adding Amit to the thread. On Thu, 20 Feb 2025 at 23:19, Masahiko Sawada wrote: > > On Wed, Feb 19, 2025 at 8:25 PM Shlok Kyal wrote: > > > > On Thu, 20 Feb 2025 at 09:39, Nisha Moond wrote: > > > > > > On Wed, Feb 19, 2025 at 12:40 PM Shlok Kyal > > > wrote: > > > > Hi, > > > > > > > > The f

Re: pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-20 Thread Masahiko Sawada
On Wed, Feb 19, 2025 at 8:25 PM Shlok Kyal wrote: > > On Thu, 20 Feb 2025 at 09:39, Nisha Moond wrote: > > > > On Wed, Feb 19, 2025 at 12:40 PM Shlok Kyal > > wrote: > > > Hi, > > > > > > The failover option is set to false by default while copying of the > > > slots as it may cause some issue

Re: pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-19 Thread Shlok Kyal
On Thu, 20 Feb 2025 at 09:39, Nisha Moond wrote: > > On Wed, Feb 19, 2025 at 12:40 PM Shlok Kyal wrote: > > Hi, > > > > The failover option is set to false by default while copying of the > > slots as it may cause some issue during slot synchronization as per > > discussion [1]. > > > > I have cr

Re: pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-19 Thread Nisha Moond
On Wed, Feb 19, 2025 at 12:40 PM Shlok Kyal wrote: > Hi, > > The failover option is set to false by default while copying of the > slots as it may cause some issue during slot synchronization as per > discussion [1]. > > I have created a patch to update the documentation for the same. > Thanks fo

Re: pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-18 Thread Shlok Kyal
On Tue, 18 Feb 2025 at 19:49, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/17/functions-admin.html > Description: > > The documentation for pg_copy_logical_replication_slot doesn't mention that > the f

pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-18 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/functions-admin.html Description: The documentation for pg_copy_logical_replication_slot doesn't mention that the failover property for the logical slot is not copied. I assumed there was