On 2021-Oct-08, Laurenz Albe wrote:
> I remain of the opinion that the comments should be
> retained, but we can leave that for somebody else to
> decide.
So I just realized that I added this comment in 8c250f3741f.
The point of this comment is that the list of options to which
"direction"
On Tue, Oct 12, 2021 at 08:43:34AM +0200, Laurenz Albe wrote:
> On Mon, 2021-10-11 at 23:14 -0400, rir wrote:
> > On Sun, Oct 10, 2021 at 04:15:01PM -0400, rir wrote:
> > > On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> > > > On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> >
> >
On Mon, 2021-10-11 at 23:14 -0400, rir wrote:
> On Sun, Oct 10, 2021 at 04:15:01PM -0400, rir wrote:
> > On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> > > On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
>
> > > FETCH [ direction ] [ FROM | IN ] cursor_name
>
> Should the pgplsql
On Sun, Oct 10, 2021 at 04:15:01PM -0400, rir wrote:
> On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> > On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> > FETCH [ direction ] [ FROM | IN ] cursor_name
Should the pgplsql docs be similiarly changed per the above
in 43.7.3.1 and 2?
On Sun, 2021-10-10 at 16:15 -0400, rir wrote:
> On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> > On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
>
>
> > So I suggest that you change the syntax diagram to
> >
> > FETCH [ direction ] [ FROM | IN ] cursor_name
>
> > Then I agree
On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> So I suggest that you change the syntax diagram to
>
> FETCH [ direction ] [ FROM | IN ] cursor_name
> Then I agree that the "empty or" can be removed.
> I remain of the opinion that
rir writes:
> On Thu, Oct 07, 2021 at 04:24:16PM -0400, Tom Lane wrote:
>> BTW, as it stands, the diagram is ambiguous
>> because there are two ways to parse
>> FETCH cursor_name
>> ... is present but empty, or omitted altogether?
> I am confident you know what you mean, but I don't. At the
On Thu, Oct 07, 2021 at 04:24:16PM -0400, Tom Lane wrote:
> rir writes:
> > On Thu, Oct 07, 2021 at 07:58:47AM +0200, Laurenz Albe wrote:
> >> Can you think of a way to modify the syntax diagram so that it
> >> expresses that and still remains comprehensible?
>
> > For myself,
> >'FETCH [ [
On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> > > > - we should retain "empty or one of", otherwise the following syntax
> > > > would be undocumented:
>
> For myself,
>'FETCH [ [ FROM | IN ] ] '
> clearly indicates that 'direction' is optional.
Yes, but since [ FROM | IN ] is inside
rir writes:
> On Thu, Oct 07, 2021 at 07:58:47AM +0200, Laurenz Albe wrote:
>> Can you think of a way to modify the syntax diagram so that it
>> expresses that and still remains comprehensible?
> For myself,
>'FETCH [ [ FROM | IN ] ] '
> clearly indicates that 'direction' is optional.
On 2021-Oct-07, rir wrote:
> For myself,
>'FETCH [ [ FROM | IN ] ] '
> clearly indicates that 'direction' is optional.
Hmm, aren't you misreading the scope of the outer square brackets? If
is optional independently of [FROM|IN], then the synopsis
should be
FETCH [ ] [ FROM | IN ]
and
On Thu, Oct 07, 2021 at 07:58:47AM +0200, Laurenz Albe wrote:
> On Wed, 2021-10-06 at 23:39 -0400, rir wrote:
> > On Mon, Oct 04, 2021 at 08:18:22AM +0200, Laurenz Albe wrote:
> > > On Fri, 2021-10-01 at 21:06 -0400, rir wrote:
> > > > Minor changes to move.sgml and fetch.sgml.
> > > However, I
On Wed, 2021-10-06 at 23:39 -0400, rir wrote:
> On Mon, Oct 04, 2021 at 08:18:22AM +0200, Laurenz Albe wrote:
> > On Fri, 2021-10-01 at 21:06 -0400, rir wrote:
> > > Minor changes to move.sgml and fetch.sgml.
> > >
> > > The text 'or empty' is inconsistent by restating what the
> > > synopsis
On Mon, Oct 04, 2021 at 08:18:22AM +0200, Laurenz Albe wrote:
> On Fri, 2021-10-01 at 21:06 -0400, rir wrote:
> > Minor changes to move.sgml and fetch.sgml.
> >
> > The text 'or empty' is inconsistent by restating what the
> > synopsis notation has expressed.
> >
> > The comments on sharing a
On Fri, 2021-10-01 at 21:06 -0400, rir wrote:
> Minor changes to move.sgml and fetch.sgml.
>
> The text 'or empty' is inconsistent by restating what the
> synopsis notation has expressed.
>
> The comments on sharing a language feature, while
> likely helpful during review, seem verbose compared
Minor changes to move.sgml and fetch.sgml.
The text 'or empty' is inconsistent by restating what the
synopsis notation has expressed.
The comments on sharing a language feature, while
likely helpful during review, seem verbose compared to
the non-commenting in other similar files.
Thanks again,
16 matches
Mail list logo