Re: Use uppercase keywords in foreign key tutorial

2025-10-29 Thread Tom Lane
Bruce Momjian writes: > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote: >> I noticed the patch also changes some column types to lowercase: >> ... >> -category_N TEXT >> +category_N text >> >> FWIW I tend to use uppercase for those, too, but I'm not sure there is a >> pref

copy.sgml: add XML ID attributes to tags.

2025-10-29 Thread jian he
hi. similar to what we did in https://git.postgresql.org/cgit/postgresql.git/commit/?id=78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5 I happened to notice COPY.sgml Parameters section is un-linkable. The Parameters section in copy.sgml has shorter explanations compared to create_table.sgml, but it co

recovery_target_time format explanation should be clarified when using UTC zone

2025-10-29 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/18/index.html Description: We've been hitting a bug with PITR when specifying a recovery_target_time with an ISO 8601 format and UTC zone indicated with a trailing `Z`. We get an error like

Re: Use uppercase keywords in foreign key tutorial

2025-10-29 Thread David Rowley
On Thu, 30 Oct 2025 at 09:48, Tom Lane wrote: > > Bruce Momjian writes: > > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote: > >> I noticed the patch also changes some column types to lowercase: > >> ... > >> -category_N TEXT > >> +category_N text > >> > >> FWIW I tend to u

Re: Use uppercase keywords in foreign key tutorial

2025-10-29 Thread Bruce Momjian
On Thu, Oct 30, 2025 at 10:24:30AM +1300, David Rowley wrote: > On Thu, 30 Oct 2025 at 09:48, Tom Lane wrote: > > > > Bruce Momjian writes: > > > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote: > > >> I noticed the patch also changes some column types to lowercase: > > >> ... > >

Re: Use uppercase keywords in foreign key tutorial

2025-10-29 Thread Nathan Bossart
On Wed, Oct 29, 2025 at 05:25:43PM -0400, Bruce Momjian wrote: > On Thu, Oct 30, 2025 at 10:24:30AM +1300, David Rowley wrote: >> How about if Eric just drops the portion of the patch that alters the >> casing of the types and leaves all the keyword uppercasing stuff in. >> Any objections to that p

Re: Use uppercase keywords in foreign key tutorial

2025-10-29 Thread Bruce Momjian
On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote: > I noticed the patch also changes some column types to lowercase: > > > CREATE TYPE tablefunc_crosstab_N AS ( > -row_name TEXT, > -category_1 TEXT, > -category_2 TEXT, > +row_name text, > +category_1 text, > +