Re: Mention FK creation take ShareRowExclusiveLock on referenced table

2018-09-18 Thread Michael Paquier
On Tue, Sep 18, 2018 at 12:32:54PM +0200, Adrien NAYRAT wrote: > A few days ago I was surprised a CREATE TABLE containing FK constraint was > stuck due to an automatic vacuum freeze (which took ShareUpdateExclusiveLock > if I remember) on referenced table. Right. See the top of vacuum_rel()

Re: Ambiguity in restore_command for recovery.conf

2018-09-18 Thread Michael Paquier
On Tue, Sep 18, 2018 at 04:10:17PM +, PG Doc comments form wrote: > Documentation for restore_command in recovery.conf only says, "This > parameter is required for archive recovery, but optional for streaming > replication," but it doesn't say specifically when the restore_command > string

Ambiguity in restore_command for recovery.conf

2018-09-18 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/10/static/archive-recovery-settings.html Description: Documentation for restore_command in recovery.conf only says, "This parameter is required for archive recovery, but optional for

Mention FK creation take ShareRowExclusiveLock on referenced table

2018-09-18 Thread Adrien NAYRAT
Hello, A few days ago I was surprised a CREATE TABLE containing FK constraint was stuck due to an automatic vacuum freeze (which took ShareUpdateExclusiveLock if I remember) on referenced table. After digging into the code I found theses lines in tablecmds.c : /* * Grab