Re: [`] Paragraph doesn't match example in
On Sun, Aug 28, 2022 at 09:33:40PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/role-membership.html > Description: > > In § 22.3 there's a paragraph stating > > > Immediately after connecting as role joe, a database session will have use > of privileges granted directly to joe plus any privileges granted to admin, > because joe “inherits” admin's privileges. > > But in the code block directly presiding that paragraph contain the command > `CREATE ROLE admin NOINHERIT;`. Uh, the text says: NOINHERIT These clauses determine whether a role “inherits” the privileges of roles it is a member of. A role with the INHERIT attribute can automatically use whatever database privileges have been granted to all roles it is directly or indirectly a member of. Without INHERIT, membership in another role only grants the ability to SET ROLE to that other role; the privileges of the other role are only available after having done so. If not specified, INHERIT is the default. The controls whether the role being created inherits anything, not how role members behave. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson
Re: No backup history file found
On Fri, Aug 26, 2022 at 09:05:14AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/continuous-archiving.html > Description: > > Chapter 26.3.2. "Making a Base Backup" states that "To make use of the > backup, you will need to keep all the WAL segment files generated during and > after the file system backup. To aid you in doing this, the base backup > process creates a backup history file that is immediately stored into the > WAL archive area. This file is named after the first WAL segment file that > you need for the file system backup. For example, if the starting WAL file > is 0001123455CD the backup history file will be named something > like 0001123455CD.007C9330.backup." > > In my experience with pg_basebackup with tar format (-Ft) no backup history > file was produced. Instead I found first WAL segment name in "backup_label" > file inside of "base.tar" archive. Well, what happens is the the "backup_label" file is created in the WAL directory and that file gets backed up during the file system backup. That file will appear in the backup, like in the tar file. Can that text be improved? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson
Re: [PATCH] doc/queries.sgml: add missing comma
On Wed, Aug 24, 2022 at 07:58:04PM +0200, Peter Eisentraut wrote: > On 18.08.22 20:10, Bruce Momjian wrote: > > > Thus: > > > Strictly speaking, this process is iteration, but > > > RECURSIVE > > > is the terminology chosen by the SQL standards committee." > > > > > > Because the above sounds just fine, I'd argue that if one does leave "not > > > recursion" it should be set off by a comma. > > I went with new wording, which should make this even clearer; patch > > attached. > > I think this whole note is a bit misleading, like the SQL people don't know > what recursion is. The point is that the query is defined recursively. The > evaluation process is iterative. Those two are not contradictions. Okay, makes sense. Here is an updated patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson diff --git a/doc/src/sgml/queries.sgml b/doc/src/sgml/queries.sgml index 1428d99d0f..4c5a83c9cb 100644 --- a/doc/src/sgml/queries.sgml +++ b/doc/src/sgml/queries.sgml @@ -2172,9 +2172,8 @@ SELECT sum(n) FROM t; -Strictly speaking, this process is iteration not recursion, but -RECURSIVE is the terminology chosen by the SQL standards -committee. +While RECURSIVE allows queries to be specified +recursively, internally all queries are evaluated iteratively.
