Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread David G. Johnston
On Mon, Jul 17, 2023 at 7:45 PM Curt Kolovson wrote: > I’d vote for showing both (with RETURNING and without), since without it > the second argument to SPI_exec has no effect in this example, which may > not be obvious. That seems to be one of the subtle points illustrated by > this example. >

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread Curt Kolovson
I’d vote for showing both (with RETURNING and without), since without it the second argument to SPI_exec has no effect in this example, which may not be obvious. That seems to be one of the subtle points illustrated by this example. > On Jul 17, 2023, at 7:36 PM, Tom Lane wrote: > > "David

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread Tom Lane
"David G. Johnston" writes: > On Mon, Jul 17, 2023 at 6:22 PM Tom Lane wrote: >> I think his point is that this example does not behave as the >> documentation claims. Which it does not, according to my >> tests here. I find this a bit disturbing --- did we intentionally >> change the behavior

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread David G. Johnston
On Mon, Jul 17, 2023 at 6:22 PM Tom Lane wrote: > "David G. Johnston" writes: > > On Mon, Jul 17, 2023 at 4:53 PM Curt Kolovson > wrote: > >> The actual results (shown below) are different than shown on this doc > >> page. > > > SPI_exec sees "INSERT 0 2" as the command tag from the SQL

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread Curt Kolovson
Tom is correct. It appears that nobody tested this example, which by the way seems unnecessarily complicated. Sent from my iPhone > On Jul 17, 2023, at 6:22 PM, Tom Lane wrote: > > "David G. Johnston" writes: >>> On Mon, Jul 17, 2023 at 4:53 PM Curt Kolovson wrote: >>> The actual results

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread Tom Lane
"David G. Johnston" writes: > On Mon, Jul 17, 2023 at 4:53 PM Curt Kolovson wrote: >> The actual results (shown below) are different than shown on this doc >> page. > SPI_exec sees "INSERT 0 2" as the command tag from the SQL command you > passed and so 2 is the output of the execq function

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread jian he
On Tue, Jul 18, 2023 at 8:26 AM David G. Johnston wrote: > > No INFO messages appear because you did not include a returning clause. The > 1 you passed to the call is immaterial if the query you supply doesn't > produce a result set. > > David J. > indeed.

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread David G. Johnston
On Mon, Jul 17, 2023 at 4:53 PM Curt Kolovson wrote: > The actual results (shown below) are different than shown on this doc > page. The reason is because the second parameter to the UDF that is > passed to SPI_exec is the maximum number of rows to return, or 0 for > no limit. It is not the

Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread Curt Kolovson
The actual results (shown below) are different than shown on this doc page. The reason is because the second parameter to the UDF that is passed to SPI_exec is the maximum number of rows to return, or 0 for no limit. It is not the maximum number of rows to process. In the case of "SELECT

Re: Improvement of clarity in pg_ctl command docummentation

2023-07-17 Thread Michael Paquier
On Sat, Jul 15, 2023 at 05:57:40AM +, PG Doc comments form wrote: > I was reading the documentation about pg_ctl and there everything was well > written about the usage and option that can be used with the pg_ctl command > but there is not mentioned that we can not run pg_ctl command as root