Re: Minipatch concerning tags + new spelling/punctuation patch

2023-10-24 Thread Michael Paquier
On Mon, Oct 23, 2023 at 12:33:03PM +0300, Maxim Yablokov wrote: > We have also prepared a small patch concerning spelling, punctuation, etc. > We've decided to send it separately, so it'll be easier to review. Please > have a look. Yep, these are improvements. So applied and backpatched (all

Re: Getting started

2023-10-24 Thread Bruce Momjian
xOn Mon, Dec 12, 2022 at 08:20:03AM +0100, Laurenz Albe wrote: > On Sat, 2022-12-10 at 18:46 +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/15/user-manag.html > > Description: > > > >

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have developed the attached patch to document this. > > This seems a little imprecise: > > + Values with non-alphanumeric characters must be quoted. > > I think accurate is more like "Values that are

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Tom Lane
Bruce Momjian writes: > I have developed the attached patch to document this. This seems a little imprecise: + Values with non-alphanumeric characters must be quoted. I think accurate is more like "Values that are neither a number nor a valid identifier must be quoted." Also, that para

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
On Thu, Dec 15, 2022 at 12:10:27PM -0500, Tom Lane wrote: > "Jonathan S. Katz" writes: > > On 12/15/22 10:50 AM, David G. Johnston wrote: > >> I suggest changing it to: > >> SET configuration_parameter { TO | = } { value [, ...] | DEFAULT } > > > +1 in general. I would also suggest we add an

Wrong link in the documentation for versions 11, 12

2023-10-24 Thread Maxim Yablokov
Hello! Our team have noticed that the link in the field "References" for data_type on the following pages (https://www.postgresql.org/docs/12/view-pg-sequences.html, https://www.postgresql.org/docs/11/view-pg-sequences.html) is incorrect, so I've fixed it. Patches are attached, please have a

Re: 48.1. Logical Decoding Examples

2023-10-24 Thread Kevin Wang
In my testing environment, I did not specify "shared_preload_libraries" and I cannot create the logical replication slot with the "test_decoding" type. test_decoding is in contrib folder and is not build-in, so if you do not specify it, you cannot create the replication slot. On Mon, Oct 23, 2023