Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a Summary Table

2023-10-27 Thread Tom Lane
Daniel Gustafsson writes: > Thanks, I'll await pushing and backpatching if Tom who committed it has > insights into whether it was missed or if it indeed serves a purpose. Hey, I just pushed that for somebody else, I don't claim authorship ;-) It seems clear that the example intends to show a

Re: Typo in docs for "recovery_init_sync_method" parameter.

2023-10-27 Thread Bruce Momjian
On Tue, Aug 23, 2022 at 02:38:13PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/runtime-config-error-handling.html > Description: > > The second paragraph contains the sentence: > > >

Re: Minor inconsistencies

2023-10-27 Thread Bruce Momjian
On Sun, Nov 6, 2022 at 04:16:07PM +0200, Ekaterina Kiryanova wrote: > Hello! > > I've prepared another patch, which contains the previous corrections and > some new found ones concerning upper/lower case letters, misplaced periods > and missing tags. > Please review. I liked all these

Re: [very minor] Documentation suggestion

2023-10-27 Thread Bruce Momjian
On Fri, Oct 21, 2022 at 02:19:12AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/logicaldecoding-synchronous.html > Description: > > Very minor suggestion. Earlier on this page, commands are

Re: First Person (I) Should be avoided

2023-10-27 Thread Bruce Momjian
On Fri, Oct 28, 2022 at 02:56:59AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/oid2name.html > Description: > > This feels a little nit-picky. > > In the Examples > $ # I wonder what file

Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a Summary Table

2023-10-27 Thread Daniel Gustafsson
> On 26 Oct 2023, at 12:31, Maxim Yablokov wrote: > > I believe that the attached patch should fix this problem. Please have a look. Thanks, I'll await pushing and backpatching if Tom who committed it has insights into whether it was missed or if it indeed serves a purpose. If not I think it