Re: Incorrect/confusing information about timetz

2023-09-07 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 04:41:48PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Uh, yes to the storage part, no to the output part. ;-) Postgres does > > store the timetz time zone offset, but it doesn't adust it once it is > > stored so doesn't adjust for

Re: Incorrect/confusing information about timetz

2023-09-07 Thread Bruce Momjian
zone, in seconds */ } TimeTzADT; Do we want to document this? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Cross-Product JOIN?

2023-09-07 Thread Bruce Momjian
ften in the > > documentation > > overall. > > > > But the same page [0] also uses cross product when talking about grouping > > sets. > > > > [0] https://www.postgresql.org/docs/15/queries-table-expressions.html > > Here's a patch that fixes those two

Re: pg_class.relpages documentation does not mention relpages corner case

2023-09-07 Thread Bruce Momjian
age-id/20230112232747.GA2111950@nathanxps13 If we set the relpages to zero, that would not be reflecting the partitions. I feel -1 is probably the best unless we want to put the total of all partitions in there, but that would be confusing too. -- Bruce Momjian https://momji

Re: group by can use alias from select list

2023-09-07 Thread Bruce Momjian
On Wed, Sep 6, 2023 at 08:01:30PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jul 11, 2023 at 07:31:26AM -0700, David G. Johnston wrote: > >> I think the complaint is that someone seeing the behavior in the wild > >> comes to > >> this

Re: group by can use alias from select list

2023-09-06 Thread Bruce Momjian
nt if we really want the order of operations to be the main > reference entry point for people trying to work out query behavior.  Something > like:  "(while unadvised it is possible for the aliases defined in the next > step to be used here as well)". How is the attached patch? --

Re: to_char(numeric type, text) rounding instead of truncating

2023-09-06 Thread Bruce Momjian
1235::real)*100,'90D0%') > > The output becomes 99.8% > > > > It would be nice to have this behavior explained in the documentation so > > people get more predictable results. > > +1 > > How about the following: I slightly modified your patch and applied

Re: Replica vs standby

2023-09-06 Thread Bruce Momjian
On Wed, Sep 6, 2023 at 09:02:02AM +0200, Peter Eisentraut wrote: > On 06.09.23 03:42, Bruce Momjian wrote: > > There are other cases in our docs where we call something a standby and > > mean only a physical standby/replica. Should these be clarified? > > When "hot st

Replica vs standby

2023-09-05 Thread Bruce Momjian
adds it) was EOL more than 9 months ago. > > > [1] https://www.postgresql.org/docs/current/glossary.html > [2] https://www.postgresql.org/docs/current/logical-replication-config.html > [3] https://www.postgresql.org/docs/current/runtime-config-replication.html > > > -- > Euler Taveira > EDB https://www.enterprisedb.com/ > -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Include rust as an externally maintained procedural language

2023-08-12 Thread Bruce Momjian
is thread[1], I wonder if we just link to the wiki from the > documentation, given it will be easier to maintain the list from there. Makes sense. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Change "two" to "three" for decades of development in history

2023-06-23 Thread Bruce Momjian
hanging this. > > +1. With the proposed language, we can revisit it once it gets to > "centuries." Applied patch is "With decades of development". -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: bad choice of the word in sentence

2023-06-23 Thread Bruce Momjian
On Fri, Jun 23, 2023 at 09:16:39PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Thu, Jun 22, 2023 at 06:38:37PM +, PG Doc comments form wrote: > >> Quote: > >> "<...>When a transaction uses this isolation level, a SELECT query (without > >

Re: bad choice of the word in sentence

2023-06-23 Thread Bruce Momjian
lt;...>Also note that two successive SELECT commands can see different data, > even though they are within a single transaction, if other transactions > commit changes after the first SELECT starts and before the second SELECT > starts. <...>" >

Re: Change "two" to "three" for decades of development in history

2023-06-22 Thread Bruce Momjian
e DocBook has macro and system-variable capabilities? That could > provide a set-and-forget solution to this? Uh, I am not aware of any. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Change "two" to "three" for decades of development in history

2023-06-21 Thread Bruce Momjian
totally_ correct. Attached patch applied back to PG 11. Seems we will need to change this to "four" in a few years too. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. com

Re: [PATCH] two minor fixes to MVCC docs

2023-06-20 Thread Bruce Momjian
gt; (SELECT, INSERT, > - UPDATE, or DELETE), so > - it is possible to obtain locks explicitly before the snapshot is > - frozen. > + UPDATE, DELETE, or > + MERGE), so it is possible to obtain locks explicitly > + before the snapshot is frozen. > > > > -- > 2.25.1 > -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: PostgreSQL 16 release notes: could cloud

2023-06-05 Thread Bruce Momjian
On Mon, Jun 5, 2023 at 07:12:35PM +0200, Erik Rijkers wrote: > Op 6/5/23 om 17:44 schreef Bruce Momjian: > > On Mon, Jun 5, 2023 at 08:26:07AM +, Daniel Westermann (DWE) wrote: > > > > > > > I guess one "could" should be enough? > > > &g

Re: PostgreSQL 16 release notes: could cloud

2023-06-05 Thread Bruce Momjian
of the release notes on the community website are unchanged since beta1 was packaged; please see the current contents here: https://momjian.us/pgsql_docs/release-16.html -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: I think that the transaction tutorial document (3.4) should mention transaction isolation

2023-03-29 Thread Bruce Momjian
nd referring to the more details > document, would help users prevent consistency bugs. Well, the point is that the application is _not_ retrieving a value and setting is +100, but rather having the SQL add 100, which is kind of the point. I don't think a tutorial should get into more details t

Re: Suggestion for deprecated spellings

2023-01-30 Thread Bruce Momjian
On Mon, Jan 30, 2023 at 04:07:46PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Thu, Jan 26, 2023 at 12:19:29PM +, PG Doc comments form wrote: > >> From time to time some spelling for given command gets obsolete, yet it is > >> shown in the syntax on &q

Re: Suggestion for deprecated spellings

2023-01-30 Thread Bruce Momjian
On Mon, Jan 30, 2023 at 09:52:15PM +0100, Tomisław Kityński wrote: > W dniu 30.01.2023 o 21:39, Bruce Momjian pisze: > > On Thu, Jan 26, 2023 at 12:19:29PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: &g

Re: Suggestion for deprecated spellings

2023-01-30 Thread Bruce Momjian
taxes in the "Synopsis" section, so we could just remove them. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: broken link

2023-01-18 Thread Bruce Momjian
link at the > very bottom: "Bruce Momjian's presentation" > http://momjian.us/main/presentations/features.html#securing URL fixed to https://momjian.us/main/presentations/administration.html#securing, though it feels the item was just appened to the FAQ. -- Bruce Momjian

Re: temporary file size clarification

2022-11-25 Thread Bruce Momjian
On Thu, Nov 24, 2022 at 10:14:20AM +0100, Daniel Gustafsson wrote: > > On 23 Nov 2022, at 20:43, Bruce Momjian wrote: > > > > On Wed, Nov 16, 2022 at 10:26:38AM +, PG Doc comments form wrote: > >> The following documentation comment has been logged on the webs

Re: temporary file size clarification

2022-11-23 Thread Bruce Momjian
ne is something like "profiles@profiles LOG: > temporary file: path "base/pgsql_tmp/pgsql_tmp31863.1", size 3137536" but > there is no size unit in the logfile or in the settings documentation. Can > you add whether the log line is in bytes/kilobytes/megabytes? Uh, I believe

Re: Possibly Incorrect Data Return

2022-11-23 Thread Bruce Momjian
(IMO anyway). This example originally introduced only HAVING, and > trying to make it do double duty just confuses things. A fully > separate example of FILTER would have served better. > > I'll go do something about that --- thanks for the report! Sorry, that was me, and I tho

Re: crosstab documentation should add a note about use in materialized views

2022-11-22 Thread Bruce Momjian
pecifies queries as strings, and a materialized view has to run the query during restore to populate the materialized view. Is this the only combination of pg_dump restore breakage? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecisi

Re: nextval parameter is not clear

2022-11-22 Thread Bruce Momjian
r, since the regclass data type's input converter will do the work for you. See Section 8.19 for details. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: JSON/JSONB documentation, aggregate functions

2022-10-17 Thread Bruce Momjian
On Tue, Oct 11, 2022 at 11:48:21AM -0400, Bruce Momjian wrote: > On Fri, Sep 16, 2022 at 08:08:04PM +, PG Doc comments form wrote: > > Regarding the Json documentation (9.16.1: processing and creating JSON > > data), I would like to suggest that the reference to > &g

Re: COALESCE could use some better examples

2022-10-13 Thread Bruce Momjian
ll NULL, go to th next parameter. All WHERE functions are row-based so I don't see how to actually improve our doc text without making it more confusing. Sorry. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: JSON/JSONB documentation, aggregate functions

2022-10-11 Thread Bruce Momjian
attached patch moves the paragraph up to the end of the section's introductory paragraph. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson diff --git a/doc/s

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-10-07 Thread Bruce Momjian
f3() did not have explicitly set search path.*/ > > I see now that there are multiple reasons why to still use search path. I > agree > now that this extra paragaraph is perhaps too confusing and is not needed. Thanks. I learned a few things in this discussion and we can revisit it if we feel the

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-10-07 Thread Bruce Momjian
I am not sure adding the reasons for _why_ you should use search path for SQL-standard bodies is really adding anything. Noah, is that accurate? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: request clarification on pg_restore documentation

2022-10-06 Thread Bruce Momjian
orical way" or they are aimed at different types of use cases, > but that's not clear. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: Minor documentation fixes

2022-10-05 Thread Bruce Momjian
but the skipped the one that removed the "that" since I was told not to use "that" when it isn't needed. Thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: Minor documentation fixes

2022-10-05 Thread Bruce Momjian
his item. You are correct this needs fixing and I have applied this to master and PG 15. I will send a separate email about the release note changes. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: Developer FAQ Dead Link

2022-09-28 Thread Bruce Momjian
k is 404 now) > * http://www.contrib.andrew.cmu.edu/~shadow/sql.html#syntax (SQL-92) (This > link > is 404 now) > * http://dbs.uni-leipzig.de/en/lokal/standards.pdf (paper) (This link will be > redirected to other page) Thanks, URLs removed. It is good we have some valid URLs. -- Bruc

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-09-28 Thread Bruce Momjian
On Tue, Aug 16, 2022 at 03:32:36PM -0400, Bruce Momjian wrote: > On Sat, Dec 25, 2021 at 02:36:27PM +, Erki Eessaar wrote: > > > > Hello > > > > PostgreSQL 14 added the feature: "Allow SQL-language functions and > > procedures > > to use

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-09-28 Thread Bruce Momjian
On Sun, Sep 11, 2022 at 09:46:47PM -0700, Noah Misch wrote: > On Thu, Sep 08, 2022 at 01:20:31PM +0200, Peter Eisentraut wrote: > > On 01.09.22 03:11, Bruce Momjian wrote: > > >On Tue, Aug 16, 2022 at 03:38:13PM -0400, Bruce Momjian wrote: > > >>On Tue, Aug 16, 2022

Re: DocBook 5.2

2022-09-26 Thread Bruce Momjian
On Mon, Sep 26, 2022 at 05:42:32PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Mon, Sep 5, 2022 at 01:15:08PM +0200, Álvaro Herrera wrote: > >> OK, these seem quite significant changes that are likely to cause great > >> pain. So I repeat my question, what

Re: pg_dump: regular expression notation for tables

2022-09-26 Thread Bruce Momjian
ed, but simply some sort of glob > expression? The pg_dump documentation says "(see Patterns below)" in several places, and that link points to: https://www.postgresql.org/docs/15/app-psql.html#APP-PSQL-PATTERNS -- Bruce Momjian https://momjian.us EDB

Re: DocBook 5.2

2022-09-26 Thread Bruce Momjian
, what are the benefits of making this > change? They better be very very substantial. Would we be converting docs for all supported versions of Postgres to use DocBook 5.2, or just the most current version? If the later, we would find backpatching a pain for five years. -- Bruce Momji

Re: Duplicate text in ANALYZE related to inheritance/parents

2022-09-02 Thread Bruce Momjian
On Wed, Aug 31, 2022 at 11:43:30PM -0400, Bruce Momjian wrote: > I noticed that our ANALYZE documentation has confusing duplicate text > related to the analyzing of inheritance trees. This patch fixes it. Patch applied back to PG 10. -- Bruce Momjian https://momjian.us

Re: [PATCH] doc/queries.sgml: add missing comma

2022-09-02 Thread Bruce Momjian
On Tue, Aug 30, 2022 at 02:18:42PM -0400, Bruce Momjian wrote: > On Wed, Aug 24, 2022 at 07:58:04PM +0200, Peter Eisentraut wrote: > > On 18.08.22 20:10, Bruce Momjian wrote: > > > > Thus: > > > > Strictly speaking, this process is iteration, but > > &

Re: CREATE STATISTICS and partitoins/inheritance

2022-09-01 Thread Bruce Momjian
On Thu, Sep 1, 2022 at 12:04:43AM -0500, Justin Pryzby wrote: > On Wed, Aug 31, 2022 at 11:15:41PM -0400, Bruce Momjian wrote: > > On Wed, Aug 17, 2022 at 03:30:11PM -0400, Bruce Momjian wrote: > > > In looking at CREATE STATISTICS, I was confused how inheritance and > > &

Duplicate text in ANALYZE related to inheritance/parents

2022-08-31 Thread Bruce Momjian
I noticed that our ANALYZE documentation has confusing duplicate text related to the analyzing of inheritance trees. This patch fixes it. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction

Re: CREATE STATISTICS and partitoins/inheritance

2022-08-31 Thread Bruce Momjian
On Wed, Aug 17, 2022 at 03:30:11PM -0400, Bruce Momjian wrote: > In looking at CREATE STATISTICS, I was confused how inheritance and > partisions were handled, so I confirmed with Tomas that the ANALYZE > manual page accurately describes how extended statistics are handled > since PG 1

Re: CREATE INDEX...USING

2022-08-31 Thread Bruce Momjian
On Thu, Aug 18, 2022 at 12:32:28PM -0400, Bruce Momjian wrote: > On Wed, Aug 17, 2022 at 11:21:58PM -0400, Bruce Momjian wrote: > > However, CREATE INDEX just lists the parameters, not the keywords, so it > > was already there as 'method', as you mentioned above. I will just >

Re: nicer examples for aggregate calls

2022-08-31 Thread Bruce Momjian
On Wed, Aug 17, 2022 at 12:20:10PM -0400, Bruce Momjian wrote: > On Sat, Oct 23, 2021 at 01:51:48PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/14/tutorial-agg

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-08-31 Thread Bruce Momjian
On Tue, Aug 16, 2022 at 03:38:13PM -0400, Bruce Momjian wrote: > On Tue, Aug 16, 2022 at 03:34:22PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I have written the attached patch to mention this issue about sql_body > > > functions. > > > > S

Re: set time zone

2022-08-31 Thread Bruce Momjian
On Tue, Aug 16, 2022 at 08:41:05PM -0400, Bruce Momjian wrote: > On Tue, Dec 7, 2021 at 02:28:09PM +, PG Doc comments form wrote: > > TIME ZONE > > SET TIME ZONE timezone_name is an alias for SET timezone TO timezone_name. > > I ended up changing the syntax from

Re: [`] Paragraph doesn't match example in

2022-08-30 Thread Bruce Momjian
ied, INHERIT is the default. The controls whether the role being created inherits anything, not how role members behave. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: No backup history file found

2022-08-30 Thread Bruce Momjian
nd that file gets backed up during the file system backup. That file will appear in the backup, like in the tar file. Can that text be improved? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: [PATCH] doc/queries.sgml: add missing comma

2022-08-30 Thread Bruce Momjian
On Wed, Aug 24, 2022 at 07:58:04PM +0200, Peter Eisentraut wrote: > On 18.08.22 20:10, Bruce Momjian wrote: > > > Thus: > > > Strictly speaking, this process is iteration, but > > > RECURSIVE > > > is the terminology chosen by the SQL standards committee.

Re: relpages in pg_class

2022-08-19 Thread Bruce Momjian
ormat (i.e. line pointer array indirection). Yes, I have heard the block-disk, page-memory explanation before. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: relpages in pg_class

2022-08-19 Thread Bruce Momjian
e number of blocks. But, at the document, > it is written as Size of the on-disk representation of this table in pages > (of size BLCKSZ). Well, blocks and pages are the same size, so I don't see the problem. -- Bruce Momjian https://momjian.us EDB

Re: [PATCH] doc/queries.sgml: add missing comma

2022-08-18 Thread Bruce Momjian
make much difference. > > Thus: > Strictly speaking, this process is iteration, but RECURSIVE > is the terminology chosen by the SQL standards committee." > > Because the above sounds just fine, I'd argue that if one does leave "not

Re: max_sync_workers_per_subscription

2022-08-18 Thread Bruce Momjian
On Tue, Oct 26, 2021 at 11:06:26AM -0400, Bruce Momjian wrote: > On Tue, Oct 19, 2021 at 08:59:08AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/13/logical-re

Re: CREATE INDEX...USING

2022-08-18 Thread Bruce Momjian
On Wed, Aug 17, 2022 at 11:21:58PM -0400, Bruce Momjian wrote: > On Wed, Aug 17, 2022 at 05:11:23PM -0400, Jeff Janes wrote: > > That looks good to me.  But now looking over the linked pages more, it seems > > like https://www.postgresql.org/docs/current/indexes-types.html was ne

Re: CREATE INDEX...USING

2022-08-17 Thread Bruce Momjian
NG in the CREATE INDEX docs, and I didn't see it either, so I added it. However, CREATE INDEX just lists the parameters, not the keywords, so it was already there as 'method', as you mentioned above. I will just remove the USING section I recently added. -- Bruce Momjian

Re: Update documentation page for translators

2022-08-17 Thread Bruce Momjian
On Wed, Aug 17, 2022 at 10:58:55PM +0200, Daniel Gustafsson wrote: > > On 17 Aug 2022, at 22:56, Bruce Momjian wrote: > > > Is there a reason this patch was not applied? > > Only that it fell of my radar, if you think it's adding value I'm happy to get > it done now.

Re: Update documentation page for translators

2022-08-17 Thread Bruce Momjian
e the area between the quotes after > the msgstr directive, add comments, and alter the fuzzy flag. > There is (unsurprisingly) a PO mode for Emacs, which I find quite -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: documentation describing the range of a number type 'integer' is incorrect

2022-08-17 Thread Bruce Momjian
it compares to -INT_MAX instead of > INT_MIN or > (-INT_MAX - 1). This goes back to the initial commit in the git repo > for > src/interfaces/ecpg/pgtypeslib/numeric.c. And doc/src/sgml/ecpg.sgml > documents the min being -INT_MAX. > > This sounds li

CREATE STATISTICS and partitoins/inheritance

2022-08-17 Thread Bruce Momjian
In looking at CREATE STATISTICS, I was confused how inheritance and partisions were handled, so I confirmed with Tomas that the ANALYZE manual page accurately describes how extended statistics are handled since PG 15, so I plan to apply this patch to the CREATE STATISTICS docs. -- Bruce

Re: CREATE INDEX...USING

2022-08-17 Thread Bruce Momjian
de/catalog/index.h: #define DEFAULT_INDEX_TYPE "btree" Patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson diff --git a/doc/src

Re: nicer examples for aggregate calls

2022-08-17 Thread Bruce Momjian
-- (1) > GROUP BY city > HAVING max(temp_lo) < 40; Good idea. We didn't support FILTER at the time this query was added. Here is a patch which adds it. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecisio

Re: Empty values of pg_stats_ext when table is empty

2022-08-17 Thread Bruce Momjian
resql.org/docs/15/release-15.html Allow extended statistics to record statistics for a parent with all its children (Tomas Vondra, Justin Pryzby) Regular statistics already tracked parent and parent/all-children statistics separately. -- Bruce Momjia

Re: set time zone

2022-08-16 Thread Bruce Momjian
figuration_parameter { TO | = } { value | 'value' > | DEFAULT } > SET [ SESSION | LOCAL ] TIME ZONE { timezone_name | LOCAL | DEFAULT } > > and the lower section to read: > > TIME ZONE > SET TIME ZONE timezone_name is an alias for SET timezone TO timezone_name

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-08-16 Thread Bruce Momjian
On Tue, Aug 16, 2022 at 03:34:22PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have written the attached patch to mention this issue about sql_body > > functions. > > Spell-check, please. Seems OK otherwise. Just when I think I didn't add enough text to

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-08-16 Thread Bruce Momjian
10.3.. Two functions are considered the same if they have the same >... >www.postgresql.org I have written the attached patch to mention this issue about sql_body functions. -- Bruce Momjian https://momjian.us EDB https://ent

Re: Question about role attributes docs

2022-08-12 Thread Bruce Momjian
tch! > Thank you for the review! Patch applied back to PG 10. Commitfest status updated. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

Re: documentation on HOT

2022-08-12 Thread Bruce Momjian
On Tue, Jul 26, 2022 at 07:29:10PM -0400, Bruce Momjian wrote: > > Summary paragraph: > > "can only happen if" => "can only be created if" > > Yes, good point. > > Updated patch attached. I applied this patch back to PG 11. (PG 10 had too man

Re: gettext instructions for Windows seems wrong

2022-08-12 Thread Bruce Momjian
On Fri, Jul 22, 2022 at 10:32:42AM -0400, Bruce Momjian wrote: > On Wed, Jan 19, 2022 at 10:24:57AM +0100, Daniel Gustafsson wrote: > > > On 17 Jan 2022, at 23:55, PG Doc comments form > > > wrote: > > > > > The instructions say that I have to edit config

Re: CREATE INDEX USING documentation

2022-08-12 Thread Bruce Momjian
On Sat, Jul 23, 2022 at 12:46:31PM -0400, Bruce Momjian wrote: > On Sat, Jan 15, 2022 at 11:01:58PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/14/sql-createindex

Re: CREATE TABLE AS, section IF NOT EXISTS should clarify what happens to the data

2022-08-12 Thread Bruce Momjian
On Mon, Jul 18, 2022 at 03:43:03PM -0400, Bruce Momjian wrote: > fOn Thu, Jul 14, 2022 at 06:47:19PM -0700, David G. Johnston wrote: > > Not only is the existing table not modified, I think that the select query > > portion of the command is never even executed.  That would se

Re: documentation on HOT

2022-07-26 Thread Bruce Momjian
rmance Tips" under > "Avoid > Unnecessary Indexes" (yes, a bit of a stretch, but nothing else seems to fit > better, except maybe in concurrency control since we are discussing overcoming > the limitation of our concurrency control choice. Uh, not sure. Anyone else have an opi

Re: documentation on HOT

2022-07-26 Thread Bruce Momjian
On Sat, Jul 23, 2022 at 11:33:40AM -0700, Peter Geoghegan wrote: > On Sat, Jul 23, 2022 at 8:51 AM Bruce Momjian wrote: > > Good points. I have updated the attached patch and URL to mention that > > HOT rows are _completely_ removed, and why that is possible, and I > > cl

Re: CREATE INDEX USING documentation

2022-07-23 Thread Bruce Momjian
tibility stuff as operational, meaning it appears in the command manual page but not necessarily in the main docs. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson di

Re: documentation on HOT

2022-07-23 Thread Bruce Momjian
On Fri, Jul 22, 2022 at 03:33:20PM -0700, Peter Geoghegan wrote: > On Fri, Jul 22, 2022 at 2:11 PM Bruce Momjian wrote: > > I have improved the wording of the last paragraph in this patch. > > I think that it would be worth prominently explaining where heap-only > tuples g

Re: documentation on HOT

2022-07-22 Thread Bruce Momjian
On Fri, Jul 22, 2022 at 01:07:41PM -0400, Bruce Momjian wrote: > > > You can increase the change of HOT updates by using non-default table > > fillfactor settings. > > > > I think we should expand on this and explain how adjusting "fillfactor" will >

Re: documentation on HOT

2022-07-22 Thread Bruce Momjian
is a section about bottom-up index deletion in the docs (in the > B-Tree internals chapter) that already references HOT. It should link > to this new chapter now, I think. Already done in the attached patch, I think. -- Bruce Momjian https://momjian.us EDB

Re: documentation on HOT

2022-07-22 Thread Bruce Momjian
performing > an update.  In a case of giving things obvious and meaningful names, this is > the Heap-Only Tuple (HOT) Optimization.  This optimization is possible when:" Sorry, I don't like the above since it isn't precise and the "In a case of giving things obvious and meaningful

Re: documentation on HOT

2022-07-22 Thread Bruce Momjian
On Fri, Jul 22, 2022 at 11:09:49AM -0400, Jonathan Katz wrote: > On 7/22/22 8:51 AM, Bruce Momjian wrote: > > URL contents updated too: > > > > https://momjian.us/tmp/pgsql/storage-hot.html > > Thanks! This is great. Probably the most concise and clear explan

Re: gettext instructions for Windows seems wrong

2022-07-22 Thread Bruce Momjian
on Windows, but regardless of doc updates for > this I think we should clarify that config.pl may not exist, like how we do > for > buildenv.pl. Good point --- I have developed the attached patch to implement this. -- Bruce Momjian https://momjian.us EDB

Re: documentation on HOT

2022-07-22 Thread Bruce Momjian
On Thu, Jul 21, 2022 at 10:02:18PM -0400, Bruce Momjian wrote: > On Sun, Feb 6, 2022 at 09:29:56PM -0500, Jonathan Katz wrote: > > I agree with Bruce's point that we should have a new section (or > > subsection). As I mentioned in my previous post, given HOT involves > > inde

Re: documentation on HOT

2022-07-21 Thread Bruce Momjian
.us/tmp/pgsql/storage-hot.html -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson diff --git a/doc/src/sgml/acronyms.sgml b/doc/src/sgml/acronyms.sgml index 9ed148ab

Re: "Restore" vs. "Reload"

2022-07-21 Thread Bruce Momjian
On Thu, Jul 14, 2022 at 07:42:43PM -0400, Bruce Momjian wrote: > On Wed, Mar 16, 2022 at 09:28:04AM +0100, Laurenz Albe wrote: > > On Tue, 2022-03-15 at 16:12 +, PG Doc comments form wrote: > > > Page: https://www.postgresql.org/docs/14/backup-dump.html > > >

Re: Documentation Suggestion

2022-07-21 Thread Bruce Momjian
On Thu, Jul 21, 2022 at 08:05:49PM +0200, Álvaro Herrera wrote: > On 2022-Jul-21, Bruce Momjian wrote: > > > Patch applied to all supported branches. > > Thanks, looks good. > > I notice you credited me as the reporter, but actually the reporter is > jheb...@micron

Re: Documentation Suggestion

2022-07-21 Thread Bruce Momjian
On Thu, Jul 14, 2022 at 06:23:43PM -0400, Bruce Momjian wrote: > On Tue, May 24, 2022 at 08:36:18AM -0400, Bruce Momjian wrote: > > fOn Sat, May 14, 2022 at 05:21:58PM +0200, Álvaro Herrera wrote: > > > On 2022-May-13, Bruce Momjian wrote: > > > > Note t

Re: huge_page_size parameter description in the pg 14 docs is not exact

2022-07-20 Thread Bruce Momjian
uge_page_size parameter ,PG14 can start 。 The paragraph begins with: Some commonly available page sizes on modern 64 bit server architectures include: which seems sufficient to suggest that all listed sizes might not be supported on all operating systems, and this is only support

Re: CREATE TABLE AS, section IF NOT EXISTS should clarify what happens to the data

2022-07-18 Thread Bruce Momjian
t; as implying that nothing else happens, which I considered sufficient. > > I've removed the xref to create table as there is nothing additional there of > material benefit - the sentence: Okay, removed. Updated patch attached. -- Bruce Momjian https://momjian.us EDB

Re: CREATE TABLE AS, section IF NOT EXISTS should clarify what happens to the data

2022-07-14 Thread Bruce Momjian
EXISTS table_name AS, and the > table exists already, I get a NOTICE instead of an ERROR. > > I wanted to have it clarified explicitly that the data from the SELECT > statement is ignored in this case. Good point. Attached is a documentation patch to clarify this. -- Bruce Momjian

Re: "Restore" vs. "Reload"

2022-07-14 Thread Bruce Momjian
e" is better. > > Do you feel like preparing a patch? I have created the attached patch. The only place I left "reload" was when it was used in pg_dump in "To reload an archive file" and similar cases. In those cases, restoring a script or file might be

Re: Documentation Suggestion

2022-07-14 Thread Bruce Momjian
On Tue, May 24, 2022 at 08:36:18AM -0400, Bruce Momjian wrote: > fOn Sat, May 14, 2022 at 05:21:58PM +0200, Álvaro Herrera wrote: > > On 2022-May-13, Bruce Momjian wrote: > > > Note that valid --auth option values are all lower case, even > > > for authentication

Re: Fwd: Adding more detail to pg_upgrade documentation

2022-07-14 Thread Bruce Momjian
On Sat, Jul 9, 2022 at 10:38:30PM -0400, Bruce Momjian wrote: > > (source: https://www.postgresql.org/docs/devel/pgupgrade.html) > > > > I'm a new contributor so please forgive me if I'm on the wrong track, > > but if you follow this step, won't you also be e

Re: No documentation exists about ecpg ORACLE comptaible mode

2022-07-14 Thread 'Bruce Momjian'
On Thu, Jul 14, 2022 at 02:41:45AM +, ideriha.take...@fujitsu.com wrote: > Bruce Momjian wrote: > > > This is a very good point. I have studied the issue and created the > > attached patch to document Oracle-compatibility mode. > > Hi Bruce, thank you for writing t

Re: How to reference the type of lock in the documentation.

2022-07-14 Thread Bruce Momjian
On Mon, Jul 11, 2022 at 06:50:30PM -0500, Troy Frericks wrote: > > Looks awesome! Patch applied to all supported versions --- thanks for your report. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a de

Re: No documentation exists about ecpg ORACLE comptaible mode

2022-07-12 Thread Bruce Momjian
On Tue, Jul 12, 2022 at 10:20:08AM +0200, Michael Meskes wrote: > On Sat, Jul 09, 2022 at 09:15:52PM -0400, Bruce Momjian wrote: > > This is a very good point. I have studied the issue and created the > > attached patch to document Oracle-compatibility mode. > > ... > &g

Re: Fwd: Adding more detail to pg_upgrade documentation

2022-07-09 Thread Bruce Momjian
t; clusters are in sync with the primary cluster? Please let me know if I'm > missing anything! I have written the attached patch to document this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decis

Re: Section I - 2.9: Use SELECT to confirm set of rows before DELETE

2022-07-09 Thread Bruce Momjian
over in the Postgres docs --- we try to focus on Postgres-specific stuff that people need to know. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson

<    1   2   3   4   5   6   7   >