Re: [DOCS] [PATCH] log_statement docs

2010-02-25 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > gabrielle wrote: > >> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane wrote: > >>> Shouldn't it just say "all means all", if we think that needs to be > >>> explained? > >> > >> I think it should say something about the "all" option. I read & > >> re-read t

Re: [DOCS] [PATCH] log_statement docs

2010-02-25 Thread Bruce Momjian
gabrielle wrote: > On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane wrote: > > gabrielle writes: > >> Patch amends description of log_statement to include definition of "all" > >> option. > > > > Shouldn't it just say "all means all", if we think that needs to be > > explained? > > I think it should s

Re: [DOCS] [PATCH] log_statement docs

2010-02-25 Thread gabrielle
On Thu, Feb 25, 2010 at 11:20 AM, Bruce Momjian wrote: > I have applied the following patch with adds "off" and "all statements" > identifiers.  This is probaby the right level of detail for this. Thank you! gabrielle -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make chan

Re: [DOCS] [PATCH] log_statement docs

2010-02-25 Thread Tom Lane
Bruce Momjian writes: > gabrielle wrote: >> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane wrote: >>> Shouldn't it just say "all means all", if we think that needs to be >>> explained? >> >> I think it should say something about the "all" option. I read & >> re-read that section trying to figure out

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Heikki Linnakangas
Fujii Masao wrote: > On Thu, Feb 25, 2010 at 5:03 PM, Thom Brown wrote: >> It looks as if Heikki has already changed the page anyway, which >> includes and example of a parameter setting for primary_conninfo and >> removes links to the libpq connection stuff. Problem solved :) > > Yeah, Heikki r

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Fujii Masao
On Thu, Feb 25, 2010 at 7:41 PM, Heikki Linnakangas wrote: > Hmm, so how does one escape quotes in recovery.conf? That would be valid > information, if readRecoveryCommandFile() didn't choke on quotes. Probably we can't. > At some point we'll have to make the recovery.conf parsing smarter, if >

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Heikki Linnakangas
Fujii Masao wrote: > On Thu, Feb 25, 2010 at 6:15 PM, Heikki Linnakangas > wrote: >> Yeah, it's not very clear as it is. >> >> How about this: >> >> --- a/doc/src/sgml/recovery-config.sgml >> +++ b/doc/src/sgml/recovery-config.sgml >> @@ -193,7 +193,8 @@ restore_command = 'copy "C:\\server\\archiv

Re: [DOCS] Typo in updated plperl docs

2010-02-25 Thread Magnus Hagander
On Thu, Feb 25, 2010 at 10:57, Richard Huxton wrote: > http://developer.postgresql.org/pgdocs/postgres/plperl-under-the-hood.html > > Contains several references to "plplerl" rather than "plperl". Thanks, fixed. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.

[DOCS] Typo in updated plperl docs

2010-02-25 Thread Richard Huxton
http://developer.postgresql.org/pgdocs/postgres/plperl-under-the-hood.html Contains several references to "plplerl" rather than "plperl". -- Richard Huxton Archonet Ltd -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresq

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Heikki Linnakangas
Thom Brown wrote: > On 25 February 2010 09:15, Heikki Linnakangas > wrote: >> Fujii Masao wrote: >>> On Thu, Feb 25, 2010 at 5:03 PM, Thom Brown wrote: It looks as if Heikki has already changed the page anyway, which includes and example of a parameter setting for primary_conninfo and >

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Fujii Masao
On Thu, Feb 25, 2010 at 6:15 PM, Heikki Linnakangas wrote: > Yeah, it's not very clear as it is. > > How about this: > > --- a/doc/src/sgml/recovery-config.sgml > +++ b/doc/src/sgml/recovery-config.sgml > @@ -193,7 +193,8 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" > "%p"' >         >

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Thom Brown
On 25 February 2010 09:15, Heikki Linnakangas wrote: > Fujii Masao wrote: >> On Thu, Feb 25, 2010 at 5:03 PM, Thom Brown wrote: >>> It looks as if Heikki has already changed the page anyway, which >>> includes and example of a parameter setting for primary_conninfo and >>> removes links to the li

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Fujii Masao
On Thu, Feb 25, 2010 at 5:03 PM, Thom Brown wrote: > It looks as if Heikki has already changed the page anyway, which > includes and example of a parameter setting for primary_conninfo and > removes links to the libpq connection stuff.  Problem solved :) Yeah, Heikki removed the link from http://

Re: [DOCS] Confusing link in streaming replication section

2010-02-25 Thread Thom Brown
On 25 February 2010 02:45, Fujii Masao wrote: > Sorry for the delay. > > On Sat, Feb 13, 2010 at 1:15 AM, Thom Brown wrote: >> I think the problem I have with there being a link to the libpq >> control functions page is that the context of the settings isn't the >> same, meaning the text on that