[DOCS] synchronous_commit is not boolean anymore

2011-09-22 Thread Jaime Casanova
Hi, I was reading all this again and found that the docs are still saying that synchronous_commit is boolean... which in my understanding is just not true anymore... attached a one linear patch to fix that -- Jaime Casanova         www.2ndQuadrant.com Professional PostgreSQL: Soporte 24x7 y capa

Re: [DOCS] somewhat wrong archive_command example

2011-09-22 Thread Euler Taveira de Oliveira
On 22-09-2011 16:29, Josh Kupershmidt wrote: On Thu, Sep 22, 2011 at 2:41 PM, Euler Taveira de Oliveira wrote: On 22-09-2011 15:15, Josh Kupershmidt wrote: 1.) IMO it's more logical to put the test for whether the $ARCHIVE directory exists before the test whether ${ARCHIVE}/${FILE} exists.

Re: [DOCS] somewhat wrong archive_command example

2011-09-22 Thread Josh Kupershmidt
On Thu, Sep 22, 2011 at 2:41 PM, Euler Taveira de Oliveira wrote: > On 22-09-2011 15:15, Josh Kupershmidt wrote: >>  1.) IMO it's more logical to put the test for whether the $ARCHIVE >> directory exists before the test whether ${ARCHIVE}/${FILE} exists. > > No. If you do so, it will end up wastin

Re: [DOCS] somewhat wrong archive_command example

2011-09-22 Thread Euler Taveira de Oliveira
On 22-09-2011 15:15, Josh Kupershmidt wrote: Few more suggestions/nitpicks: 1.) IMO it's more logical to put the test for whether the $ARCHIVE directory exists before the test whether ${ARCHIVE}/${FILE} exists. No. If you do so, it will end up wasting a lot of cpu cycles testing something that

Re: [DOCS] somewhat wrong archive_command example

2011-09-22 Thread Josh Kupershmidt
On Wed, Sep 21, 2011 at 8:59 PM, Euler Taveira de Oliveira wrote: > On 21-09-2011 20:02, Greg Smith wrote: >> >> Attached version fixes the late night brain fade errors. I think the right >> thing to do next is to package this up into a doc update that corrects the >> errors in that section too; j