Re: [DOCS] [PATCH] Use idiomatic style for varlena structs

2012-02-13 Thread Jay Levitt
Tom Lane wrote: Jay Levitt writes: I'm new to the codebase, but I think this patch reflects real-world usage; the PostgreSQL code itself always calls the length field "vl_len_", and I believe int32 is preferred over int4 (yes?) The point of calling it vl_len_ is that it should never be refere

Re: [DOCS] [PATCH] Use idiomatic style for varlena structs

2012-02-13 Thread Tom Lane
Jay Levitt writes: > I'm new to the codebase, but I think this patch reflects real-world usage; > the PostgreSQL code itself always calls the length field "vl_len_", and I > believe int32 is preferred over int4 (yes?) The point of calling it vl_len_ is that it should never be referenced by that

[DOCS] [PATCH] Use idiomatic style for varlena structs

2012-02-13 Thread Jay Levitt
I'm new to the codebase, but I think this patch reflects real-world usage; the PostgreSQL code itself always calls the length field "vl_len_", and I believe int32 is preferred over int4 (yes?) Jay Levitt diff --git a/doc/src/sgml/xfunc.sgml b/doc/src/sgml/xfunc.sgml index a6d2a13..b19801d 10064