Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread Tomonari Katsumata
Hi, Thank you for many comments. I've not thought about another parameters... Sorry for my thoughtless. >> While I am generally in favor of requiring explicitness there is minimal >> downside risk in leaving "implicit casting" of the data in this context. >> Given that conclusion, making the c

Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread David Johnston
forgot the list... On Thu, Jun 12, 2014 at 2:05 PM, David Johnston wrote: > On Thu, Jun 12, 2014 at 1:25 PM, Tom Lane wrote: > >> David Johnston writes: >> > On Thursday, June 12, 2014, Tom Lane wrote: >> >> I don't think that argument holds water either. We routinely make >> >> changes that

Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread Tom Lane
David Johnston writes: > On Thursday, June 12, 2014, Tom Lane wrote: >> I don't think that argument holds water either. We routinely make >> changes that break old postgresql.conf files. Not in minor updates >> of course, but none of this is material for back-patching. > Then I'd pick throwing

Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread David Johnston
On Thursday, June 12, 2014, Tom Lane wrote: > David G Johnston > writes: > > On Thu, Jun 12, 2014 at 10:42 AM, Tom Lane-2 [via PostgreSQL] < > > ml-node+s1045698n5807014...@n5.nabble.com > wrote: > >> I wonder if we should round fractions up instead of down in that logic? > >> It might be less su

Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread Tom Lane
David G Johnston writes: > On Thu, Jun 12, 2014 at 10:42 AM, Tom Lane-2 [via PostgreSQL] < > ml-node+s1045698n5807014...@n5.nabble.com> wrote: >> I wonder if we should round fractions up instead of down in that logic? >> It might be less surprising for those GUCs where zero is special, and >> it s

Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread David G Johnston
On Thu, Jun 12, 2014 at 10:42 AM, Tom Lane-2 [via PostgreSQL] < ml-node+s1045698n5807014...@n5.nabble.com> wrote: > Fujii Masao <[hidden email] > > writes: > > On Thu, Jun 12, 2014 at 1:43 PM, Tomonari Katsumata > > <[hidden email]

Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread Tom Lane
Fujii Masao writes: > On Thu, Jun 12, 2014 at 1:43 PM, Tomonari Katsumata > wrote: >> The document tells us to set it to ZERO if we want to disable the feature. >> However, the feature would be disabled if we set it less than one minute. > That's because log_rotation_age expects the setting valu

Re: [DOCS] disabling log_rotation_age feature.

2014-06-12 Thread Fujii Masao
On Thu, Jun 12, 2014 at 1:43 PM, Tomonari Katsumata wrote: > Hi, > > I'm reading about log_rotation_age. > And I noticed that the setting for disabling the feature is not clear. > > > The document tells us to set it to ZERO if we want to disable the feature. > However, the feature would be disable