Re: [DOCS] dead links in documentation

2017-09-14 Thread Daniel Gustafsson
> On 13 Sep 2017, at 23:23, Peter Eisentraut > wrote: > > The following external links in the documentation have been dead for a > while. I haven't been able to find any plausible replacements, so I > propose to remove them unless someone has a better idea. > > http://itrc.hp.com > http://www.

[DOCS] XMLTABLE default namespace in docs

2017-09-11 Thread Daniel Gustafsson
When reviewing Pavels patch for default namespace in XMLTABLE, I came across this sentence in the devel (and 10beta) docs in subsection 9.14.3.3. xmltable: The following example illustrates how the XMLNAMESPACES clause can be used to specify the default namespace, and a list of add

Re: [DOCS] Change wording for PG_MODULE_MAGIC inclusion

2017-08-30 Thread Daniel Gustafsson
> On 31 Aug 2017, at 04:42, Peter Eisentraut > wrote: > > On 8/30/17 13:28, Daniel Gustafsson wrote: >>> On 30 Aug 2017, at 16:51, Tom Lane wrote: >>> >>> Alvaro Herrera writes: >>>> Uh, why would anybody be reading the pg10 docs in order to

Re: [DOCS] Change wording for PG_MODULE_MAGIC inclusion

2017-08-30 Thread Daniel Gustafsson
> On 30 Aug 2017, at 16:51, Tom Lane wrote: > > Alvaro Herrera writes: >> Uh, why would anybody be reading the pg10 docs in order to compile >> modules for 8.2? I vote to just drop the suggestion that there needs to >> be an #ifdef guard altogether. > > +1 ... if you are reading the current do

Re: [DOCS] Change wording for PG_MODULE_MAGIC inclusion

2017-08-30 Thread Daniel Gustafsson
> On 30 Aug 2017, at 16:35, Alvaro Herrera wrote: > > Daniel Gustafsson wrote: >> With 8.1 being fairly far down on the EOL list, it seems about time to update >> the docs regarding PG_MODULE_MAGIC to mention the pre-8.2 #ifdef guards as an >> exception and not the d

[DOCS] Change wording for PG_MODULE_MAGIC inclusion

2017-08-30 Thread Daniel Gustafsson
With 8.1 being fairly far down on the EOL list, it seems about time to update the docs regarding PG_MODULE_MAGIC to mention the pre-8.2 #ifdef guards as an exception and not the default. Not sure if a Note should be used, or just a paragraph, so opted for a paragraph. This also removes the last t

Re: [DOCS] Default names for CRL and CA files in the backend

2017-08-18 Thread Daniel Gustafsson
> On 18 Aug 2017, at 09:28, Michael Paquier wrote: > > On Thu, Aug 17, 2017 at 4:37 PM, Daniel Gustafsson wrote: >>> On 17 Aug 2017, at 03:26, Michael Paquier wrote: >> Since all supported versions have this as a parameter, this seems to mainly >> serve as a help

Re: [DOCS] Default names for CRL and CA files in the backend

2017-08-17 Thread Daniel Gustafsson
> On 17 Aug 2017, at 03:26, Michael Paquier wrote: > > On Thu, Aug 17, 2017 at 7:31 AM, Daniel Gustafsson wrote: >> Commit a445cb92ef5b3a31313ebce30e18cc1d6e0bdecb removed the default names for >> serverside CRL and CA files, but the defaults were left in the "SS

[DOCS] Default names for CRL and CA files in the backend

2017-08-16 Thread Daniel Gustafsson
Commit a445cb92ef5b3a31313ebce30e18cc1d6e0bdecb removed the default names for serverside CRL and CA files, but the defaults were left in the "SSL Server File Usage” table with a small note. I completely missed the note, even after having been fiddling about with the code in question. Removing the

Re: [DOCS] (almost) same sentence twice

2017-06-02 Thread Daniel Gustafsson
> On 02 Jun 2017, at 12:04, daniel.westerm...@dbi-services.com wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/release-10.html > Description: > > Rename WAL-related functions and views to use lsn instead of locati

Re: [DOCS] Legal Notice page in 10 not "backwards compatible" in online docs

2017-05-25 Thread Daniel Gustafsson
> On 25 May 2017, at 17:44, Magnus Hagander wrote: > > Turns out that adding the capability to do aliases was a lot easier than I > thought :) I've added an alias for legalnotice and also for pg_receivewal, > pg_resetwal and pg_waldump so far. Awesome! > Do we have some more docs pages where

Re: [DOCS] Update postgresql.org http links to https in docs

2017-05-21 Thread Daniel Gustafsson
> On 21 May 2017, at 03:52, Tom Lane wrote: > > Daniel Gustafsson writes: >> Since the website is solely serving pages over https now redirecting all http >> requests, we should use https to avoid an extra redirect for users. Attached >> patch updates the few

[DOCS] Update postgresql.org http links to https in docs

2017-05-20 Thread Daniel Gustafsson
Since the website is solely serving pages over https now redirecting all http requests, we should use https to avoid an extra redirect for users. Attached patch updates the few http links found in various pieces of documentation in the tree. cheers ./daniel https_links.patch Description: Binar

[DOCS] Duplicated item in 10 release notes

2017-05-19 Thread Daniel Gustafsson
"Rename WAL-related functions and views to use lsn instead of location (David Rowley)” appears twice in the release notes, with one being in place of c1a7f64b4 by Peter Eisentraut. I assume something along the lines of the attached patch is what was intended. cheers ./daniel relnotes10wal.patc

[DOCS] Legal Notice page in 10 not "backwards compatible" in online docs

2017-05-19 Thread Daniel Gustafsson
The Legal Notice page has in 10 changed from being uppercased to lowercased, and in the process the site no longer sees it as being present in previous version of the documentation: https://www.postgresql.org/docs/9.6/static/LEGALNOTICE.html https://www.postgresql.org/docs/10/static/legalnotice.ht

[DOCS] Consistent capitalization of procedural languages

2017-03-24 Thread Daniel Gustafsson
In a not-so-rare case of OCD I realized we have a few different ways to capitalize the names of procedural languages in the documentation (and code comments). There is one way used almost exclusively, and then a few less common variants: PL/pgSQL: 867 PL/pgsql: 22 PL/PgSQL: 15 pl/pgsql: 8 PL/pgSq

[DOCS] Wording in pg_upgrade IMPLEMENTATION

2016-10-03 Thread Daniel Gustafsson
The following sentence in src/bin/pg_upgrade/IMPLEMENTATION seems to not be quite right: "This is the steps ensures that the proper tuples are visible from the new cluster.” Patch with proposed wordsmithing is attached. cheers ./daniel pg_upgrade_implementation_wording.diff Description: B

[DOCS] Wording in Error Message Style Guide

2016-07-15 Thread Daniel Gustafsson
Perhaps a nitpick, but in subsection 51.3.1 in the "Error Message Style Guide" the language in the rationale for avoiding implementation details seems to not be in line with the overall one of voice of the docs. ISTM the following reads better: -don't know the details anyway. +aren't expe

Re: [DOCS] contrib/intarray programlisting refers to pre-extension file

2016-05-21 Thread Daniel Gustafsson
> On 21 May 2016, at 21:47, Tom Lane wrote: > > Daniel Gustafsson writes: >> The programlisting for invoking the bench.pl script in contrib/intarray is >> referring to the pre-extension file _int.sql which was removed in 9.1 (commit >> 629b3af) in favor of intarray—x

[DOCS] contrib/intarray programlisting refers to pre-extension file

2016-05-17 Thread Daniel Gustafsson
The programlisting for invoking the bench.pl script in contrib/intarray is referring to the pre-extension file _int.sql which was removed in 9.1 (commit 629b3af) in favor of intarray—x.y.sql. Attached patch use “psql -c” to create the extension instead of piping in the now removed file. cheers ./

Re: [DOCS] Documentation on Streaming Replication interface for Logical Decoding

2015-11-09 Thread Daniel Gustafsson
> On 10 Nov 2015, at 05:59, Michael Paquier wrote: > > On Tue, Nov 10, 2015 at 7:40 AM, Daniel Gustafsson wrote: >> In section 46.3 (Streaming Replication Protocol Interface) the create command >> for logical slots, CREATE_REPLICATION_SLOT, is defined as taking “options”

[DOCS] Documentation on Streaming Replication interface for Logical Decoding

2015-11-09 Thread Daniel Gustafsson
In section 46.3 (Streaming Replication Protocol Interface) the create command for logical slots, CREATE_REPLICATION_SLOT, is defined as taking “options” after the LOGICAL keyword when it in fact requires the plugin name. The start command is correctly listing the options but isn’t listing the requ

Re: [DOCS] Documenting timezone setting in initdb

2014-12-12 Thread Daniel Gustafsson
On 12 Dec 2014, at 05:16, Peter Eisentraut wrote: > On 11/15/14 7:19 PM, Daniel Gustafsson wrote: >> Setting the time zone of the newly created cluster from initdb via the >> environment variable isn't documented in the initdb section (but very handy). >> Attached is a

[DOCS] Documenting timezone setting in initdb

2014-11-15 Thread Daniel Gustafsson
Setting the time zone of the newly created cluster from initdb via the environment variable isn't documented in the initdb section (but very handy). Attached is a patch adding a mention of TZ in the Environment section. Unless objections I'll add it to the open commitfest. cheers ./daniel