Re: [DOCS] hot standby documentation

2010-06-23 Thread Heikki Linnakangas
On 23/06/10 22:05, Robert Haas wrote: On Wed, Jun 23, 2010 at 2:53 PM, Simon Riggs wrote: We could also allow SELECT ... FOR SHARE during Hot Standby, simply by making it same as normal SELECT, without any ill effects. True. Not really. It won't matter while the standby is in read-only mode

Re: [DOCS] hot standby documentation

2010-06-23 Thread Robert Haas
On Wed, Jun 23, 2010 at 3:05 PM, Robert Haas wrote: >> We could also allow SELECT ... FOR SHARE during Hot Standby, simply by >> making it same as normal SELECT, without any ill effects. > > True. Actually, wait a minute. Why wouldn't we need to lock the tuples on the standby just as we do on th

Re: [DOCS] hot standby documentation

2010-06-23 Thread Robert Haas
On Wed, Jun 23, 2010 at 2:53 PM, Simon Riggs wrote: > On Tue, 2010-06-22 at 14:24 -0400, Robert Haas wrote: > >> Fixed.  See attached. > > I started reading this but by chunk seven I only agree with a couple of > these changes. None of them seem hugely important changes. > > I'd suggest you make a

Re: [DOCS] hot standby documentation

2010-06-23 Thread Simon Riggs
On Tue, 2010-06-22 at 14:24 -0400, Robert Haas wrote: > Fixed. See attached. I started reading this but by chunk seven I only agree with a couple of these changes. None of them seem hugely important changes. I'd suggest you make a pass of copy editing that doesn't seek to alter the meanings or

Re: [DOCS] hot standby documentation

2010-06-22 Thread Joshua Tolley
On Tue, Jun 22, 2010 at 02:24:55PM -0400, Robert Haas wrote: > On Tue, Jun 22, 2010 at 8:56 AM, Joshua Tolley wrote: > >> -    Queries executed on the standby will be correct with regard to the > >> transactions > >> -    that had been recovered at the start of the query, or start of first > >>

Re: [DOCS] hot standby documentation

2010-06-22 Thread Robert Haas
On Tue, Jun 22, 2010 at 8:56 AM, Joshua Tolley wrote: > I'm not sure it's worth pointing out that the database might still use temp > files. It seems an unnecessary level of detail. I realize you're probably > putting it here because you've edited that bit out of the docs elsewhere, but > I still

Re: [DOCS] hot standby documentation

2010-06-22 Thread Joshua Tolley
On Mon, Jun 21, 2010 at 11:42:03PM -0400, Robert Haas wrote: > I did some editing of the Hot Standby docs tonight; PFA a proposed patch. > > Comments? In general, +1 > +When the parameter is set to true on a > +standby server, it will begin accepting connections once the recovery has >

[DOCS] hot standby documentation

2010-06-21 Thread Robert Haas
I did some editing of the Hot Standby docs tonight; PFA a proposed patch. Comments? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company hot-standby-docs.patch Description: Binary data -- Sent via pgsql-docs mailing list ([email protected]) To make

Re: [DOCS] Hot Standby documentation updates

2010-02-18 Thread Bruce Momjian
Applied; updated version attached. I talked to Greg via IM and we decide to not use his buffer cleanup locks text below but to use something simpler: The standby waiting longer than max_standby_delay to acquire a buffer cleanup lock. --

[DOCS] Hot Standby documentation updates

2010-02-18 Thread Greg Smith
Attached is a patch that fixes up a couple of spots I felt could use improvement in the Hot Standby documentation. Most of this is simple wordsmithing, or minor expansion of points I tried to explain more clearly. A few of the edits I'd marked up on paper were already applied in the last upda