Marti Raudsepp wrote:
> On Sat, Aug 30, 2014 at 8:43 PM, Tom Lane wrote:
>> I would argue against applying patch 2 at all.
>
> I don't feel strongly about this, I originally didn't plan to submit
> this patch at all. But I don't agree with:
>
>> doing it only because some style guide tells
>> you
Alvaro Herrera wrote:
> One reasonably-serious page
... and with that, I guess you've expressed a reasonably clear
preference. ;-)
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make ch
Kevin Grittner wrote:
> In patch 0003- I agree that the change to "exactly the same" reads
> better. I'm torn on changing the hyphens to spaces. I probably
> wouldn't change them, but I wouldn't squawk if others preferred to
> do so.
Apparently adverb hyphenation discussion plagues the web. On
On Sat, Aug 30, 2014 at 8:43 PM, Tom Lane wrote:
> I would argue against applying patch 2 at all.
I don't feel strongly about this, I originally didn't plan to submit
this patch at all. But I don't agree with:
> doing it only because some style guide tells
> you to is not the way to approach the
Tom Lane-2 wrote
> Kevin Grittner <
> kgrittn@
> > writes:
>> Patch 1 pushed, with each fix back-patched as far as the error
>> exists in supported releases. I held off on patch 2 -- partly
>> because I spotted at least one case where things weren't quite
>> right, partly because there's so much
Kevin Grittner writes:
> Patch 1 pushed, with each fix back-patched as far as the error
> exists in supported releases. I held off on patch 2 -- partly
> because I spotted at least one case where things weren't quite
> right, partly because there's so much I haven't had time to go over
> it in su
Marti Raudsepp wrote:
> All updated patches attached, per our previous discussion.
> Patches 1-2 are ready, 3 can be discarded unless someone else
> chimes in.
Patch 1 pushed, with each fix back-patched as far as the error
exists in supported releases. I held off on patch 2 -- partly
because I
Marti Raudsepp wrote:
> Kevin Grittner wrote:
>> For the initial patch, I agree with all except the first change of
>> "others'" to "other's" -- the start of the sentence uses "All", so
>> there is clearly more than one "other", so the the apostrophe
>> belongs after the "s".
>
> Not arguing
On Mon, Aug 25, 2014 at 10:13 PM, Kevin Grittner wrote:
> For the initial patch, I agree with all except the first change of
> "others'" to "other's" -- the start of the sentence uses "All", so
> there is clearly more than one "other", so the the apostrophe
> belongs after the "s".
Not arguing ag
Marti Raudsepp wrote:
> I ran the Topy typo-fixer (https://github.com/intgr/topy , using rules
> developed for Wikipedia) over the PostgreSQL documentation directory.
> Attached is a patch with hand-picked fixes that are clearly an
> improvement.
For the initial patch, I agree with all except th
On Mon, Aug 25, 2014 at 4:46 PM, Kevin Grittner wrote:
>> * "eg" -> "e.g."
>> * "etc" -> "etc."
> These two seem to me like they should be changed; otherwise they
> just don't look correct.
Oh, right you are; I looked it up on some grammar forums and there
seems to be no question about this. I at
Marti Raudsepp wrote:
> I ran the Topy typo-fixer (https://github.com/intgr/topy , using rules
> developed for Wikipedia) over the PostgreSQL documentation directory.
> Attached is a patch with hand-picked fixes that are clearly an
> improvement.
>
> There are also some changes that I didn't incl
12 matches
Mail list logo
