[DOCS] 36.1 Overview of Trigger Behavior

2015-08-11 Thread Dmitry Igrishin
Subparagraph 8: I suggest to replace "BEFORE row-level triggers to execute" with "row-level BEFORE triggers to execute" for consistency. Subparagraph 14: While WHEN can be used with INSERT too, I suggest to replace "However, in an AFTER trigger, the WHEN condition is evaluated just after the row u

[DOCS] 36.2 Visibility of Data Changes

2015-08-11 Thread Dmitry Igrishin
Subparagraph 1: I suggest to replace "Statement-level triggers follow simple visibility rules: none of the changes made by a statement are visible to statement-level triggers that are invoked before the statement, whereas all modifications are visible to statement-level AFTER triggers." with "State

[DOCS] 36.3 Writing Tigger Functions in C

2015-08-11 Thread Dmitry Igrishin
Subparagparh 3: I suggest to replace: "but it is passed a "context" pointer pointing to a TriggerData structure" with "but it is passed a "context" pointer to a structure of type TriggerData" tg_trigtuple: I'm not sure why "skip the operation" is here: "if you don't want to replace the row with a

[DOCS] "SQL null" vs "SQL NULL".

2015-08-11 Thread Dmitry Igrishin
I've noticed that there are both of "SQL null" and "SQL NULL" are presents. I'm not sure what is more correct, but I think it would be better to make it consistent. -- // Dmitry.

Re: [DOCS] 36.3 Writing Tigger Functions in C

2015-08-11 Thread Dmitry Igrishin
2015-08-11 13:47 GMT+03:00 Dmitry Igrishin : > Subparagparh 3: > I suggest to replace: > "but it is passed a "context" pointer pointing to a TriggerData > structure" > with > "but it is passed a "context" pointer to a structure of type > TriggerData" > Oops, it's even better to replace with "but i

Re: [DOCS] 36.3 Writing Tigger Functions in C

2015-08-11 Thread Marko Tiikkaja
On 8/11/15 12:47 PM, Dmitry Igrishin wrote: tg_trigtuple: I'm not sure why "skip the operation" is here: "if you don't want to replace the row with a different one (in the case of INSERT) or skip the operation" Returning NULL from a row-level BEFORE trigger skips the operation which fired the

Re: [DOCS] 36.3 Writing Tigger Functions in C

2015-08-11 Thread Dmitry Igrishin
2015-08-11 14:32 GMT+03:00 Marko Tiikkaja : > On 8/11/15 12:47 PM, Dmitry Igrishin wrote: > >> tg_trigtuple: >> I'm not sure why "skip the operation" is here: >> "if you don't want to replace the row with a different one (in the >> case of INSERT) or skip the operation" >> > > Returning NULL from