Re: [DOCS] FrozenTransactionId

2016-09-06 Thread Egor Rogov
Sorry, my last email went without the attachment. On 06.09.2016 01:09, Egor Rogov wrote: Tom Lane <[hidden email] > writes: > It'd be more likely to get pushed if you'd submitted it in an easily > reviewable form, ie without reflowing the entire (rather long) paragraph. > As-is, it's much too

Re: [DOCS] FrozenTransactionId

2016-09-06 Thread Tom Lane
Egor Rogov writes: >> Please find another patch attached. I hope it is a bit easier to >> review now. Hmm. I do not actually see anything wrong with the existing text: it does not say that FrozenTransactionId is what appears on disk, it says that frozen tuples are treated as if their xmin were

[DOCS] Foreign Table docs are way to brief.

2016-09-06 Thread mark0978
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/9.1/static/sql-dropforeigntable.html Description: I see DROP FOREIGN TABLE and wonder if it actually deletes data like DROP TABLE would do. What does it mean to CREATE FOREIGN TABLE? Is it

Re: [DOCS] FrozenTransactionId

2016-09-06 Thread Egor Rogov
On 06.09.2016 15:41, Tom Lane wrote: Egor Rogov writes: Please find another patch attached. I hope it is a bit easier to review now. Hmm. I do not actually see anything wrong with the existing text: it does not say that FrozenTransactionId is what appears on disk, it says that frozen tuples a

Re: [DOCS] FrozenTransactionId

2016-09-06 Thread Tom Lane
Egor Rogov writes: > Right, it does not say that FrozenTransactionId is what appears on disk, > but what is? There is no such information anywhere in the doc. Since 9.4 > frozen transactions have their normal XIDs preserved, so how a user can > tell normal transaction from frozen one? This is w

Re: [DOCS] FrozenTransactionId

2016-09-06 Thread Tom Lane
I pushed some edits based on this discussion at https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=975768f8eae2581b89ceafe8b16a77ff375207fe regards, tom lane -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscript

Re: [DOCS] FrozenTransactionId

2016-09-06 Thread Egor Rogov
On 06.09.2016 23:41, Tom Lane wrote: Egor Rogov writes: Right, it does not say that FrozenTransactionId is what appears on disk, but what is? There is no such information anywhere in the doc. Since 9.4 frozen transactions have their normal XIDs preserved, so how a user can tell normal transacti

Re: [DOCS] Foreign Table docs are way to brief.

2016-09-06 Thread Michael Paquier
On Mon, Sep 5, 2016 at 11:22 AM, wrote: > Too few words given over to helping me understand what FOREIGN brings to the > table in all these commands. Patches for improvements are welcome if you think that's worth it. Now there is this bit in the documentation that explains the concept of foreign