ddl-basics.html plural stuff

2021-07-15 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/ddl-basics.html Description: Probably this is horribly pedantic but 'data' is a plural word and database people should of all humans know this. Datum is the singular. Should 'this many col

Re: ddl-basics.html plural stuff

2021-07-15 Thread Laurenz Albe
On Wed, 2021-07-14 at 18:45 +, PG Doc comments form wrote: > Probably this is horribly pedantic but 'data' is a plural word and database > people should of all humans know this. Datum is the singular. Should 'this > many columns' be 'these many columns'? A shame that Americans don't really > kn

No mention of standby.signal in pg_ugprade docs

2021-07-15 Thread Dan Stoner
Hi, I noticed that standby.signal is not mentioned anywhere in the pg_upgrade document. https://www.postgresql.org/docs/13/pgupgrade.html I had trouble the first time I tried to start my secondary because it didn't connect to the primary / start streaming until I touched the signal file. Th

Re: Minor doc fixes

2021-07-15 Thread Daniel Gustafsson
> On 13 Jul 2021, at 23:32, Daniel Gustafsson wrote: > >> On 13 Jul 2021, at 15:13, Ekaterina Kiryanova >> wrote: > >> I've noticed some minor doc inconsistencies. >> Please review the attached patch. > > Thanks for your patch, reviewing it I agree with your proposed changes. > Unless > the

Re: Manua correction

2021-07-15 Thread Bruce Momjian
On Tue, Jul 13, 2021 at 02:24:01AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/functions-string.html > Description: > > Hopefully the referrer page was kept. I'm referring to the string funct

Re: Manua correction

2021-07-15 Thread Tom Lane
Bruce Momjian writes: > Interesting. I see several cases where our docs are not clear we > process only the first match: At least two of these changes are flat out wrong. The places that explicitly mention "substring(s)" are not doing so because we failed to think about what that meant.

Re: No mention of standby.signal in pg_ugprade docs

2021-07-15 Thread Laurenz Albe
On Thu, 2021-07-15 at 14:39 -0400, Dan Stoner wrote: > I noticed that standby.signal is not mentioned anywhere in the pg_upgrade > document. > > https://www.postgresql.org/docs/13/pgupgrade.html > > I had trouble the first time I tried to start my secondary because it didn't > connect to the p

Re: Improve documentation for pg_upgrade, standbys and rsync

2021-07-15 Thread Laurenz Albe
On Wed, 2021-05-19 at 10:31 -0400, Stephen Frost wrote: > * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > > I revently tried to upgrade a standby following the documentation, > > but I found it hard to understand, and it took me several tries to > > get it right. This is of course owing to my l