Re: Indentation in a patch

2025-11-26 Thread Peter Eisentraut
On 25.11.25 19:58, Daniel Gustafsson wrote: On 25 Nov 2025, at 19:14, Bernice Southey wrote: .. for my first ever patch attempt. Awesome, we love to see new contributors! I'm tempted to submit my patch without indenting the if-block, and an explanation. That's perfectly fine, an incorre

Re: Indentation in a patch

2025-11-25 Thread Daniel Gustafsson
> On 25 Nov 2025, at 19:14, Bernice Southey wrote: > .. for my first ever patch attempt. Awesome, we love to see new contributors! > I'm tempted to submit my patch without indenting the > if-block, and an explanation. That's perfectly fine, an incorrectly indentend diff is fine to submit if it

Indentation in a patch

2025-11-25 Thread Bernice Southey
Hi, I'm having a fight with git and indentation for my first ever patch attempt. I'm just adding an if statement around an existing 70-line code-block. It's a very simple few lines with --ignore-all-space. But the patch file is noisy because of 140 lines of +/- indentation diffs. I then realised