Re: fix ancient typo in transformRelOptions()

2025-08-06 Thread Tom Lane
Nathan Bossart writes: > Any thoughts on back-patching this? It's entirely cosmetic and could help > avoid some back-patching pain down the road. I originally chose not to > back-patch because it's not a bug and "namspace" has been there for a very > long time, but now I'm having second thoughts

Re: fix ancient typo in transformRelOptions()

2025-08-06 Thread Peter Eisentraut
On 06.08.25 20:06, Nathan Bossart wrote: On Wed, Aug 06, 2025 at 12:09:28PM -0500, Nathan Bossart wrote: On Tue, Aug 05, 2025 at 09:20:09PM -0500, Nathan Bossart wrote: That explains it. I didn't find any past discussions about this particular name, but commit de160e2 was being developed concu

Re: fix ancient typo in transformRelOptions()

2025-08-06 Thread Nathan Bossart
On Wed, Aug 06, 2025 at 12:09:28PM -0500, Nathan Bossart wrote: > On Tue, Aug 05, 2025 at 09:20:09PM -0500, Nathan Bossart wrote: >> That explains it. I didn't find any past discussions about this particular >> name, but commit de160e2 was being developed concurrently. I'll use >> nameSpace inste

Re: fix ancient typo in transformRelOptions()

2025-08-06 Thread Nathan Bossart
On Tue, Aug 05, 2025 at 09:20:09PM -0500, Nathan Bossart wrote: > That explains it. I didn't find any past discussions about this particular > name, but commit de160e2 was being developed concurrently. I'll use > nameSpace instead. Committed. -- nathan

Re: fix ancient typo in transformRelOptions()

2025-08-06 Thread Ashutosh Bapat
On Wed, Aug 6, 2025 at 2:33 AM Nathan Bossart wrote: > > I noticed that this function has a "namspace" parameter. The attached > patch adds the missing 'e'. :) Nobody seems to have been troubled by it for so long. Would fixing it now create back-patching problems. Probably not since that code i

Re: fix ancient typo in transformRelOptions()

2025-08-05 Thread Nathan Bossart
On Tue, Aug 05, 2025 at 06:10:54PM -0400, Tom Lane wrote: > =?utf-8?Q?=C3=81lvaro?= Herrera writes: >> On 2025-Aug-05, Nathan Bossart wrote: >>> I noticed that this function has a "namspace" parameter. The attached >>> patch adds the missing 'e'. > >> I have vague recollections of it being this

Re: fix ancient typo in transformRelOptions()

2025-08-05 Thread Álvaro Herrera
On 2025-Aug-05, Tom Lane wrote: > =?utf-8?Q?=C3=81lvaro?= Herrera writes: > > On 2025-Aug-05, Nathan Bossart wrote: > >> I noticed that this function has a "namspace" parameter. The attached > >> patch adds the missing 'e'. > > > I have vague recollections of it being this way because of "names

Re: fix ancient typo in transformRelOptions()

2025-08-05 Thread Tom Lane
=?utf-8?Q?=C3=81lvaro?= Herrera writes: > On 2025-Aug-05, Nathan Bossart wrote: >> I noticed that this function has a "namspace" parameter. The attached >> patch adds the missing 'e'. > I have vague recollections of it being this way because of "namespace" > being a C++ keyword. (commit is 3a5b

Re: fix ancient typo in transformRelOptions()

2025-08-05 Thread Álvaro Herrera
On 2025-Aug-05, Nathan Bossart wrote: > I noticed that this function has a "namspace" parameter. The attached > patch adds the missing 'e'. I have vague recollections of it being this way because of "namespace" being a C++ keyword. (commit is 3a5b77371522, but I don't have energy to look for th

fix ancient typo in transformRelOptions()

2025-08-05 Thread Nathan Bossart
I noticed that this function has a "namspace" parameter. The attached patch adds the missing 'e'. -- nathan >From 3f1431517cee250f1280adca739de0d6b9c77080 Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Tue, 5 Aug 2025 16:01:34 -0500 Subject: [PATCH v1 1