Re: CALL stmt, ERROR: unrecognized node type: 113 bug

On Fri, Feb 02, 2018 at 04:01:13PM +0900, Michael Paquier wrote: > Peter, Andrew, this is missing some bits related to the conversion of > SubLink nodes to SubPlan nodes for procedures when used as argument of > a procedure as only the latter can be executed after the former is > processed by the

Re: CALL stmt, ERROR: unrecognized node type: 113 bug

On Thu, Feb 01, 2018 at 05:33:54PM +0100, Pavel Stehule wrote: > I am playing with procedures little bit > > I found few bugs > > create procedure test(a int) > as $$ > begin > raise notice '>>>%<<<', a; > end; > $$ language plpgsql; > > call test(10); -- ok > > postgres=# call test((select

Re: Query running for very long time (server hanged) with parallel append

On 2 February 2018 at 03:50, Thomas Munro wrote: > Whatever logic bug might be causing the query to hang, it's not good > that we're unable to SIGINT/SIGTERM our way out of this state. See > also this other bug report for a known problem (already fixed but not >

RE: Temporary tables prevent autovacuum, leading to XID wraparound

From: Masahiko Sawada [mailto:sawada.m...@gmail.com] > Thank you for suggestion. It sounds more smarter. So it would be more better > if we vacuums database for anti-wraparound in ascending order of > relfrozenxid? I thought so, too. The current behavior is inconsistent: the launcher tries to

Re: Temporary tables prevent autovacuum, leading to XID wraparound

On Fri, Feb 2, 2018 at 12:31 AM, Robert Haas wrote: > On Wed, Jan 31, 2018 at 7:37 PM, Masahiko Sawada > wrote: >> I think the idea would not be an improvement, but just change the >> policy. The current launcher's policy is "let's launch a new

Re: JIT compiling with LLVM v9.0

On Thu, Feb 1, 2018 at 10:09 PM, Thomas Munro wrote: > On Fri, Feb 2, 2018 at 7:06 PM, Jeff Davis wrote: >> /usr/include/c++/5/cmath:505:22: error: conflicting declaration of C >> function ‘long double >> ... >> /usr/include/c++/5/cmath:926:3:

Re: JIT compiling with LLVM v9.0

On Fri, Feb 2, 2018 at 7:06 PM, Jeff Davis wrote: > /usr/include/c++/5/cmath:505:22: error: conflicting declaration of C > function ‘long double > ... > /usr/include/c++/5/cmath:926:3: error: template with C linkage I suspect you can fix these with this change: +#ifdef

Re: JIT compiling with LLVM v9.0

On Thu, Feb 1, 2018 at 5:05 PM, Andres Freund wrote: > Just to understand: You're running in the issue with the header being > included from within the extern "C" {}? Hm, I've pushed a quick fix for > that. > > Other than that, you can compile with both gcc or clang, but

Re: proposal: alternative psql commands quit and exit

I just thought of an inconsistency. First, we now consistently exit with 'exit', 'quit', and '\q' if used in an empty psql query buffer. Also, we now hint when 'exit' and 'quit' are used in non-empty query buffers: test=> SELECT test-> exit --> Use \q to quit. We obviously

Re: JIT compiling with LLVM v9.0

On Fri, Feb 2, 2018 at 5:11 PM, Thomas Munro wrote: > Another small thing which might be environmental... llvmjit_types.bc > is getting installed into ${prefix}/lib here, but you're looking for > it in ${prefix}/lib/postgresql: Is there something broken about my

Re: [PoC PATCH] Parallel dump to /dev/null

On Thu, Feb 01, 2018 at 02:24:46PM +0100, Michael Banck wrote: > dumping a database to /dev/null via pg_dump is (AFAIK) one recommended > way to check for corruption. However, dumping to /dev/null is currently > not supported in directory mode which makes it not possible to dump to > /dev/null in

Re: [HACKERS] taking stdbool.h into use

On Thu, Feb 01, 2018 at 09:04:57AM -0500, Peter Eisentraut wrote: > I've been testing this a bit further and during a test setup with 4-byte > bools I still got regression test failures related to GIN, so it doesn't > seem quite ready. I'll keep working on it. Cool. Thanks for the update. --

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

On Thu, Feb 01, 2018 at 02:03:23PM -0500, Robert Haas wrote: > I think it's a shame that the commit message didn't document (for the > release notes) exactly which cases just got changed incompatibly. I > admit that not many people are likely to get bitten by this, but I > still think it's better

Re: JIT compiling with LLVM v9.0

Another small thing which might be environmental... llvmjit_types.bc is getting installed into ${prefix}/lib here, but you're looking for it in ${prefix}/lib/postgresql: gmake[3]: Entering directory '/usr/home/munro/projects/postgres/src/backend/lib' /usr/bin/install -c -m 644 llvmjit_types.bc

[bug fix] ECPG: freeing memory for pgtypes crashes on Windows

Hello, Some user hit a problem with ECPG on Windows. The attached patch is a fix for it. I'd appreciate it if you could backport this in all supported versions. The problem is simple. free() in the following example crashes: char *out; out = PGTYPESnumeric_to_asc(...);

Re: Wait for parallel workers to attach

On Thu, Feb 1, 2018 at 9:09 PM, Robert Haas wrote: > On Wed, Jan 31, 2018 at 10:08 PM, Amit Kapila wrote: >> I think suggesting to use this API to wait "for a specific worker" >> doesn't seem like a good idea as it doesn't have any such provision.

Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation()

On Fri, Feb 02, 2018 at 12:21:49AM +, Simon Riggs wrote: > Yes, it would be about 99% of the time. When it comes to recovery, I don't think that 99% is a guarantee sufficient. (Wondering about the maths behind such a number as well.) > But you have it backwards - we are not assuming that

Re: JIT compiling with LLVM v9.0

On Fri, Feb 2, 2018 at 2:05 PM, Andres Freund wrote: > On 2018-02-01 09:32:17 -0800, Jeff Davis wrote: >> On Wed, Jan 31, 2018 at 12:03 AM, Konstantin Knizhnik >> wrote: >> > The same problem takes place with old versions of GCC: I have to upgrade

Re: Cancelling parallel query leads to segfault

On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut wrote: >Here is a patch to implement that idea. Do you have a way to test it >repeatedly, or do you just randomly cancel queries? For me cancelling the long running parallel queries I tried reliably

Re: [HACKERS] [PATCH] Lockable views

> On Tue, Jan 30, 2018 at 1:21 AM, Thomas Munro > wrote: >> About the idea: it makes some kind of sense to me that we should lock >> the underlying table, in all the same cases that you could do DML on >> the view automatically. I wonder if this is a problem for

Re: JIT compiling with LLVM v9.0

On 2018-02-01 09:32:17 -0800, Jeff Davis wrote: > On Wed, Jan 31, 2018 at 12:03 AM, Konstantin Knizhnik > wrote: > > The same problem takes place with old versions of GCC: I have to upgrade GCC > > to 7.2 to make it possible to compile this code. > > The problem in not

Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently

On Mon, Jan 29, 2018 at 11:31 PM, Claudio Freire wrote: > On Mon, Jan 29, 2018 at 4:12 AM, Masahiko Sawada > wrote: >> On Sat, Jul 29, 2017 at 9:42 AM, Claudio Freire >> wrote: >>> Introduce a tree pruning threshold to

Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation()

On 1 February 2018 at 18:55, Robert Haas wrote: > On Thu, Feb 1, 2018 at 1:00 AM, Pavan Deolasee > wrote: >> IMHO we're missing a point here. When xl_prev is changed to a 2-byte value >> (as the patch suggests), the risk only comes when an old

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On 02/01/2018 03:51 PM, Peter Eisentraut wrote: > To close out this commit fest, I'm setting both of these patches as > returned with feedback, as there are apparently significant issues to be > addressed. Feel free to move them to the next commit fest when you > think they are ready to be

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On 01/31/2018 07:53 AM, Masahiko Sawada wrote: > On Sat, Jan 20, 2018 at 7:08 AM, Tomas Vondra > wrote: >> On 01/19/2018 03:34 PM, Tomas Vondra wrote: >>> Attached is v5, fixing a silly bug in part 0006, causing segfault when >>> creating a subscription. >>> >> >>

Re: [Patch] Checksums for SLRU files

On Wed, Jan 3, 2018 at 11:21 AM, Alexander Korotkov wrote: > On Mon, Jan 1, 2018 at 9:19 PM, Andrey Borodin wrote: >> > 31 дек. 2017 г., в 22:30, Ivan Kartyshov >> > написал(а): >> > >> > Hello, I`d like to show my

Re: [HACKERS] path toward faster partition pruning

+/* + * PartitionBoundCmpArg - Caller-defined argument to be passed to + * partition_bound_cmp() + * + * The first (fixed) argument involved in a comparison is the partition bound + * found in the catalog, while an instance of the following struct

Re: Query running for very long time (server hanged) with parallel append

On Thu, Feb 1, 2018 at 11:29 PM, Rajkumar Raghuwanshi wrote: > I am getting server hang kind of issue with the below postgres.conf setup. > Issue may occur while running below query single/multiple times (random). > Not getting terminal back even after

Re: Cancelling parallel query leads to segfault

On 1/27/18 22:45, Andres Freund wrote: > I think the comment was bad, but the functionality pretty crucial. So I > don't think > In AtAbort_Portals(), remove the code that marks an active portal as > failed. As the comment there already predicted, this doesn't work if > the running

Re: [HACKERS] [PATCH] Lockable views

On Tue, Jan 30, 2018 at 1:21 AM, Thomas Munro wrote: > About the idea: it makes some kind of sense to me that we should lock > the underlying table, in all the same cases that you could do DML on > the view automatically. I wonder if this is a problem for the >

Re: [HACKERS] Partition-wise aggregation/grouping

On Thu, Feb 1, 2018 at 8:59 AM, Jeevan Chalke wrote: > I wrote a patch for this (on current HEAD) and attached separately here. > Please have a look. Yes, this is approximately what I had in mind, though it needs more work (e.g. it doesn't removing the clearing of

Re: [HACKERS] MERGE SQL Statement for PG11

On Thu, Feb 1, 2018 at 4:45 AM, Simon Riggs wrote: > I think it would be very helpful if we could discuss everything with > direct relevance to v14, so this becomes a patch review, not just a > debate. I wish I could give you a clear answer on the way forward with total

Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation()

On Thu, Feb 1, 2018 at 1:00 AM, Pavan Deolasee wrote: > IMHO we're missing a point here. When xl_prev is changed to a 2-byte value > (as the patch suggests), the risk only comes when an old WAL file is > recycled for some future WAL file and the old and the future WAL

Re: [HACKERS] why not parallel seq scan for slow functions

On Wed, Jan 31, 2018 at 11:48 PM, Amit Kapila wrote: > I can see what you have in mind, but I think we still need to change > the parallel safety flag of the path if *_target is not parallel safe > either inside apply_projection_to_path or may be outside where it is >

Re: MCV lists for highly skewed distributions

On Thu, Feb 1, 2018 at 12:21 PM, Dean Rasheed wrote: > For a highly skewed distribution, it is possible for there to be > hardly any values (maybe only one) that appears more than 1.25 times > the average frequency, and so lots of otherwise perfectly good common > values

Re: JIT compiling with LLVM v9.0

On Wed, Jan 31, 2018 at 12:03 AM, Konstantin Knizhnik wrote: > The same problem takes place with old versions of GCC: I have to upgrade GCC > to 7.2 to make it possible to compile this code. > The problem in not in compiler itself, but in libc++ headers. How can I get

Re: MCV lists for highly skewed distributions

On 1 February 2018 at 13:16, Simon Riggs wrote: > On 25 January 2018 at 22:19, Tom Lane wrote: >> In any case, since it looks like the next step is for someone to come >> up with a new proposal, I'm going to set this to Waiting on Author. > > Dean and

Re: git instructions

On Thu, Feb 1, 2018 at 5:20 PM, Chapman Flack wrote: > On 02/01/2018 10:54 AM, Magnus Hagander wrote: > > > in saying that git:// is faster than https://. In fact, we have some > > reports and testing that https:// can be significantly faster (due to > other > > reasons).

CALL stmt, ERROR: unrecognized node type: 113 bug

Hi I am playing with procedures little bit I found few bugs create procedure test(a int) as $$ begin raise notice '>>>%<<<', a; end; $$ language plpgsql; call test(10); -- ok postgres=# call test((select 10)); ERROR: unrecognized node type: 113 postgres=# \sf test ERROR: cache lookup

Re: git instructions

On 02/01/2018 10:54 AM, Magnus Hagander wrote: > in saying that git:// is faster than https://. In fact, we have some > reports and testing that https:// can be significantly faster (due to other > reasons). Can you elaborate on the other reasons? It occurs to me that there might be cases in

Re: Jsonb transform for pl/python

On 1/12/18 10:43, Aleksander Alekseev wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:tested, passed > >

git instructions

Since some time back, we have deployed the git server side http handler on git.postgresql.org, so the instructions currently on the site are incorrect in saying that git:// is faster than https://. In fact, we have some reports and testing that https:// can be significantly faster (due to other

Re: Wait for parallel workers to attach

On Wed, Jan 31, 2018 at 10:08 PM, Amit Kapila wrote: > I think suggesting to use this API to wait "for a specific worker" > doesn't seem like a good idea as it doesn't have any such provision. I see your point, but in the absence of a more specific API it could be used

Re: Temporary tables prevent autovacuum, leading to XID wraparound

On Wed, Jan 31, 2018 at 7:37 PM, Masahiko Sawada wrote: > I think the idea would not be an improvement, but just change the > policy. The current launcher's policy is "let's launch a new worker as > much as possible on the database that is at risk of wraparound most". > The

Re: [HACKERS] MERGE SQL Statement for PG11

On 1 February 2018 at 12:45, Simon Riggs wrote: > I think it would be very helpful if we could discuss everything with > direct relevance to v14, so this becomes a patch review, not just a > debate. > i.e. which isolation test would we like to change from ERROR to >

Re: no partition pruning when partitioning using array type

On Thu, Feb 1, 2018 at 4:42 AM, Amit Langote wrote: >> I hope someone else chimes in as well. :) > > Bug #15042 [1] seems to be caused by this same problem. There, a > RelabelType node is being slapped (by the partitioning code) on a Var node > of a partition key

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

On Wed, Jan 31, 2018 at 1:52 AM, Andreas Karlsson wrote: > I looked some at your anyarray @>> anyelement code and sadly it does not > look like the index code could work. The issue I see is that > ginqueryarrayextract() needs to make a copy of the search key but to do so > it

Re: Built-in connection pooling

On 01.02.2018 16:33, Vladimir Sitnikov wrote: Konstantin>I have not built YCSB myself, use existed installation. Which pgjdbc version was in use? postgresql-9.4.1212.jar Konstantin>One of the main problems of Postgres is significant degrade of performance in case of concurrent write

Re: unique indexes on partitioned tables

On 1/26/18 13:42, Peter Eisentraut wrote: > Other than that, this looks pretty good to me. A logical extension of > the previous partitioned index patch. Moved to next CF. Seems close to ready. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: FOR EACH ROW triggers on partitioned tables

Moved to next commit fest. There is some work to be done, but there appears to be a straight path to success. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

To close out this commit fest, I'm setting both of these patches as returned with feedback, as there are apparently significant issues to be addressed. Feel free to move them to the next commit fest when you think they are ready to be continued. -- Peter Eisentraut

Re: JIT compiling with LLVM v9.0

On Wed, Jan 31, 2018 at 1:45 PM, Robert Haas wrote: > On Wed, Jan 31, 2018 at 1:34 PM, Andres Freund wrote: >>> The first one is a problem that's not going to go away. If the >>> problem of JIT being enabled "magically" is something we're concerned >>>

Re: [HACKERS] make async slave to wait for lsn to be replayed

On 22 January 2018 at 23:21, Stephen Frost wrote: >> It sounds reasonable. I can offer the following version. >> >> WAIT LSN lsn_number; >> WAIT LSN lsn_number TIMEOUT delay; >> WAIT LSN lsn_number INFINITE; >> WAIT LSN lsn_number NOWAIT; >> >> >> WAIT [token]

Re: [HACKERS] generated columns

On 1/31/18 08:18, Michael Paquier wrote: >> This also raises a question how a row type with generated columns should >> behave. I think a generation expression is a property of a table, so it >> does not apply in a row type. (Just like a default is a property of a >> table and does not apply in

Re: [HACKERS] Can ICU be used for a database's default sort order?

On 1/31/18 11:48, Vladimir Borodin wrote: > Will it work only for a particular database? Or for a whole cluster > during initdb also? Any chance to get this done in 11? I'm currently not working on it. It's basically just a lot of leg work, and you need to come up with a catalog representation.

Re: [HACKERS] taking stdbool.h into use

On 2/1/18 01:47, Michael Paquier wrote: > On Wed, Jan 24, 2018 at 03:44:04PM +0900, Michael Paquier wrote: >> Good catch. Coverage reports mark those areas as empty! Similarly the >> functions for record_* are mostly not used. Some tests could be added >> for them at the same time. The four error

Re: JIT compiling with LLVM v9.0

On 2018-02-01 08:46:08 -0500, Peter Eisentraut wrote: > On 1/31/18 14:45, Robert Haas wrote: > > We could do that, but I'd be more inclined just to let JIT be > > magically enabled. In general, if a user could do 'yum install ip4r' > > (for example) and have that Just Work without any further

Re: proposal: alternative psql commands quit and exit

Bruce Momjian wrote: > > Also, the fact that Control-D can quit in the middle of a > > multiline query without any confirmation is a usability problem, because > > you can always fat-finger a Ctrl+key. By comparison, bash doesn't > > accept it and emits the same error as if a script was

Re: [HACKERS] Partition-wise aggregation/grouping

On Thu, Feb 1, 2018 at 1:11 AM, Robert Haas wrote: > On Mon, Jan 29, 2018 at 3:42 AM, Jeevan Chalke > wrote: > > Attached new patch set and rebased it on latest HEAD. > > I strongly dislike add_single_path_to_append_rel. It adds branches >

Re: ALTER TABLE ADD COLUMN fast default

Hi, On 2018-01-26 10:53:12 +1030, Andrew Dunstan wrote: > Yeah, thanks. revised patch attached Given that this patch touches code that's a huge bottleneck in a lot of cases, I think this needs benchmarks that heavily exercises tuple deforming. Greetings, Andres Freund

Re: JIT compiling with LLVM v9.0

On 1/31/18 14:45, Robert Haas wrote: > We could do that, but I'd be more inclined just to let JIT be > magically enabled. In general, if a user could do 'yum install ip4r' > (for example) and have that Just Work without any further database > configuration, One way to do that would be to have a

Re: JIT compiling with LLVM v9.0

On 1/31/18 13:34, Andres Freund wrote: > That's a fair argument, and I don't really have a good answer to it. We > could have a jit = off/try/on, and use that to signal things? I.e. it > can be set to try (possibly default in version + 1), and things will > work if it's not installed, but if set

Re: proposal: alternative psql commands quit and exit

On Thu, Feb 1, 2018 at 12:01:37PM +0100, Daniel Verite wrote: > Also, the fact that Control-D can quit in the middle of a > multiline query without any confirmation is a usability problem, because > you can always fat-finger a Ctrl+key. By comparison, bash doesn't > accept it and emits the same

Re: Built-in connection pooling

Konstantin>I have not built YCSB myself, use existed installation. Which pgjdbc version was in use? Konstantin>One of the main problems of Postgres is significant degrade of performance in case of concurrent write access by multiple transactions to the same sows. I would consider that a

Re: proposal: alternative psql commands quit and exit

On Wed, Jan 31, 2018 at 05:51:51PM -0500, Bruce Momjian wrote: > On Sun, Jan 28, 2018 at 06:35:06PM -0500, Bruce Momjian wrote: > > I used Robert's patch and modified it to match the ideas I had above. > > Specifically no white space can be before 'help', 'exit' or 'quit' and > > prompt_status is

[PoC PATCH] Parallel dump to /dev/null

Hi, dumping a database to /dev/null via pg_dump is (AFAIK) one recommended way to check for corruption. However, dumping to /dev/null is currently not supported in directory mode which makes it not possible to dump to /dev/null in parallel. I had a look at this, and it appears it would suffice

Re: MCV lists for highly skewed distributions

On 25 January 2018 at 22:19, Tom Lane wrote: > Dean Rasheed writes: >> It occurs to me that maybe a better test to exclude a value from the >> MCV list would be to demand that its relative standard error not be >> too high. Such a test, in addition

Re: proposal: alternative psql commands quit and exit

On Thu, Feb 1, 2018 at 12:01:37PM +0100, Daniel Verite wrote: > Bruce Momjian wrote: > > > One open issue is the existing help display is inaccurate on Windows: > > > > Use \\? for help or press control-C to clear the input buffer. > > ! #ifndef WIN32 > ! puts(_("Use control-D

Re: proposal: alternative psql commands quit and exit

On Thu, Feb 1, 2018 at 12:01:37PM +0100, Daniel Verite wrote: > Bruce Momjian wrote: > > > One open issue is the existing help display is inaccurate on Windows: > > > > Use \\? for help or press control-C to clear the input buffer. > > ! #ifndef WIN32 > ! puts(_("Use control-D

Re: [HACKERS] MERGE SQL Statement for PG11

On 30 January 2018 at 21:47, Peter Geoghegan wrote: > I'm glad that we all seem to agree that serialization failures as a > way of dealing with concurrency issues in READ COMMITTED mode are a > bad idea. ERRORs are undesirable, yet safe and correct. Doing better is as yet unclear

Re: Built-in connection pooling

On 01.02.2018 15:21, Vladimir Sitnikov wrote: Konstantin>I have obtained more results with YCSB benchmark and built-in connection pooling Could you provide more information on the benchmark setup you have used? For instance: benchmark library versions, PostgreSQL client version,

Re: Built-in connection pooling

Konstantin>I have obtained more results with YCSB benchmark and built-in connection pooling Could you provide more information on the benchmark setup you have used? For instance: benchmark library versions, PostgreSQL client version, additional/default benchmark parameters. Konstantin>Postgres

Re: Query running for very long time (server hanged) with parallel append

Thanks Rajkumar for catching this. I will have a look ... -- Thanks, -Amit Khandekar EnterpriseDB Corporation The Postgres Database Company

Re: [HACKERS] [PATCH] Improve geometric types

Hello, At Wed, 31 Jan 2018 17:33:42 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20180131.173342.26333067.horiguchi.kyot...@lab.ntt.co.jp> > 0003: This patch replaces "double" with float and bare arithmetic > and comparisons on double to special

line_perp() (?-|) is broken.

I happend to see a strange geometric calcualtion on master/HEAD. CREATE TABLE t (l1 line, l2 line); INSERT INTO t (SELECT line(point(0, 0), point(x, y)), line(point(0,0), point(-y, x)) FROM (SELECT random() x, random() y FROM generate_series(0, 1000)) AS a); SELECT l1?-|l2 AS is_perp, l1, l2

Re: [HACKERS] MERGE SQL Statement for PG11

On 31 January 2018 at 15:17, Robert Haas wrote: > On Tue, Jan 30, 2018 at 2:28 PM, Peter Geoghegan wrote: >> What's at issue here specifically is the exact behavior of >> EvalPlanQual() in the context of having *multiple* sets of WHEN quals >> that need to be

Re: proposal: alternative psql commands quit and exit

Bruce Momjian wrote: > One open issue is the existing help display is inaccurate on Windows: > > Use \\? for help or press control-C to clear the input buffer. ! #ifndef WIN32 ! puts(_("Use control-D to quit.")); ! #else ! puts(_("Use control-C to quit.")); ! #endif But

Re: [HACKERS] Bug in to_timestamp().

On Wed, Jan 31, 2018 at 05:53:29PM +0100, Dmitry Dolgov wrote: > Thanks for working on that! I haven't followed this thread before, and after a > quick review I have few side questions. Thank you for your comments! > Why not write `is_separator_char` using `isprint`, `isalpha`, `isdigit` from >

Re: Built-in connection pooling

I have obtained more results with YCSB benchmark and built-in connection pooling. Explanation of the benchmark and all results for vanilla Postgres and Mongo are available in Oleg Bartunov presentation about  JSON (at the end of presentation):

Re: [HACKERS] GnuTLS support

Re: Peter Eisentraut 2018-01-03 <99680dba-cf63-8151-1de2-46ca93897...@2ndquadrant.com> > One scenario is that if GnuTLS goes in, it's quite plausible that the > PG11 packages for Debian and Ubuntu will use it by default. But if it > doesn't support tls-server-endpoint, then a JDBC client

Re: no partition pruning when partitioning using array type

On 2017/12/11 14:31, Amit Langote wrote: > On 2017/12/09 3:46, Robert Haas wrote: >> On Fri, Dec 8, 2017 at 5:40 AM, Amit Langote wrote: >>> I noticed that if you partition using a array type column, partition >>> pruning using constraint exclusion fails to work due to a minor problem. >> >> I

Re: [HACKERS] [PATCH] Improve geometric types

> ! circle_contain_pt() does the following comparison and it > seems to be out of our current policy. > > point_dt(center, point) <= radius > > I suppose this should use FPle. > > FPle(point_dt(center, point), radius) > > The same is true of circle_contain_pt(),

Re: [HACKERS] [PATCH] Improve geometric types

> 1."COPT=-DGEODEBUG make" complains as follows. > > | geo_ops.c:2445:62: error: invalid type argument of unary ‘*’ (have > ‘float8 {aka double}’) > | printf("dist_ppoly_internal- segment 0/n distance is %f\n", *result); Fixing. > 2. line_construct_pm has been renamed to line_construct. I

Re: [HACKERS] Surjective functional indexes

On 1 February 2018 at 08:49, Konstantin Knizhnik wrote: > > > On 01.02.2018 03:10, Simon Riggs wrote: >> >> On 10 January 2018 at 09:54, Konstantin Knizhnik >> wrote: >> >>> (new version attached) >> >> Why this comment? >> >> Current

Re: constraint exclusion and nulls in IN (..) clause

Thanks for the comments. On 2018/02/01 16:40, Ashutosh Bapat wrote: > On Thu, Feb 1, 2018 at 12:26 PM, Amit Langote > wrote: >> Hi. >> >> When addressing a review comment on the fast partition pruning thread [1], >> I noticed that specifying null in the IN-list

Re: [HACKERS] Surjective functional indexes

On 01.02.2018 03:10, Simon Riggs wrote: On 10 January 2018 at 09:54, Konstantin Knizhnik wrote: (new version attached) Why this comment? Current implementation of projection optimization has to calculate index expression twice in case of hit (value of index

Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)?

On 02/01/2018 07:26 AM, David Rowley wrote: > On 30 January 2018 at 14:14, David G. Johnston > wrote: >> This bug has an obvious if annoying work-around and fixing the bug will >> likely cause people's code, that uses said work-around, to fail. Breaking >> people's

IndexJoin memory problem using spgist and boxes

Hi, I came across a strange memory problem when doing an IndexJoin using spgist on boxes. I also found it mentioned here:

Re: [HACKERS] Creating backup history files for backups taken from standbys

On Thu, Jan 11, 2018 at 09:47:42PM +0900, Michael Paquier wrote: > Cool. Thanks for the feedback. The last patch still applies, but no committer has been interested, so I am moving my patch to the next CF. -- Michael signature.asc Description: PGP signature