Re: Add "password_protocol" connection parameter to libpq

2019-08-18 Thread Michael Paquier
On Fri, Aug 16, 2019 at 02:11:57PM -0400, Jonathan S. Katz wrote: > To be pedantic, +1 on the channel_binding param. Seems like we are moving in this direction then. I don't object to the introduction of this parameter. We would likely want to do something for downgrade attacks in other cases

Re: [proposal] de-TOAST'ing using a iterator

2019-08-18 Thread John Naylor
On Fri, Aug 16, 2019 at 10:48 PM Binguo Bao wrote: > [v8 patch with cosmetic changes] Okay, looks good. I'll make a few style suggestions and corrections. In the course of looking at this again, I have a few other questions below as well. It looks like you already do this for the most part, but

Re: POC: Cleaning up orphaned files using undo logs

2019-08-18 Thread Dilip Kumar
On Sat, Aug 17, 2019 at 9:35 PM Robert Haas wrote: > > On Wed, Aug 14, 2019 at 12:39 PM Andres Freund wrote: > > > > Again, I think it's not ok to just assume you can lock an essentially > > > > unbounded number of buffers. This seems almost guaranteed to result in > > > > deadlocks. And there's

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-18 Thread Ahsan Hadi
On Mon, 19 Aug 2019 at 6:23 AM, Smith, Peter wrote: > > From: Ibrar Ahmed Sent: Sunday, 18 August 2019 > 2:43 AM > > +1 for voice call, bruce we usually have a weekly TDE call. I will > include you in > > If you don't mind, please also add me to that TDE call list. > Sure will do. >

Fix typos and inconsistencies for HEAD (take 11)

2019-08-18 Thread Alexander Lakhin
Hello hackers, Please consider fixing the last group (for now) of typos and inconsistencies in the tree: 11.1 peforming -> performing 11.2 table_freeze_age -> freeze_table_age 11.3 TableInfoData -> TableDataInfo 11.4 TableStatus -> PgStat_TableStatus 11.5 TAG_VALID -> BM_TAG_VALID 11.6

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

2019-08-18 Thread Kyotaro Horiguchi
Hello, At Sun, 18 Aug 2019 09:43:09 +0200, Daniel Migowski wrote in <6e25ca12-9484-8994-a1ee-40fdbe6af...@ikoffice.de> > Am 17.08.2019 um 19:10 schrieb Ibrar Ahmed: > > On Sat, Aug 17, 2019 at 6:58 PM Daniel Migowski > > wrote: > > > > > > attached you find a

RE: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-18 Thread Smith, Peter
> -Original Message- > From: Stephen Frost Sent: Friday, 16 August 2019 11:01 AM > Having direct integration with a KMS would certainly be valuable, and I don't > see a reason to deny users that option if someone would like to spend time > implementing it- in addition to a simpler

Re: Resume vacuum and autovacuum from interruption and cancellation

2019-08-18 Thread Masahiko Sawada
On Thu, Aug 8, 2019 at 10:42 PM Rafia Sabih wrote: > > On Tue, 16 Jul 2019 at 13:57, Masahiko Sawada wrote: > > > > On Wed, Jun 12, 2019 at 1:30 PM Masahiko Sawada > > wrote: > > > > > > Hi all, > > > > > > Long-running vacuum could be sometimes cancelled by administrator. And > > >

RE: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-18 Thread Smith, Peter
> From: Ibrar Ahmed Sent: Sunday, 18 August 2019 2:43 AM > +1 for voice call, bruce we usually have a weekly TDE call. I will include > you in If you don't mind, please also add me to that TDE call list. Thanks/Regards, --- Peter Smith Fujitsu Australia

Re: Unused header file inclusion

2019-08-18 Thread Tom Lane
I wrote: > (My headerscheck script is missing that header; I need to update it to > match the latest version of cpluspluscheck.) I did that, and ended up with the attached. I'm rather tempted to stick this into src/tools/ alongside cpluspluscheck, because it seems to find rather different

Re: pgsql: doc: Add some images

2019-08-18 Thread Alvaro Herrera
Hi Jürgen, On 2019-Aug-18, Jürgen Purtz wrote: > it is be possible that you face the following situation: the image > subdirectory contains all ditaa and graphviz source files, but not all > corresponding svg files. Those svg files are created by the given Makefile > of this subdirectory resp.

Re: FETCH FIRST clause PERCENT option

2019-08-18 Thread Ryan Lambert
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed The latest patch [1] and the cleanup patch [2] apply cleanly to

Re: Support for jsonpath .datetime() method

2019-08-18 Thread Alexander Korotkov
On Tue, Aug 13, 2019 at 12:08 AM Alexander Korotkov wrote: > On Thu, Aug 1, 2019 at 1:31 PM Thomas Munro wrote: > > On Sat, Jul 27, 2019 at 2:43 AM Andrew Dunstan > > wrote: > > > On 7/23/19 6:48 PM, Nikita Glukhov wrote: > > > > Some concrete pieces of review: > > > >> + > > > >> +

Re: Improve search for missing parent downlinks in amcheck

2019-08-18 Thread Alexander Korotkov
On Tue, Aug 13, 2019 at 11:44 PM Peter Geoghegan wrote: > > In this revision check for missing downlinks is combined with > > bt_downlink_check(). So, pages visited by bt_downlink_check() patch > > doesn't cause extra accessed. It only causes following additional > > page accesses: > > 1)

Re: Zedstore - compressed in-core columnar storage

2019-08-18 Thread Justin Pryzby
On Thu, Aug 15, 2019 at 01:05:49PM +0300, Heikki Linnakangas wrote: > We've continued hacking on Zedstore, here's a new patch version against > current PostgreSQL master (commit f1bf619acdf). If you want to follow the > development in real-time, we're working on this branch: >

Re: PANIC: could not flush dirty data: Operation not permitted power8, Redhat Centos

2019-08-18 Thread Thomas Munro
On Wed, Apr 17, 2019 at 1:04 PM Thomas Munro wrote: > On Mon, Apr 15, 2019 at 7:57 PM wrote: > > I forgot to mention that this is happening in a docker container. > > Huh, so there may be some configuration of Linux container that can > fail here with EPERM, even though that error that does not

Re: Rethinking opclass member checks and dependency strength

2019-08-18 Thread Tom Lane
Alexander Korotkov writes: > On Wed, Aug 7, 2019 at 7:28 PM Tom Lane wrote: >> This leads to the thought that maybe we could put some intelligence >> into an index-AM-specific callback instead. For example, for btree >> and hash the appropriate rule is probably that cross-type operators >> and

Re: Unused header file inclusion

2019-08-18 Thread Tom Lane
Andres Freund writes: > I've pushed the other ones. Checking whether header files compile standalone shows you were overly aggressive about removing fmgr.h includes: In file included from /tmp/headerscheck.Ss8bVx/test.c:3: ./src/include/utils/selfuncs.h:143: error: expected declaration

Re: [PATCH] minor doc fix for create-role

2019-08-18 Thread Tom Lane
t...@anne.cat writes: > Attached is a minor patch to fix the name param documentation for create > role, just adding a direct quote from user-manag.sgml talking about what the > role name is allowed to be. I was searching for this information and figured > the reference page should have it as

[PATCH] ltree, lquery, and ltxtquery binary protocol support

2019-08-18 Thread Nino Floris
Hi, Attached is a patch to support send/recv on ltree, lquery and ltxtquery. I'm a contributor to the Npgsql .NET PostgreSQL driver and we'll be the first to have official support once those ltree changes have been released. You can find the driver support work here, the tests verify a roundtrip

Re: pgsql: doc: Add some images

2019-08-18 Thread Jürgen Purtz
On 16.08.19 23:00, Alvaro Herrera wrote: On 2019-Mar-27, Peter Eisentraut wrote: doc: Add some images Add infrastructure for having images in the documentation, in SVG format. Add two images to start with. See the included README file for instructions. Author: Jürgen Purtz Author: Peter

Re: [PATCH] Implement INSERT SET syntax

2019-08-18 Thread Tom Lane
Peter Eisentraut writes: > What I don't like about the syntax is that it kind of breaks the > notional processing model of INSERT in a fundamental way. Agreed. I really don't like that this only works for a VALUES-like case (and only the one-row form at that). It's hard to see it as anything

Re: [PATCH] Implement INSERT SET syntax

2019-08-18 Thread Tom Lane
Vik Fearing writes: > On 18/08/2019 11:03, Peter Eisentraut wrote: >> a UNION b >> vs >> a UNION CORRESPONDING b > I have a WIP patch for CORRESPONDING [BY].  Is there any interest in me > continuing it?  If so, I'll start another thread for it. CORRESPONDING is in the SQL standard, so in

Re: [PATCH] Implement INSERT SET syntax

2019-08-18 Thread Vik Fearing
On 18/08/2019 11:03, Peter Eisentraut wrote: > > a UNION b > > vs > > a UNION CORRESPONDING b I have a WIP patch for CORRESPONDING [BY].  Is there any interest in me continuing it?  If so, I'll start another thread for it. -- Vik Fearing

Re: Creating partitions automatically at least on HASH?

2019-08-18 Thread Fabien COELHO
Hello Robert & Robert, - no partitions are created immediately (current case) but will have to be created manually later - static partitions are created automatically, based on provided parameters - dynamic partitions will be created later, when needed, based on provided parameters

Re: [PATCH] Implement INSERT SET syntax

2019-08-18 Thread Peter Eisentraut
On 2019-08-16 05:19, Amit Kapila wrote: > I think this can be a handy feature in some cases as pointed by you, > but do we really want it for PostgreSQL? In the last round of > discussions as pointed by you, there doesn't seem to be a consensus > that we want this feature. I guess before

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-08-18 Thread Peter Eisentraut
On 2019-08-17 08:16, Antonin Houska wrote: > One problem that occurs to me is that PG may need to send some sort of > credentials to the KMS. If it runs a separate process to execute the command, > it needs to pass those credentials to it. Whether it does so via parameters or > environment

Allow to_date() and to_timestamp() to accept localized names

2019-08-18 Thread Juan José Santamaría Flecha
Hello, Going through the current items in the wiki's todo list, I have been looking into: "Allow to_date () and to_timestamp () to accept localized month names". It seems to me that the code is almost there, so I would like to know if something like the attached patch would be a reasonable way

Re: Global temporary tables

2019-08-18 Thread Pavel Stehule
ne 18. 8. 2019 v 9:02 odesílatel Konstantin Knizhnik < k.knizh...@postgrespro.ru> napsal: > > > On 16.08.2019 20:17, Pavel Stehule wrote: > > > > pá 16. 8. 2019 v 16:12 odesílatel Konstantin Knizhnik < > k.knizh...@postgrespro.ru> napsal: > >> I did more investigations of performance of global

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

2019-08-18 Thread Daniel Migowski
Am 17.08.2019 um 19:10 schrieb Ibrar Ahmed: On Sat, Aug 17, 2019 at 6:58 PM Daniel Migowski > wrote: attached you find a patch that adds a new GUC: Quick questions before looking at the patch. prepared_statement_limit:  - Do we have a consensus about

Re: Global temporary tables

2019-08-18 Thread Konstantin Knizhnik
On 16.08.2019 20:17, Pavel Stehule wrote: pá 16. 8. 2019 v 16:12 odesílatel Konstantin Knizhnik mailto:k.knizh...@postgrespro.ru>> napsal: I did more investigations of performance of global temp tables with shared buffers vs. vanilla (local) temp tables. 1. Combination of