Re: [BUG] recovery of prepared transactions during promotion can fail

First off, thanks for the quick reaction and reviews, I appreciate it. On Wed, 2023-06-21 at 14:14 +0900, Michael Paquier wrote: > But that won't connect work as the segment requested is now a partial > one in the primary's pg_wal, still the standby wants it. I think since 009_twophase.pl

[BUG] recovery of prepared transactions during promotion can fail

Hey everyone, I've discovered a serious bug that leads to a server crash upon promoting an instance that crashed previously and did recovery in standby mode. The bug is present in PostgreSQL versions 13 and 14 (and in earlier versions, though it doesn't manifest itself so catastrophically).

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

On 03.08.2018 at 08:09 David Fetter wrote: I've rebased the patch atop master so it applies and passes 'make check-world'. I didn't make any other changes. Best, David. Much appreciated!

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

On 07/19/2018 03:00 AM, Thomas Munro wrote: Some more comments: if (parsedline->auth_method == uaCert) { - parsedline->clientcert = true; + parsedline->clientcert = clientCertOn; } The "cert" method is technically redundant with this

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

Hi Thomas, here's a rebased patch, with your observations corrected. Thomas Munro wrote on 2018-07-13: > + In this case, the CN (nommon name) provided in > "common name" > + CN (Common Name) in the certificate matches > "common"? (why a capital letter here?) I've resorted to "CN (Common

Re: [FEATURE PATCH] pg_stat_statements with plans (v02)

On Fri, 2018-04-06 at 13:57 -0700, legrand legrand wrote: > At startup time there are 2 identical plans found in the view > I thought it should have be only one: the "initial" one > (as long as there is no "good" or "bad" one). Yes, those are 'remnants' from the time where I had two columns, one

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

On Tue, 2018-04-10 at 18:35 +0200, Magnus Hagander wrote: > As Peter mentionde, there are in src/test/ssl. I forgot about those, > but yes, it would be useful to have that. I've added three tests: - verify-full specified, CN and username match -- should connect ok - verify-full specified, CN and

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

On Fri, 2018-04-06 at 20:31 +0200, Magnus Hagander wrote: > I've been through this one again. Thanks for taking the time! > There is one big omission from it -- it fails to work with the view > pg_hba_file_rules. When fixing that, things started to look kind of > ugly with the "two booleans to

Re: [FEATURE PATCH] pg_stat_statements with plans (v02)

On Thu, 2018-03-22 at 11:16 -0700, legrand legrand wrote: > Reading other pg_stat_statements threads on this forum, there are > also activ > developments to add: > - planing duration, > - first date, > - last_update date, As I see it, planning duration, first date, and last update date would be

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

On 1. of April 2018 17:46:38 MESZ wrote Magnus Hagander : >I assume this is a patch that's intended to be applied on top of the >previous patch? If so, please submit the complete pach to make sure the >correct combination ends up actually being reviewed. The v02.patch

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

On Sat, 2018-03-17 at 18:24 +0100, Magnus Hagander wrote: > > The error message "certificate authentication failed for user XYZ: > > > > client certificate contains no user name" is the result of calling > > > > CheckCertAuth when the user presented a certificate without a CN in > > it. > >

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

I just realized I made a whitespace error when I modified the comments. I hope I don't make a habit of sending erroneous mails. Please accept my apologies, as well as a guaranteed whitespace-error-free patch (updated to version 5 for clarity). Julian Julian Markwort schrieb am 2018-03-20

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

To anyone who followed along with this for so long, I'd like to present my newest version of this patch. As suggested by Arthur Zakirov, there is now only a single GUC ( pg_stat_statements.plan_track ) responsible for the selection of the plans that should be tracked. Possible values are: all,

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

Arthur Zakirov wrote on 2018-03-09: > I'd like to review the patch and leave a feedback. I tested it with > different indexes on same table and with same queries and it works fine. Thanks for taking some time to review my patch, Arthur! > First of all, GUC variables and functions. How about

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

Hello Magnus, > I think this makes a lot of sense, and can definitely be a useful > option. I was hesistant to write a long and elaborate patch as I wasn't certain if there was any interest for such an addition, but I'm thankful for your input. > However, the patch is completely lacking

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

I've goofed up now, sorry for failing to attach my updated patch. Am Donnerstag, den 08.03.2018, 14:55 +0100 schrieb Julian Markwort: > Tom Lane wrote on 2018-03-02: > > You need to make your changes in a 1.5--1.6 > > upgrade file. Otherwise there's no clean path for existing &g

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

Tom Lane wrote on 2018-03-02: > You need to make your changes in a 1.5--1.6 > upgrade file. Otherwise there's no clean path for existing > installations > to upgrade to the new version. I've adressed all the issues that were brought up so far: 1. there is now only an added 1.5--1.6.sql file. 2.

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

Andres Freund wrote on 2018-03-02: > Yea, I misread the diff to think you added a conflicting version. Due > to: > -DATA =3D pg_stat_statements--1.4.sql pg_stat_statements--1.4--1.5.sql \ > +DATA =3D pg_stat_statements--1.5.sql pg_stat_statements--1.4--1.5.sql \ > and I'd checked that 1.5 already

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

Andres Freund wrote on 2018-03-01: > I think the patch probably doesn't apply anymore, due to other changes > to pg_stat_statements since its posting. Could you refresh? pgss_plans_v02.patch applies cleanly to master, there were no changes to pg_stat_statements since the copyright updates at the

Re: Sample values for pg_stat_statements

. - Provide a function that allows users to take the jumbled query expression and have the database explain it, based on the parameters that were recorded previously. Kind regards Julian Markwort smime.p7s Description: S/MIME cryptographic signature

[PATCH] pg_hba.conf : new auth option : clientcert=verify-full

Dear Postgresql Hackers, as of now, pg_hba.conf allows us to enable authentification by certificate through the auth-method "cert", in which case the user must provide a valid certificate with a certificate common name(CN) matching the database user's name or an entry in a pg_ident map.

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

On 01/11/2018 03:43 PM, David Fetter wrote: Is the assumption of a normal distribution reasonable for outlier plans as you've seen them? This is a difficult but fair question. First of all, I'd like to clarify that the normal distribution is assumed for the set of all execution times matching

Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)

for the next commitfest as well. Kind regards Julian On 03/04/2017 02:56 PM, Julian Markwort wrote: Alright, for the next version of this patch I'll look into standard deviation (an implementation of Welfords' algorithm already exists in pg_stat_statements). On 3/4/17 14:18, Peter Eisentraut wrote