Re: Unimpressed with pg_attribute_always_inline

2018-01-08 Thread Andres Freund
Hi, On 2018-01-08 20:09:27 -0500, Peter Eisentraut wrote: > On 1/8/18 19:56, Tom Lane wrote: > > Peter Geoghegan writes: > >> Anyway, ISTM that it should be possible to make > >> pg_attribute_always_inline have no effect in typical debug builds. > >> Wouldn't that make everyone

Re: Unimpressed with pg_attribute_always_inline

2018-01-08 Thread Tom Lane
Peter Geoghegan writes: > Anyway, ISTM that it should be possible to make > pg_attribute_always_inline have no effect in typical debug builds. > Wouldn't that make everyone happy? That would improve matters, but do we have access to the -O switch level as an #if condition? The

Re: Unimpressed with pg_attribute_always_inline

2018-01-08 Thread Peter Geoghegan
On Mon, Jan 8, 2018 at 4:12 PM, Tom Lane wrote: > When I complained that always_inline inhibits debuggability, I did NOT > mean what shows up in perf reports. I'm talking about whether you can > break at, or single-step through, a function reliably and whether gdb > knows

Re: Unimpressed with pg_attribute_always_inline

2018-01-08 Thread Andres Freund
On 2018-01-08 19:12:08 -0500, Tom Lane wrote: > Andres Freund writes: > > Unless this pg_attribute_always_inline gets a lot more widely > > proliferated I don't see a need to change anything. Debuggability isn't > > meaningfully impacted by seing more runtime attributed to > >

Re: Unimpressed with pg_attribute_always_inline

2018-01-08 Thread Andres Freund
On 2018-01-05 00:11:19 +1300, Thomas Munro wrote: > On Tue, Jan 2, 2018 at 4:58 PM, Thomas Munro > wrote: > > On Tue, Jan 2, 2018 at 4:17 PM, Tom Lane wrote: > >> gaur | nodeHashjoin.c:167: warning: `always_inline' attribute > >>

Re: Unimpressed with pg_attribute_always_inline

2018-01-04 Thread Thomas Munro
On Tue, Jan 2, 2018 at 4:58 PM, Thomas Munro wrote: > On Tue, Jan 2, 2018 at 4:17 PM, Tom Lane wrote: >> gaur | nodeHashjoin.c:167: warning: `always_inline' attribute >> directive ignored >> mastodon |

Re: Unimpressed with pg_attribute_always_inline

2018-01-01 Thread Thomas Munro
On Tue, Jan 2, 2018 at 4:17 PM, Tom Lane wrote: > baiji | .\src\backend\executor\nodeHashjoin.c(165): warning C4141: > 'inline' : used more than once > bowerbird | src/backend/executor/nodeHashjoin.c(165): warning C4141: > 'inline' : used more than once >